Upload llm_agents.py

agents/llm_agents.py

@@ -688,8 +688,17 @@ You are Agent 3 of 4 in the Design System Analysis pipeline.
 - Type Scale Standard Ratio: 10 points
 - Base Size Accessible: 15 points
 - Spacing Grid: 15 points
-- Color Count: 10 points
-- No Near-Duplicates: 10 points"""
+- Color Count: 5 points
+- No Near-Duplicates: 5 points
+- Shadow System: 10 points (elevation hierarchy, consistency)
+
+## SHADOW SYSTEM BEST PRACTICES:
+- Use 3-6 elevation levels (xs, sm, md, lg, xl, 2xl)
+- Consistent Y-offset progression (shadows should grow with elevation)
+- Blur radius should increase with elevation (more blur = higher elevation)
+- Shadow colors should be neutral (black/gray with alpha) or brand-colored with low opacity
+- Avoid shadows with 0 blur (looks harsh/flat)
+- Avoid excessive blur (>32px for most use cases)"""
 
     PROMPT_TEMPLATE = """Validate the following design tokens against best practices and prioritize fixes.
 
@@ -716,6 +725,10 @@ You are Agent 3 of 4 in the Design System Analysis pipeline.
 - Duplicates: {duplicates}
 - Near-Duplicates: {near_duplicates}
 
+### Shadow System
+- Total Shadows: {shadow_count}
+- Shadow Values: {shadow_values}
+
 ## BEST PRACTICES CHECKLIST (check each one)
 
 1. Type scale uses standard ratio (1.2, 1.25, 1.333, 1.5, 1.618)
@@ -725,6 +738,7 @@ You are Agent 3 of 4 in the Design System Analysis pipeline.
 5. Spacing uses consistent grid (4px or 8px base)
 6. Limited color palette (< 20 unique semantic colors)
 7. No near-duplicate colors (< 3 delta-E apart)
+8. Shadow system has consistent elevation hierarchy (blur/Y-offset increase together)
 
 ## YOUR TASK
 
@@ -744,7 +758,8 @@ You are Agent 3 of 4 in the Design System Analysis pipeline.
     "aa_compliance": {{"status": "...", "note": "..."}},
     "spacing_grid": {{"status": "...", "note": "..."}},
     "color_count": {{"status": "...", "note": "..."}},
-    "near_duplicates": {{"status": "...", "note": "..."}}
+    "near_duplicates": {{"status": "...", "note": "..."}},
+    "shadow_system": {{"status": "...", "note": "Elevation hierarchy, blur consistency, color appropriateness"}}
   }},
   "priority_fixes": [
     {{
@@ -773,35 +788,47 @@ Return ONLY valid JSON."""
     async def analyze(
         self,
         rule_engine_results: Any,
+        shadow_tokens: dict = None,
         log_callback: Callable = None,
     ) -> BestPracticesResult:
         """
         Validate against best practices.
-        
+
         Args:
             rule_engine_results: Results from rule engine
+            shadow_tokens: Shadow tokens dict {name: {value: "..."}}
             log_callback: Progress logging function
-            
+
         Returns:
             BestPracticesResult with validation
         """
         def log(msg: str):
             if log_callback:
                 log_callback(msg)
-        
+
         log("")
         log("   ✅ SENTINEL — Best Practices Validator (Qwen 72B)")
         log("   └─ Checking against design system standards...")
-        
+
         # Extract data from rule engine
         typo = rule_engine_results.typography
         spacing = rule_engine_results.spacing
         color_stats = rule_engine_results.color_stats
         accessibility = rule_engine_results.accessibility
-        
+
         failures = [a for a in accessibility if not a.passes_aa_normal]
         failing_colors_str = ", ".join([f"{a.hex_color} ({a.contrast_on_white:.1f}:1)" for a in failures[:5]])
-        
+
+        # Format shadow data for the prompt
+        shadow_count = len(shadow_tokens) if shadow_tokens else 0
+        shadow_values_str = "None detected"
+        if shadow_tokens and shadow_count > 0:
+            shadow_list = []
+            for name, s in list(shadow_tokens.items())[:6]:
+                val = s.get("value", "") if isinstance(s, dict) else str(s)
+                shadow_list.append(f"{name}: {val[:50]}")
+            shadow_values_str = "; ".join(shadow_list)
+
         prompt = self.PROMPT_TEMPLATE.format(
             type_ratio=f"{typo.detected_ratio:.3f}",
             type_consistent="consistent" if typo.is_consistent else f"inconsistent, variance={typo.variance:.2f}",
@@ -817,6 +844,8 @@ Return ONLY valid JSON."""
             unique_colors=color_stats.unique_count,
             duplicates=color_stats.duplicate_count,
             near_duplicates=len(color_stats.near_duplicates),
+            shadow_count=shadow_count,
+            shadow_values=shadow_values_str,
         )
         
         try: