Upload folder using huggingface_hub

backend/services/notification_routing.py

@@ -154,12 +154,15 @@ class NotificationRoutingMiddleware:
         """
         settings = self.get_system_settings(company_id)
 
-        if not settings["admin_alerts"]:
+        if settings.get("admin_alerts") is False:
             self.log_notification_skipped(
                 company_id, NotificationType.ADMIN_ALERT, "admin_alerts_disabled"
             )
             return False
 
+        if settings.get("admin_alerts") is None:
+            return False
+
         self.log_notification_sent(company_id, NotificationType.ADMIN_ALERT)
         return True
 

backend/tests/test_notification_routing.py

@@ -0,0 +1,36 @@
+import pytest
+import sys
+from unittest.mock import patch, MagicMock
+
+sys.modules['supabase'] = MagicMock()
+sys.modules['dotenv'] = MagicMock()
+
+from backend.services.notification_routing import NotificationRoutingMiddleware, NotificationType
+
+
+class TestNotificationRoutingNoneHandling:
+    """Tests for handling None values in notification_routing service"""
+
+    def test_should_send_admin_alert_with_none_admin_alerts(self):
+        """Test that admin_alerts=None returns False"""
+        svc = NotificationRoutingMiddleware()
+
+        with patch.object(svc, 'get_system_settings', return_value={"admin_alerts": None}):
+            result = svc.should_send_admin_alert("company-123")
+            assert result is False
+
+    def test_should_send_admin_alert_with_false_admin_alerts(self):
+        """Test that admin_alerts=False returns False"""
+        svc = NotificationRoutingMiddleware()
+
+        with patch.object(svc, 'get_system_settings', return_value={"admin_alerts": False}):
+            result = svc.should_send_admin_alert("company-123")
+            assert result is False
+
+    def test_should_send_admin_alert_with_true_admin_alerts(self):
+        """Test that admin_alerts=True returns True"""
+        svc = NotificationRoutingMiddleware()
+
+        with patch.object(svc, 'get_system_settings', return_value={"admin_alerts": True}):
+            result = svc.should_send_admin_alert("company-123")
+            assert result is True