File size: 3,979 Bytes
e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 e903db0 a269447 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 | """Java code analyzer using Checkstyle."""
import subprocess
import tempfile
import os
import xml.etree.ElementTree as ET
from app.modules.analyzer_base import CodeAnalyzer, AnalysisResult
class JavaAnalyzer(CodeAnalyzer):
def __init__(self, language: str = "java"):
super().__init__(language)
self.checkstyle_available = self._check_checkstyle()
def _check_checkstyle(self) -> bool:
try:
result = subprocess.run(
["checkstyle", "-version"],
capture_output=True, timeout=5
)
return result.returncode == 0
except Exception:
return False
def analyze(self, code: str) -> AnalysisResult:
if not self.checkstyle_available:
return self._analyze_fallback(code)
with tempfile.NamedTemporaryFile(mode="w", suffix=".java", delete=False, encoding="utf-8") as f:
f.write(code)
temp_path = f.name
try:
result = subprocess.run(
["checkstyle", "-f", "xml", temp_path],
capture_output=True, text=True, timeout=15
)
issues = []
try:
root = ET.fromstring(result.stdout)
for file_elem in root.findall("file"):
for error_elem in file_elem.findall("error"):
line = error_elem.get("line", "0")
symbol = error_elem.get("source", "").split(".")[-1]
message = error_elem.get("message", "")
severity = error_elem.get("severity", "warning").lower()
severity_map = {"error": "high", "warning": "medium", "info": "low"}
severity = severity_map.get(severity, "low")
issues.append(self.format_issue(
line=int(line) if line.isdigit() else 0,
symbol=symbol,
message=message,
category="style",
severity=severity,
))
except ET.ParseError:
pass
return AnalysisResult(self.language, issues[:5])
except Exception as e:
return AnalysisResult(self.language, error=str(e))
finally:
if os.path.exists(temp_path):
os.unlink(temp_path)
def _analyze_fallback(self, code: str) -> AnalysisResult:
issues = []
lines = code.split("\n")
for i, line in enumerate(lines, 1):
stripped = line.strip()
if stripped.startswith("public ") and " = " in stripped:
if not any(kw in stripped for kw in ["final", "static"]):
issues.append(self.format_issue(
line=i,
symbol="mutable-field",
message="Public fields should be final or use getters/setters",
category="correctness",
severity="medium",
))
# FIX: check "String" in THIS line only, not the entire file
if "==" in line and "String" in line:
if ".equals(" not in line:
issues.append(self.format_issue(
line=i,
symbol="string-comparison",
message="Use .equals() to compare strings, not ==",
category="correctness",
severity="high",
))
if line.rstrip() != line:
issues.append(self.format_issue(
line=i,
symbol="trailing-spaces",
message="Trailing whitespace",
category="style",
severity="low",
))
return AnalysisResult(self.language, issues[:5]) |