Spaces:
Runtime error
Runtime error
File size: 8,566 Bytes
7ab7df1 ed005f8 b39a3c2 ed005f8 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 | """Tests for vectorstore module."""
import os
from unittest.mock import MagicMock, Mock, patch
import pytest
from vectorstore import (
create_new_vectorstore,
filter_metadata,
get_pdf_files,
get_text_splitter,
handle_existing_vectorstore,
load_or_create_vectorstore,
process_documents,
update_vectorstore,
)
def test_get_text_splitter():
"""Test text splitter creation."""
splitter = get_text_splitter()
assert splitter._chunk_size == 512
assert splitter._chunk_overlap == 128
def test_get_pdf_files_nonexistent_dir(tmp_path):
"""Test getting PDF files from non-existent directory."""
with patch("vectorstore.PDF_PATH", str(tmp_path / "nonexistent")):
files = get_pdf_files()
assert files == []
def test_get_pdf_files_empty_dir(tmp_path):
"""Test getting PDF files from empty directory."""
pdf_dir = tmp_path / "pdf"
pdf_dir.mkdir()
with patch("vectorstore.PDF_PATH", str(pdf_dir)):
files = get_pdf_files()
assert files == []
def test_filter_metadata_keep():
"""Test metadata filter keeps valid documents."""
doc = Mock(metadata={"section": "introduction"})
assert filter_metadata(doc) is True
def test_filter_metadata_skip_references():
"""Test metadata filter skips references section."""
doc = Mock(metadata={"section": "references"})
assert filter_metadata(doc) is False
def test_filter_metadata_skip_acknowledgments():
"""Test metadata filter skips acknowledgments section."""
doc = Mock(metadata={"section": "acknowledgments"})
assert filter_metadata(doc) is False
def test_filter_metadata_skip_appendix():
"""Test metadata filter skips appendix section."""
doc = Mock(metadata={"section": "appendix"})
assert filter_metadata(doc) is False
def test_filter_metadata_no_section():
"""Test metadata filter with no section."""
doc = Mock(metadata={})
assert filter_metadata(doc) is True
def test_process_documents(sample_documents):
"""Test document processing."""
splitter = get_text_splitter()
result = process_documents(sample_documents, splitter)
# Should filter out references document
assert len(result) < len(sample_documents)
assert all(not ("references" in doc.metadata.get("section", "").lower()) for doc in result)
@patch("vectorstore.Chroma")
@patch("vectorstore.os.path.exists")
def test_load_or_create_vectorstore_existing(mock_exists, mock_chroma, mock_embeddings):
"""Test loading existing vectorstore."""
mock_exists.return_value = True
mock_vectorstore = MagicMock()
mock_chroma.return_value = mock_vectorstore
with patch("vectorstore.handle_existing_vectorstore") as mock_handle:
mock_handle.return_value = mock_vectorstore
result = load_or_create_vectorstore(mock_embeddings)
assert result == mock_vectorstore
mock_handle.assert_called_once_with(mock_embeddings)
@patch("vectorstore.Chroma")
@patch("vectorstore.os.path.exists")
def test_load_or_create_vectorstore_new(mock_exists, mock_chroma, mock_embeddings):
"""Test creating new vectorstore."""
mock_exists.return_value = False
mock_vectorstore = MagicMock()
mock_chroma.from_documents.return_value = mock_vectorstore
with patch("vectorstore.create_new_vectorstore") as mock_create:
mock_create.return_value = mock_vectorstore
result = load_or_create_vectorstore(mock_embeddings)
assert result == mock_vectorstore
mock_create.assert_called_once_with(mock_embeddings)
@patch("vectorstore.get_pdf_files")
@patch("vectorstore.Chroma")
def test_handle_existing_vectorstore(mock_chroma, mock_get_pdfs, mock_embeddings):
"""Test handling existing vectorstore."""
mock_vectorstore = MagicMock()
mock_vectorstore.get.return_value = {
"metadatas": [
{"source": "pdf/existing.pdf"},
{"source": "pdf/another.pdf"},
]
}
mock_chroma.return_value = mock_vectorstore
mock_get_pdfs.return_value = ["pdf/existing.pdf", "pdf/new.pdf"]
with patch("vectorstore.update_vectorstore") as mock_update:
result = handle_existing_vectorstore(mock_embeddings)
assert result == mock_vectorstore
mock_update.assert_called_once()
@patch("vectorstore.get_pdf_files")
@patch("vectorstore.Chroma")
def test_handle_existing_vectorstore_no_new_files(mock_chroma, mock_get_pdfs, mock_embeddings):
"""Test handling existing vectorstore with no new files."""
mock_vectorstore = MagicMock()
mock_vectorstore.get.return_value = {
"metadatas": [{"source": "pdf/existing.pdf"}]
}
mock_chroma.return_value = mock_vectorstore
mock_get_pdfs.return_value = ["pdf/existing.pdf"]
with patch("vectorstore.update_vectorstore") as mock_update:
result = handle_existing_vectorstore(mock_embeddings)
assert result == mock_vectorstore
mock_update.assert_not_called()
@patch("vectorstore.DirectoryLoader")
@patch("vectorstore.process_documents")
def test_update_vectorstore(mock_process, mock_loader, mock_vectorstore):
"""Test updating vectorstore with new documents."""
mock_loader_instance = MagicMock()
mock_loader.return_value = mock_loader_instance
mock_loader_instance.load.return_value = [
Mock(metadata={"source": "pdf/new.pdf"}),
]
mock_docs = [Mock()]
mock_process.return_value = mock_docs
update_vectorstore(mock_vectorstore, ["pdf/new.pdf"], {"pdf/old.pdf"})
mock_vectorstore.add_documents.assert_called_once_with(mock_docs)
@patch("vectorstore.get_pdf_files")
@patch("vectorstore.DirectoryLoader")
@patch("vectorstore.Chroma")
def test_create_new_vectorstore(mock_chroma, mock_loader, mock_get_pdfs, mock_embeddings):
"""Test creating new vectorstore."""
mock_get_pdfs.return_value = ["pdf/test1.pdf", "pdf/test2.pdf"]
mock_loader_instance = MagicMock()
mock_loader.return_value = mock_loader_instance
mock_loader_instance.load.return_value = [Mock()]
mock_vectorstore = MagicMock()
mock_chroma.from_documents.return_value = mock_vectorstore
with patch("vectorstore.process_documents") as mock_process:
mock_process.return_value = [Mock()]
result = create_new_vectorstore(mock_embeddings)
assert result == mock_vectorstore
mock_chroma.from_documents.assert_called_once()
# Tests merged from test_vectorstore_edge_cases.py
@patch("vectorstore.get_pdf_files")
@patch("vectorstore.Chroma")
def test_handle_existing_vectorstore_no_pdfs(mock_chroma, mock_get_pdfs):
"""Test handle_existing_vectorstore with no PDF files."""
mock_vectorstore = MagicMock()
mock_chroma.return_value = mock_vectorstore
mock_get_pdfs.return_value = []
with pytest.raises(FileNotFoundError):
handle_existing_vectorstore(MagicMock())
@patch("vectorstore.get_pdf_files")
@patch("vectorstore.Chroma")
def test_handle_existing_vectorstore_empty_collection(mock_chroma, mock_get_pdfs):
"""Test handle_existing_vectorstore with empty collection."""
mock_vectorstore = MagicMock()
mock_vectorstore.get.return_value = None
mock_chroma.return_value = mock_vectorstore
mock_get_pdfs.return_value = ["pdf/test.pdf"]
with patch("vectorstore.update_vectorstore") as mock_update:
result = handle_existing_vectorstore(MagicMock())
assert result == mock_vectorstore
# Should still try to update with new PDFs
mock_update.assert_called_once()
@patch("vectorstore.get_pdf_files")
@patch("vectorstore.Chroma")
def test_handle_existing_vectorstore_no_metadatas(mock_chroma, mock_get_pdfs):
"""Test handle_existing_vectorstore with no metadatas."""
mock_vectorstore = MagicMock()
mock_vectorstore.get.return_value = {"metadatas": None}
mock_chroma.return_value = mock_vectorstore
mock_get_pdfs.return_value = ["pdf/test.pdf"]
with patch("vectorstore.update_vectorstore") as mock_update:
result = handle_existing_vectorstore(MagicMock())
assert result == mock_vectorstore
mock_update.assert_called_once()
# Tests merged from test_vectorstore_remaining.py
@patch("vectorstore.get_pdf_files")
@patch("vectorstore.DirectoryLoader")
@patch("vectorstore.Chroma")
def test_create_new_vectorstore_no_pdfs(mock_chroma, mock_loader, mock_get_pdfs):
"""Test create_new_vectorstore with no PDF files (lines 157-159)."""
mock_get_pdfs.return_value = []
with pytest.raises(FileNotFoundError):
create_new_vectorstore(MagicMock())
|