Update app.py

app.py

@@ -3,13 +3,10 @@ import gradio as gr
 import requests
 import pandas as pd
 
-# -------------------------------
-# Constants
-# -------------------------------
 DEFAULT_API_URL = "https://agents-course-unit4-scoring.hf.space"
 
 # -------------------------------
-# Basic Agent (可以換成你的 GAIA Agent)
+# Basic GAIA Agent
 # -------------------------------
 class BasicAgent:
     def __init__(self):
@@ -17,70 +14,53 @@ class BasicAgent:
 
     def __call__(self, question: str) -> str:
         print(f"Agent received question (first 50 chars): {question[:50]}...")
-        # TODO: 這裡改成你的 GAIA Agent 邏輯
         return "This is a default answer."
 
 # -------------------------------
 # Run & Submit Function
 # -------------------------------
 def run_and_submit_all(profile=None):
-    """
-    Fetch questions, run the agent, submit answers, return results
-    profile: Either HF profile (from LoginButton) or mock_profile dict
-    """
-    # --- HF Username ---
+    # HF Space Login Profile or local mock
     if profile and hasattr(profile, "username"):
         username = profile.username
-    elif isinstance(profile, dict) and "username" in profile:
-        username = profile["username"]
     else:
-        return "❌ Please login with your Hugging Face account.", None
+        # 本地測試用 mock profile
+        username = "local_user"
 
-    # --- Agent & Code Link ---
     agent = BasicAgent()
     space_id = os.getenv("SPACE_ID", "unknown")
     agent_code = f"https://huggingface.co/spaces/{space_id}/tree/main"
 
-    # --- Fetch Questions ---
+    # Fetch Questions
     try:
-        response = requests.get(f"{DEFAULT_API_URL}/questions", timeout=15)
-        response.raise_for_status()
-        questions_data = response.json()
+        resp = requests.get(f"{DEFAULT_API_URL}/questions", timeout=15)
+        resp.raise_for_status()
+        questions = resp.json()
     except Exception as e:
         return f"❌ Failed to fetch questions: {e}", None
 
-    if not questions_data:
+    if not questions:
         return "❌ No questions fetched.", None
 
-    # --- Run Agent ---
+    # Run Agent
     results_log = []
     answers_payload = []
-    for item in questions_data:
+    for item in questions:
         task_id = item.get("task_id")
         question_text = item.get("question")
         if not task_id or not question_text:
             continue
-        try:
-            ans = agent(question_text)
-            answers_payload.append({"task_id": task_id, "submitted_answer": ans})
-            results_log.append({
-                "Task ID": task_id,
-                "Question": question_text,
-                "Submitted Answer": ans
-            })
-        except Exception as e:
-            results_log.append({
-                "Task ID": task_id,
-                "Question": question_text,
-                "Submitted Answer": f"AGENT ERROR: {e}"
-            })
-
-    if not answers_payload:
-        return "❌ Agent did not produce any answers.", pd.DataFrame(results_log)
-
-    # --- Submit Answers ---
+        ans = agent(question_text)
+        answers_payload.append({"task_id": task_id, "submitted_answer": ans})
+        results_log.append({
+            "Task ID": task_id,
+            "Question": question_text,
+            "Submitted Answer": ans
+        })
+
+    # Submit
     submission_data = {
-        "username": username.strip(),
+        "username": username,
         "agent_code": agent_code,
         "answers": answers_payload
     }
@@ -107,26 +87,23 @@ with gr.Blocks() as demo:
     gr.Markdown("# Basic GAIA Agent Evaluation Runner")
     gr.Markdown(
         """
-        1. Log in with Hugging Face (Space only) or test locally with mock user.
+        **Instructions:**  
+        1. Log in with Hugging Face (Space only) or test locally with mock user.  
         2. Click 'Run Evaluation & Submit All Answers'.
         """
     )
 
-    # HF LoginButton only works in HF Space
     login_btn = gr.LoginButton()
-
     run_button = gr.Button("Run Evaluation & Submit All Answers")
-
     status_output = gr.Textbox(label="Run Status / Submission Result", lines=5, interactive=False)
     results_table = gr.DataFrame(label="Questions and Agent Answers", wrap=True)
 
-    # For HF Space, login_btn gives profile; locally we can pass mock_profile
+    # HF Space or local: 使用 lambda 包裝 profile
     run_button.click(
-        fn=lambda profile: run_and_submit_all(profile or {"username": "local_user"}),
+        fn=lambda profile: run_and_submit_all(profile),
         inputs=login_btn,
         outputs=[status_output, results_table]
     )
 
 if __name__ == "__main__":
-    print("Launching Gradio Interface...")
     demo.launch(debug=True, share=False)