fix(audit): ensure badges are only awarded on successful exercises

apps/whatsapp-worker/src/index.ts

@@ -147,27 +147,11 @@ const worker = new Worker('whatsapp-queue', async (job: Job) => {
                     }
                 }
 
-                // 🏅 WORKER WOW: Award Badge 🏅
-                const trackDayBadges = (trackDay as any)?.badges as string[] || [];
+                // 🌟 Adaptive Pedagogy: Dynamic Remediation Logic v1.0 🌟
+                let nextDay = currentDay + 1;
                 const currentProgress = await prisma.userProgress.findUnique({ where: { id: pendingProgressId } });
                 const currentBadges = ((currentProgress as any)?.badges as string[]) || [];
-
                 let updatedBadges = [...currentBadges];
-                for (const b of trackDayBadges) {
-                    if (!updatedBadges.includes(b)) updatedBadges.push(b);
-                }
-
-                await prisma.userProgress.update({
-                    where: { id: pendingProgressId },
-                    data: {
-                        exerciseStatus: 'COMPLETED',
-                        score: { increment: 1 },
-                        badges: updatedBadges
-                    } as any
-                });
-
-                // 🌟 Adaptive Pedagogy: Dynamic Remediation Logic v1.0 🌟
-                let nextDay = currentDay + 1;
 
                 if (feedbackData?.isQualified === false) {
                     const remediationDay = (exerciseCriteria as any)?.remediation?.dayNumber;
@@ -178,11 +162,27 @@ const worker = new Worker('whatsapp-queue', async (job: Job) => {
                         console.log(`[WORKER] Exercise not qualified but no remediation day defined. Staying on Day ${currentDay}.`);
                         nextDay = currentDay;
                     }
-                }
-                // If we were in a remediation day (fractional) and now qualified -> move to next integer day
-                else if (currentDay % 1 !== 0 && feedbackData?.isQualified !== false) {
-                    nextDay = Math.floor(currentDay) + 1;
-                    console.log(`[WORKER] Remediation successful for User ${userId}. Moving to Day ${nextDay}.`);
+                } else {
+                    // Success! Award Badges & Mark Completed
+                    const trackDayBadges = (trackDay as any)?.badges as string[] || [];
+                    for (const b of trackDayBadges) {
+                        if (!updatedBadges.includes(b)) updatedBadges.push(b);
+                    }
+
+                    await prisma.userProgress.update({
+                        where: { id: pendingProgressId },
+                        data: {
+                            exerciseStatus: 'COMPLETED',
+                            score: { increment: 1 },
+                            badges: updatedBadges
+                        } as any
+                    });
+
+                    // If we were in a remediation day (fractional) -> move to next integer day
+                    if (currentDay % 1 !== 0) {
+                        nextDay = Math.floor(currentDay) + 1;
+                        console.log(`[WORKER] Remediation successful for User ${userId}. Moving to Day ${nextDay}.`);
+                    }
                 }
 
                 await prisma.enrollment.updateMany({