Spaces:
Running
Running
File size: 11,043 Bytes
b35288f | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 | """
Fallback mechanism: notify the human academic advisor when the system can't
answer a question, and the LLM tool schema used to trigger this.
Delivery channels, selected by NOTIFY_CHANNEL:
- "email_api" (default): email over the Resend HTTPS API. The only channel
that works from Hugging Face Spaces: outbound SMTP (port 587) is blocked
there ([Errno 101] Network is unreachable) and Telegram blocks the
shared datacenter egress IPs by reputation β but outbound HTTPS on 443
works (LLM, embedding, and Azure TTS calls all succeed).
- "email": Gmail SMTP. Works locally; blocked from Spaces (see above).
- "telegram": the original bot notification (optionally through the
Cloudflare Worker relay, TELEGRAM_API_BASE). Reliable locally.
- "both": send on both the SMTP and Telegram channels.
Whichever channel is selected, the send runs in a daemon thread so delivery
latency (up to ~60s per attempt) never blocks the /chat request. If the
selected channel fails β in "both" mode, only if BOTH fail β the question is
appended to failed_questions.log instead.
"""
import json
import smtplib
import threading
import time
from datetime import datetime
from email.header import Header
from email.mime.text import MIMEText
import requests
from requests.exceptions import ReadTimeout, ConnectionError
from src.utils.config import (
ADVISOR_EMAIL,
NOTIFY_CHANNEL,
RESEND_API_KEY,
RESEND_FROM,
SMTP_APP_PASSWORD,
SMTP_EMAIL,
TELEGRAM_API_BASE,
TELEGRAM_BOT_TOKEN,
TELEGRAM_CHAT_ID,
)
SMTP_HOST = "smtp.gmail.com"
SMTP_PORT = 587
RESEND_API_URL = "https://api.resend.com/emails"
# ββ Channel selection (same pattern as VOICE_TTS in src/voice/config.py) ββ
DEFAULT_NOTIFY_CHANNEL = "email_api"
VALID_NOTIFY_CHANNELS = {"email_api", "email", "telegram", "both"}
def resolve_notify_channel(explicit: str | None = None) -> str:
ch = (explicit or NOTIFY_CHANNEL or DEFAULT_NOTIFY_CHANNEL).lower()
if ch not in VALID_NOTIFY_CHANNELS:
raise ValueError(f"notify channel must be one of {VALID_NOTIFY_CHANNELS}, got {ch!r}")
return ch
EMAIL_SUBJECT = "[Smart Advisor] Ψ³Ψ€Ψ§Ω Ψ¨ΨΨ§Ψ¬Ψ© Ω
ΨͺΨ§Ψ¨ΨΉΨ©"
def _email_body(student: dict, question: str) -> str:
timestamp = datetime.now().strftime("%Y-%m-%d %H:%M")
return (
f"[Smart Advisor] Unanswered Question\n\n"
f"Student Details\n"
f"Name : {student.get('name', 'Not provided')}\n"
f"Email : {student.get('email', 'Not provided')}\n"
f"Phone : {student.get('phone', 'Not provided')}\n"
f"Time : {timestamp}\n\n"
f"Unanswered Question\n{question}\n\n"
f"Sent automatically by the UCAS Smart Advisor system."
)
def _send_via_email(student: dict, question: str) -> bool:
body = _email_body(student, question)
msg = MIMEText(body, "plain", "utf-8")
msg["Subject"] = Header(EMAIL_SUBJECT, "utf-8")
msg["From"] = SMTP_EMAIL
msg["To"] = ADVISOR_EMAIL
try:
with smtplib.SMTP(SMTP_HOST, SMTP_PORT, timeout=60) as server: # 60s β same reasoning as the old Telegram timeout: tolerate a slow/weak connection
server.starttls()
server.login(SMTP_EMAIL, SMTP_APP_PASSWORD)
server.sendmail(SMTP_EMAIL, [ADVISOR_EMAIL], msg.as_string())
return True
except smtplib.SMTPAuthenticationError as e:
print(f"[Email] Authentication failed β check SMTP_EMAIL / SMTP_APP_PASSWORD: {e}")
return False
except (smtplib.SMTPException, OSError) as e:
print(f"[Email] Send failed: {e}")
return False
except Exception as e:
print(f"[Email] Unexpected error: {e}")
return False
def _send_via_resend(student: dict, question: str) -> bool:
"""Same message as the SMTP channel, but over the Resend HTTPS API
(port 443) β the only outbound path that works from HF Spaces."""
payload = {
"from": RESEND_FROM,
"to": [ADVISOR_EMAIL],
"subject": EMAIL_SUBJECT,
"text": _email_body(student, question),
}
try:
resp = requests.post(
RESEND_API_URL,
headers={"Authorization": f"Bearer {RESEND_API_KEY}"},
json=payload,
timeout=30,
)
except requests.RequestException as e:
print(f"[EmailAPI] Request failed: {e}", flush=True)
return False
if resp.status_code in (200, 201):
print("[EmailAPI] sent ok", flush=True)
return True
# Distinguish the two failure classes that need different fixes:
if resp.status_code in (401, 403):
print(
f"[EmailAPI] Authentication failed ({resp.status_code}) β check "
f"RESEND_API_KEY: {resp.text}",
flush=True,
)
elif 400 <= resp.status_code < 500:
print(
f"[EmailAPI] Request rejected ({resp.status_code}) β likely an "
f"unverified RESEND_FROM domain or invalid recipient: {resp.text}",
flush=True,
)
else:
print(f"[EmailAPI] Server error ({resp.status_code}): {resp.text}", flush=True)
return False
def _send_via_telegram(student: dict, question: str) -> bool:
timestamp = datetime.now().strftime("%Y-%m-%d %H:%M")
lines = [ # CHANGED β reverted escaping (legacy Markdown doesn't support it)
"*[Smart Advisor] Unanswered Question*",
"",
"*Student Details*",
f"Name : {student.get('name', 'Not provided')}",
f"Email : {student.get('email', 'Not provided')}",
f"Phone : {student.get('phone', 'Not provided')}",
f"Time : {timestamp}",
"",
"*Unanswered Question*",
f"{question}",
"",
"_Sent automatically by the UCAS Smart Advisor system._",
]
message = "\n".join(lines)
# Goes through the Cloudflare Worker relay (TELEGRAM_API_BASE) instead of
# api.telegram.org directly, to avoid Telegram blocking the datacenter egress IP
# that Hugging Face Spaces assigns on restart.
relay = (TELEGRAM_API_BASE or "https://api.telegram.org").rstrip("/")
url = f"{relay}/bot{TELEGRAM_BOT_TOKEN}/sendMessage"
payload = {
"chat_id": TELEGRAM_CHAT_ID,
"text": message,
"parse_mode": "Markdown",
}
print(f"[Telegram] posting via {relay}", flush=True)
max_retries = 3 # NEW β retry with backoff
for attempt in range(max_retries):
try:
resp = requests.post(url, json=payload, timeout=60) # CHANGED β was 15, now 60 for weak connections
result = resp.json()
if result.get("ok"):
print("[Telegram] sendMessage ok", flush=True)
return True
print(f"[Telegram] API returned error: {result}", flush=True)
return False # API error β no point retrying
except (ReadTimeout, ConnectionError) as e:
wait = 2 ** attempt # 1s, 2s, 4s
print(f"[Telegram] Attempt {attempt + 1} failed: {e}. Retrying in {wait}s...")
if attempt < max_retries - 1:
time.sleep(wait)
else:
print("[Telegram] All retries exhausted β question will be logged locally only.")
return False
except Exception as e:
print(f"[Telegram] Unexpected error: {e}")
return False
return False
def _send_fallback_background(student: dict, question: str) -> None:
"""
Runs in a background thread: does the actual send on the configured
channel(s) and, on failure, writes to the local backup log. Never touches
the request/response path, so a slow channel never delays the reply to
the student or blocks processing of their next question.
"""
try:
channel = resolve_notify_channel()
except ValueError as e:
print(f"[Notify] {e} β using default {DEFAULT_NOTIFY_CHANNEL!r}", flush=True)
channel = DEFAULT_NOTIFY_CHANNEL
success = False
if channel == "email_api":
success = _send_via_resend(student, question)
if channel in ("email", "both"):
success = _send_via_email(student, question) or success
if channel in ("telegram", "both"):
success = _send_via_telegram(student, question) or success
if not success: # local backup log ("both": only when both channels failed)
with open("failed_questions.log", "a", encoding="utf-8") as f:
f.write(
f"\n---\nTime: {datetime.now()}\n"
f"Name: {student.get('name')}\n"
f"Email: {student.get('email')}\n"
f"Phone: {student.get('phone')}\n"
f"Question: {question}\n"
)
def record_unknown_question(question: str, name: str, email: str = None, phone: str = None) -> dict:
"""
Fires the advisor notification in a background thread and returns
immediately β so a slow/blocked channel never delays the reply to the
student or the processing of their next question. Actual delivery
success/failure is only known inside the background thread (logged to
failed_questions.log on failure), not reflected in this return value.
"""
student = {"name": name, "email": email, "phone": phone}
threading.Thread(
target=_send_fallback_background,
args=(student, question),
daemon=True,
).start()
return {"recorded": "pending"}
# ββ LLM tool schema ββββββββββββββββββββββββββββββββββββββββββββββββββββββ
record_unknown_question_json = {
"name": "record_unknown_question",
"description": (
"Always use this tool to record any question that couldn't be answered. "
"Also records the student's details so the advisor can follow up."
),
"parameters": {
"type": "object",
"properties": {
"question": {"type": "string", "description": "The question that couldn't be answered"},
"name": {"type": "string", "description": "The student's full name"},
"email": {"type": "string", "description": "The student's email address"},
"phone": {"type": "string", "description": "The student's phone number"},
},
"required": ["question", "name"],
"additionalProperties": False,
},
}
tools = [{"type": "function", "function": record_unknown_question_json}]
def handle_tool_calls(tool_calls) -> list[dict]:
results = []
for tc in tool_calls:
args = json.loads(tc.function.arguments)
print(f"Tool called: {tc.function.name}", flush=True)
result = record_unknown_question(**args) if tc.function.name == "record_unknown_question" else {}
results.append({"role": "tool", "content": json.dumps(result), "tool_call_id": tc.id})
return results
|