major fix try

backend/runner/app.py

@@ -79,7 +79,6 @@ executor = ThreadPoolExecutor(max_workers=4)
 
 # Use the Space data volume, not the repo folder
 from .config import (
-    DATA_ROOT,
     ARTIFACTS_DIR,
     OUTPUTS_DIR,
     JSON_INFO_DIR,
@@ -202,32 +201,32 @@ def upload_file(run_id: str):
         
         # Ensure artifacts directory exists
         try:
-            os.makedirs(ARTIFACTS_DIR, exist_ok=True)
-            print(f"📤 Artifacts directory: {ARTIFACTS_DIR} (exists: {os.path.exists(ARTIFACTS_DIR)})")
+            ARTIFACTS_DIR.mkdir(parents=True, exist_ok=True)
+            print(f"📤 Artifacts directory: {ARTIFACTS_DIR} (exists: {ARTIFACTS_DIR.exists()})")
         except Exception as e:
             print(f"❌ Failed to create artifacts directory: {e}")
             return jsonify({"error": f"directory-creation-failed: {str(e)}"}), 500
         
         # Save the file as artifacts/<runId>.jpg
-        file_path = os.path.join(ARTIFACTS_DIR, f"{run_id}.jpg")
+        file_path = ARTIFACTS_DIR / f"{run_id}.jpg"
         print(f"📤 Saving file to {file_path}")
         
         try:
-            file.save(file_path)
+            file.save(str(file_path))
         except Exception as e:
             print(f"❌ Failed to save file: {e}")
             return jsonify({"error": f"file-save-failed: {str(e)}"}), 500
         
         # Check file exists otherwise 500
-        if not os.path.exists(file_path):
+        if not file_path.exists():
             print(f"❌ File not saved for run {run_id}")
             return jsonify({"error": "file-not-saved"}), 500
         
-        file_size = os.path.getsize(file_path)
+        file_size = file_path.stat().st_size
         print(f"✅ File saved successfully for run {run_id}, size: {file_size} bytes")
         
         # Respond with 204 No Content (success, no response body)
-        return "{}", 204
+        return "", 204
         
     except Exception as e:
         print(f"❌ Unexpected error in upload_file: {e}")
@@ -339,8 +338,8 @@ def get_output_file(filename: str):
         filename = filename + ".json"
 
     # Check if file exists
-    file_path = os.path.join(OUTPUTS_DIR, filename)
-    if not os.path.exists(file_path):
+    file_path = OUTPUTS_DIR / filename
+    if not file_path.exists():
         return jsonify({"error": "file-not-found"}), 404
 
     return send_from_directory(OUTPUTS_DIR, filename)
@@ -449,27 +448,34 @@ def cell_similarity():
             ]
         })
     
-    run_id = request.args["runId"]
-    row = int(request.args["row"])
-    col = int(request.args["col"])
-    k = int(request.args.get("k", 25))
-
-    # Get the run info to retrieve filtering parameters
-    run_info = RUNS.get(run_id, {})
-    topics = run_info.get("topics", [])
-    creators = run_info.get("creators", [])
-    model = run_info.get("model", "paintingclip")
-
-    img_path = ARTIFACTS_DIR / f"{run_id}.jpg"
-    results = inference.run_inference(
-        str(img_path),
-        cell=(row, col),
-        top_k=k,
-        filter_topics=topics,
-        filter_creators=creators,
-        model_type=model,
-    )
-    return jsonify(results)
+    try:
+        run_id = request.args["runId"]
+        row = int(request.args["row"])
+        col = int(request.args["col"])
+        k = int(request.args.get("k", 25))
+
+        # Get the run info to retrieve filtering parameters
+        run_info = RUNS.get(run_id, {})
+        topics = run_info.get("topics", [])
+        creators = run_info.get("creators", [])
+        model = run_info.get("model", "paintingclip")
+
+        img_path = ARTIFACTS_DIR / f"{run_id}.jpg"
+        if not img_path.exists():
+            return jsonify({"error": "image-not-found"}), 404
+            
+        results = inference.run_inference(
+            str(img_path),
+            cell=(row, col),
+            top_k=k,
+            filter_topics=topics,
+            filter_creators=creators,
+            model_type=model,
+        )
+        return jsonify(results)
+    except Exception as e:
+        print(f"❌ Error in cell_similarity: {e}")
+        return jsonify({"error": str(e)}), 500
 
 
 # --------------------------------------------------------------------------- #

backend/runner/config.py

@@ -6,30 +6,25 @@ All runner modules should import from this module instead of defining their own
 import os
 from pathlib import Path
 
-# Get the directory where this config.py file is located
-CONFIG_DIR = Path(__file__).parent.parent.parent  # Go up from backend/runner/config.py to project root
-
-# Data root from environment variable (set by Hugging Face Space)
-# Fall back to project data directory if /app/data doesn't exist or isn't writable
-DATA_ROOT_ENV = os.getenv("DATA_ROOT", "/app/data")
-DATA_ROOT = Path(DATA_ROOT_ENV)
-
-# Check if the default directory is writable, fall back to project data directory if not
-if not DATA_ROOT.exists() or not os.access(DATA_ROOT, os.W_OK):
-    print(f"⚠️  DATA_ROOT {DATA_ROOT} not writable, falling back to project data directory")
-    DATA_ROOT = CONFIG_DIR / "data"
+# READ root (repo data - read-only)
+PROJECT_ROOT = Path(__file__).resolve().parents[2]
+DATA_READ_ROOT = PROJECT_ROOT / "data"
+
+# WRITE root (Space volume or tmp - writable)
+WRITE_ROOT = Path(os.getenv("WRITE_ROOT", os.getenv("DATA_ROOT", "/data")))
+if not WRITE_ROOT.exists() or not os.access(WRITE_ROOT, os.W_OK):
+    print(f"⚠️  WRITE_ROOT {WRITE_ROOT} not writable, falling back to /tmp")
+    WRITE_ROOT = Path("/tmp")
 else:
-    print(f"✅ Using DATA_ROOT: {DATA_ROOT}")
+    print(f"✅ Using WRITE_ROOT: {WRITE_ROOT}")
 
-DATA_ROOT = DATA_ROOT.resolve()
+print(f"✅ Using READ_ROOT: {DATA_READ_ROOT}")
 
-# Core data directories
-EMBEDDINGS_DIR = DATA_ROOT / "embeddings"
-JSON_INFO_DIR = DATA_ROOT / "json_info"
-MODELS_DIR = DATA_ROOT / "models"
-OUTPUTS_DIR = DATA_ROOT / "outputs"
-ARTIFACTS_DIR = DATA_ROOT / "artifacts"
-MARKER_DIR = DATA_ROOT / "marker_output"
+# Read-only directories (from repo)
+EMBEDDINGS_DIR = DATA_READ_ROOT / "embeddings"
+JSON_INFO_DIR = DATA_READ_ROOT / "json_info"
+MODELS_DIR = DATA_READ_ROOT / "models"
+MARKER_DIR = DATA_READ_ROOT / "marker_output"
 
 # Model-specific embedding directories
 CLIP_EMBEDDINGS_DIR = EMBEDDINGS_DIR / "CLIP_Embeddings"
@@ -38,12 +33,9 @@ PAINTINGCLIP_EMBEDDINGS_DIR = EMBEDDINGS_DIR / "PaintingClip_Embeddings"
 # Model directories
 PAINTINGCLIP_MODEL_DIR = MODELS_DIR / "PaintingClip"
 
-# Metadata files
-SENTENCES_JSON = JSON_INFO_DIR / "sentences.json"
-WORKS_JSON = JSON_INFO_DIR / "works.json"
-TOPICS_JSON = JSON_INFO_DIR / "topics.json"
-CREATORS_JSON = JSON_INFO_DIR / "creators.json"
-TOPIC_NAMES_JSON = JSON_INFO_DIR / "topic_names.json"
+# Writable directories (outside repo)
+OUTPUTS_DIR = WRITE_ROOT / "outputs"
+ARTIFACTS_DIR = WRITE_ROOT / "artifacts"
 
 # Ensure writable directories exist
 for dir_path in [OUTPUTS_DIR, ARTIFACTS_DIR]:
@@ -52,3 +44,10 @@ for dir_path in [OUTPUTS_DIR, ARTIFACTS_DIR]:
         print(f"✅ Ensured directory exists: {dir_path}")
     except Exception as e:
         print(f"⚠️  Could not create directory {dir_path}: {e}")
+
+# Metadata files
+SENTENCES_JSON = JSON_INFO_DIR / "sentences.json"
+WORKS_JSON = JSON_INFO_DIR / "works.json"
+TOPICS_JSON = JSON_INFO_DIR / "topics.json"
+CREATORS_JSON = JSON_INFO_DIR / "creators.json"
+TOPIC_NAMES_JSON = JSON_INFO_DIR / "topic_names.json"

frontend/js/artefact-context.js

@@ -353,7 +353,18 @@ $(document).ready(function () {
         $('#exampleContainer').addClass('d-none');
         $('#workingOverlay').removeClass('d-none');
         $('#imageTools').removeClass('d-none');
-        fetchPresign();
+        
+        // Fix: Wait for image to load before proceeding
+        $('#uploadedImage').on('load', function() {
+          fetchPresign();
+        });
+        
+        // Fallback if load event doesn't fire
+        setTimeout(() => {
+          if ($('#uploadedImage').attr('src')) {
+            fetchPresign();
+          }
+        }, 1000);
       };
       reader.readAsDataURL(file);
     }
@@ -429,20 +440,26 @@ $(document).ready(function () {
  * and registering a run. Triggers polling for run status.
  */
 function fetchPresign() {
-  $('#debugStatus').text('Requesting ID...');
-  logWorkingMessage('Requesting Session ID...', 'text-white');
-
-  // Save the current image to history immediately when backend processing starts
-  saveCurrentImageToHistory();
-
-  fetch(`${API_BASE_URL}/presign`, {
-    method: 'POST',
-    headers: {
-      'Content-Type': 'application/json'
-    },
-    body: JSON.stringify({ fileName: 'selected.jpg' })
-  })
-    .then(res => res.json())
+  try {
+    $('#debugStatus').text('Requesting ID...');
+    logWorkingMessage('Requesting Session ID...', 'text-white');
+
+    // Fix: Call saveCurrentImageToHistory here
+    saveCurrentImageToHistory();
+
+    fetch(`${API_BASE_URL}/presign`, {
+      method: 'POST',
+      headers: {
+        'Content-Type': 'application/json'
+      },
+      body: JSON.stringify({ fileName: 'selected.jpg' })
+    })
+    .then(res => {
+      if (!res.ok) {
+        throw new Error(`Presign failed: ${res.status}`);
+      }
+      return res.json();
+    })
     .then(data => {
       runId = data.runId;
       imageKey = data.imageKey;
@@ -548,7 +565,14 @@ function fetchPresign() {
       console.error('Presign error:', err);
       $('#debugStatus').text('Error fetching ID');
       logWorkingMessage('Error fetching ID', 'text-danger');
+      // Fix: Show error to user and allow retry
+      $('#workingOverlay').addClass('d-none');
+      $('#uploadTrigger').removeClass('d-none');
     });
+  } catch (err) {
+    console.error('Error in fetchPresign:', err);
+    logWorkingMessage('Error in fetchPresign: ' + err.message, 'text-danger');
+  }
 }
 
 /**
@@ -557,11 +581,21 @@ function fetchPresign() {
  * @param {string} runId - The run/session ID to poll.
  */
 function pollRunStatus(runId) {
+  if (!runId) {
+    console.error('pollRunStatus called with invalid runId:', runId);
+    return;
+  }
+  
   logWorkingMessage('Polling run status...', 'text-white');
 
   const intervalId = setInterval(() => {
     fetch(`${API_BASE_URL}/runs/${runId}`)
-      .then(res => res.json())
+      .then(res => {
+        if (!res.ok) {
+          throw new Error(`Status check failed: ${res.status}`);
+        }
+        return res.json();
+      })
       .then(data => {
         $('#debugStatus').text(`Status: ${data.status}`);
         logWorkingMessage(`Status: ${data.status}`, 'text-white');
@@ -611,8 +645,10 @@ function pollRunStatus(runId) {
       })
       .catch(err => {
         console.error('Polling error:', err);
-        logWorkingMessage('Error polling status', 'text-danger');
+        logWorkingMessage('Error polling status: ' + err.message, 'text-danger');
         clearInterval(intervalId);
+        // Fix: Show error to user
+        $('#workingOverlay').addClass('d-none');
       });
   }, 1000);
 }
@@ -638,58 +674,71 @@ function escapeHTML(str) {
  * @param {Array|Object} data - Array of sentence objects or {sentences:[…]}
  */
 function display_sentences(data) {
-  console.log('display_sentences called with:', data); // Debug logging
-  
-  // normalise payload
-  if (!Array.isArray(data)) {
-    data = (data && Array.isArray(data.sentences)) ? data.sentences : [];
-  }
-  console.log('Normalized data:', data); // Debug logging
-  
-  if (!data.length) {                       // nothing to show ⇒ just hide overlay
-    $('#workingOverlay').addClass('d-none');
-    return;
-  }
-
-  // Show the sentences panel
-  $('.col-md-3').removeClass('d-none');
-  $('#sentenceList').empty();
-
-  /* ---------- sentence list construction ---------- */
-  data.forEach((item, index) => {
-    console.log(`Processing item ${index}:`, item); // Debug logging
+  try {
+    console.log('display_sentences called with:', data); // Debug logging
     
-    // Validate required fields
-    if (!item.english_original || typeof item.english_original !== 'string') {
-      console.warn(`Item ${index} has invalid english_original:`, item.english_original);
-      return; // Skip this item
+    // Validate input
+    if (!data) {
+      console.warn('display_sentences called with null/undefined data');
+      $('#workingOverlay').addClass('d-none');
+      return;
     }
     
-    const li = $(`
-      <li class="list-group-item sentence-item mb-1"
-          data-work="${item.work || 'unknown'}"
-          data-sentence="${escapeHTML(item.english_original)}">
-        <div class="d-flex align-items-center">
-          <span class="flex-grow-1">${escapeHTML(item.english_original)}</span>
-          <button class="btn btn-sm btn-outline-dark ms-2 heatmap-btn"
-                  title="View heatmap"
-                  data-sentence="${escapeHTML(item.english_original)}">
-            <i class="bi bi-thermometer-half"></i>
-          </button>
-        </div>
-      </li>
-    `);
-    li.find('span').on('click', function () {
-      lookupDOI(li.data('work'), li.data('sentence'));
-    });
-    li.find('.heatmap-btn').on('click', function(e) {
-      e.stopPropagation();
-      requestHeatmap($(this).data('sentence'));
+    // normalise payload
+    if (!Array.isArray(data)) {
+      data = (data && Array.isArray(data.sentences)) ? data.sentences : [];
+    }
+    console.log('Normalized data:', data); // Debug logging
+    
+    if (!data.length) {                       // nothing to show ⇒ just hide overlay
+      $('#workingOverlay').addClass('d-none');
+      return;
+    }
+
+    // Show the sentences panel
+    $('.col-md-3').removeClass('d-none');
+    $('#sentenceList').empty();
+
+    /* ---------- sentence list construction ---------- */
+    data.forEach((item, index) => {
+      console.log(`Processing item ${index}:`, item); // Debug logging
+      
+      // Validate required fields
+      if (!item.english_original || typeof item.english_original !== 'string') {
+        console.warn(`Item ${index} has invalid english_original:`, item.english_original);
+        return; // Skip this item
+      }
+      
+      const li = $(`
+        <li class="list-group-item sentence-item mb-1"
+            data-work="${item.work || 'unknown'}"
+            data-sentence="${escapeHTML(item.english_original)}">
+          <div class="d-flex align-items-center">
+            <span class="flex-grow-1">${escapeHTML(item.english_original)}</span>
+            <button class="btn btn-sm btn-outline-dark ms-2 heatmap-btn"
+                    title="View heatmap"
+                    data-sentence="${escapeHTML(item.english_original)}">
+              <i class="bi bi-thermometer-half"></i>
+            </button>
+          </div>
+        </li>
+      `);
+      li.find('span').on('click', function () {
+        lookupDOI(li.data('work'), li.data('sentence'));
+      });
+      li.find('.heatmap-btn').on('click', function(e) {
+        e.stopPropagation();
+        requestHeatmap($(this).data('sentence'));
+      });
+      $('#sentenceList').append(li);
     });
-    $('#sentenceList').append(li);
-  });
-  showBottomCards();
-  adjustMainWidth();
+    showBottomCards();
+    adjustMainWidth();
+  } catch (err) {
+    console.error('Error in display_sentences:', err);
+    logWorkingMessage('Error displaying sentences: ' + err.message, 'text-danger');
+    $('#workingOverlay').addClass('d-none');
+  }
 }
 
 // helper runs whenever the right-hand column is shown/hidden