File size: 13,184 Bytes
b14c6e3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
c18a9d1
b14c6e3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
c18a9d1
 
b14c6e3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
c18a9d1
b14c6e3
 
 
 
 
 
 
 
 
 
 
7cd2458
 
b14c6e3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
c18a9d1
b14c6e3
 
 
 
7cd2458
 
b14c6e3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
7cd2458
 
b14c6e3
 
 
 
 
 
7cd2458
b14c6e3
7cd2458
b14c6e3
 
 
 
 
 
 
 
7cd2458
 
b14c6e3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
7cd2458
 
b14c6e3
 
 
 
 
 
 
7cd2458
 
b14c6e3
 
7cd2458
 
b14c6e3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
7cd2458
b14c6e3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
"""
Unit Tests for Task Graders

Tests grading logic for easy, medium, and hard tasks.
"""

import pytest
from adaptive_alert_triage.models import Action, Alert, Reward
from tasks.easy import EasyTaskGrader
from tasks.medium import MediumTaskGrader
from tasks.hard import HardTaskGrader


class TestEasyTaskGrader:
    """Test easy task grading logic."""
    
    def test_critical_alert_correct(self):
        """Test correct handling of critical alert."""
        grader = EasyTaskGrader()
        
        alert = Alert(
            id="alert_001",
            visible_severity=0.85,
            confidence=0.9,
            alert_type="CPU",
            age=1,
            true_severity=0.90,  # Critical
        )
        action = Action(alert_id="alert_001", action_type="INVESTIGATE")
        reward = Reward(value=10.0)
        
        score = grader.grade_action(action, alert, reward)
        
        assert score == 1.0, "Should get full score for correct action"
        assert grader.correct_actions == 1
        assert grader.total_actions == 1
    
    def test_critical_alert_incorrect(self):
        """Test incorrect handling of critical alert (ignored)."""
        grader = EasyTaskGrader()
        
        alert = Alert(
            id="alert_002",
            visible_severity=0.7,
            confidence=0.8,
            alert_type="SECURITY",
            age=2,
            true_severity=0.95,  # Critical
        )
        action = Action(alert_id="alert_002", action_type="IGNORE")
        reward = Reward(value=-8.0)
        
        score = grader.grade_action(action, alert, reward)
        
        assert score == 0.0, "Should get zero score for missed critical"
        assert grader.correct_actions == 0
        assert grader.total_actions == 1
    
    def test_false_positive_correct(self):
        """Test correct handling of false positive (ignored)."""
        grader = EasyTaskGrader()
        
        alert = Alert(
            id="alert_003",
            visible_severity=0.3,
            confidence=0.4,
            alert_type="DISK",
            age=0,
            true_severity=0.15,  # False positive
        )
        action = Action(alert_id="alert_003", action_type="IGNORE")
        reward = Reward(value=3.0)
        
        score = grader.grade_action(action, alert, reward)
        
        assert score == 1.0, "Should get full score for ignoring FP"
        assert grader.correct_actions == 1
    
    def test_episode_score_calculation(self):
        """Test episode score aggregation."""
        grader = EasyTaskGrader()
        
        # 3 actions: 2 correct, 1 incorrect
        alerts_actions = [
            (Alert(id="a1", visible_severity=0.9, confidence=0.9, alert_type="CPU", 
                   age=1, true_severity=0.9), "INVESTIGATE", True),
            (Alert(id="a2", visible_severity=0.3, confidence=0.4, alert_type="DISK", 
                   age=0, true_severity=0.2), "IGNORE", True),
            (Alert(id="a3", visible_severity=0.8, confidence=0.8, alert_type="SECURITY", 
                   age=1, true_severity=0.95), "IGNORE", False),
        ]
        
        for alert, action_type, _ in alerts_actions:
            action = Action(alert_id=alert.id, action_type=action_type)
            reward = Reward(value=0.0)
            grader.grade_action(action, alert, reward)
        
        score = grader.get_episode_score()
        assert abs(score - 2/3) < 0.01, f"Expected 0.667, got {score}"
    
    def test_metrics_breakdown(self):
        """Test detailed metrics generation."""
        grader = EasyTaskGrader()
        
        alert = Alert(
            id="a1", visible_severity=0.9, confidence=0.9, alert_type="CPU",
            age=1, true_severity=0.9
        )
        action = Action(alert_id="a1", action_type="INVESTIGATE")
        reward = Reward(value=10.0)
        
        grader.grade_action(action, alert, reward)
        metrics = grader.get_metrics()
        
        assert "overall_score" in metrics
        assert "correct_actions" in metrics
        assert "critical_accuracy" in metrics
        assert "action_breakdown" in metrics


class TestMediumTaskGrader:
    """Test medium task grading logic with resource constraints."""
    
    def test_productive_investigation(self):
        """Test high-value investigation scores well."""
        grader = MediumTaskGrader(max_investigations_per_step=3)
        
        alert = Alert(
            id="alert_001",
            visible_severity=0.85,
            confidence=0.9,
            alert_type="CPU",
            age=1,
            true_severity=0.90,
        )
        action = Action(alert_id="alert_001", action_type="INVESTIGATE")
        reward = Reward(value=10.0)
        
        contribution = grader.grade_action(action, alert, reward)
        
        assert contribution > 0.0, "High-value investigation should contribute positively"
        assert grader._total_investigations == 1
    
    def test_wasteful_investigation(self):
        """Test investigation on false positive is penalized."""
        grader = MediumTaskGrader(max_investigations_per_step=3)
        
        alert = Alert(
            id="alert_002",
            visible_severity=0.3,
            confidence=0.4,
            alert_type="DISK",
            age=0,
            true_severity=0.15,  # False positive
        )
        action = Action(alert_id="alert_002", action_type="INVESTIGATE")
        reward = Reward(value=-2.0)
        
        contribution = grader.grade_action(action, alert, reward)
        assert contribution == 0.0, "Wasteful investigation should give zero contribution"
        assert grader._unnecessary_invest == 1
    
    def test_resource_efficiency_calculation(self):
        """Test resource efficiency metric."""
        grader = MediumTaskGrader(max_investigations_per_step=3)
        
        # 2 productive investigations, 1 wasteful
        alerts_actions = [
            (0.9, "INVESTIGATE", True),   # Productive
            (0.8, "INVESTIGATE", True),   # Productive
            (0.15, "INVESTIGATE", False), # Wasteful
        ]
        
        for true_sev, action_type, _ in alerts_actions:
            alert = Alert(
                id=f"a_{true_sev}", visible_severity=true_sev, confidence=0.8,
                alert_type="CPU", age=1, true_severity=true_sev
            )
            action = Action(alert_id=alert.id, action_type=action_type)
            reward = Reward(value=0.0)
            grader.grade_action(action, alert, reward)
        
        efficiency = grader.calculate_resource_efficiency()
        assert abs(efficiency - 2/3) < 0.01, f"Expected 0.667, got {efficiency}"
    
    def test_episode_score_with_efficiency(self):
        """Test that episode score considers efficiency factor."""
        grader = MediumTaskGrader(max_investigations_per_step=3)
        
        # Add some actions
        alert = Alert(
            id="a1", visible_severity=0.9, confidence=0.9, alert_type="CPU",
            age=1, true_severity=0.9
        )
        action = Action(alert_id="a1", action_type="INVESTIGATE")
        reward = Reward(value=10.0)
        
        grader.grade_action(action, alert, reward)
        score = grader.get_episode_score()
        
        assert 0.0 <= score <= 1.0, "Score should be normalized"
    
    def test_critical_missed_penalty(self):
        """Test missing critical alerts incurs penalty."""
        grader = MediumTaskGrader(max_investigations_per_step=3)
        
        alert = Alert(
            id="a1", visible_severity=0.8, confidence=0.8, alert_type="SECURITY",
            age=1, true_severity=0.95  # Critical
        )
        action = Action(alert_id="a1", action_type="IGNORE")
        reward = Reward(value=-8.0)
        
        grader.grade_action(action, alert, reward)
        
        assert grader._critical_missed == 1
        # Score should be penalized
        score = grader.get_episode_score()
        assert score < 0.5, "Missing critical should heavily impact score"


class TestHardTaskGrader:
    """Test hard task grading with correlation detection."""
    
    def test_correlation_detection(self):
        """Test bonus for handling correlated alerts."""
        correlation_chains = [["alert_001", "alert_002", "alert_003"]]
        grader = HardTaskGrader()
        grader.update_correlation_state(correlation_chains)
        
        alert = Alert(
            id="alert_001",
            visible_severity=0.8,
            confidence=0.85,
            alert_type="CPU",
            age=1,
            true_severity=0.85,
            is_correlated=True,
        )
        action = Action(alert_id="alert_001", action_type="INVESTIGATE")
        reward = Reward(value=10.0)
        
        contribution = grader.grade_action(action, alert, reward)
        
        assert contribution >= alert.true_severity, "Should be rewarded proportionally for chain trigger"
    
    def test_failure_prevention_bonus(self):
        """Test bonus for preventing cascading failures."""
        correlation_chains = [["alert_001", "alert_002", "alert_003"]]
        grader = HardTaskGrader()
        grader.update_correlation_state(correlation_chains)
        
        # Handle first alert in chain (early detection)
        alert = Alert(
            id="alert_001",
            visible_severity=0.75,
            confidence=0.85,
            alert_type="CPU",
            age=1,
            true_severity=0.80,
            is_correlated=True,
        )
        action = Action(alert_id="alert_001", action_type="INVESTIGATE")
        reward = Reward(value=10.0)
        
        grader.grade_action(action, alert, reward)
        
        m = grader.get_metrics()
        assert m["chains_stopped"] >= 1, "Should register failure prevention"
    
    def test_system_failure_penalty(self):
        """Test heavy penalty for system failures."""
        grader = HardTaskGrader()
        
        # Record a failure
        grader.record_failures(1)
        
        assert grader._system_failures == 1
        
        # Stability score should be reduced
        stability = grader.calculate_stability_score()
        assert stability < 1.0
    
    def test_missed_correlated_alert_penalty(self):
        """Test extra penalty for missing correlated alerts."""
        correlation_chains = [["alert_001", "alert_002"]]
        grader = HardTaskGrader()
        grader.update_correlation_state(correlation_chains)
        
        alert = Alert(
            id="alert_001",
            visible_severity=0.7,
            confidence=0.8,
            alert_type="CPU",
            age=1,
            true_severity=0.85,
            is_correlated=True,
        )
        action = Action(alert_id="alert_001", action_type="IGNORE")
        reward = Reward(value=-8.0)
        
        contribution = grader.grade_action(action, alert, reward)
        
        # Should have negative contribution for missing correlated critical
        assert contribution < -0.2, f"Should have extra penalty for correlated miss, got {contribution}"
    
    def test_correlation_detection_rate(self):
        """Test calculation of correlation detection rate."""
        correlation_chains = [
            ["alert_001", "alert_002"],
            ["alert_003", "alert_004"],
        ]
        grader = HardTaskGrader()
        grader.update_correlation_state(correlation_chains)
        
        # Handle one chain
        alert = Alert(id="alert_001", visible_severity=0.8, confidence=0.85, alert_type="CPU", age=1, true_severity=0.85, is_correlated=True)
        grader.grade_action(Action(alert_id="alert_001", action_type="INVESTIGATE"), alert, Reward(value=0))
        
        rate = grader.calculate_correlation_detection_rate()
        assert abs(rate - 0.5) < 0.01, "Should detect 50% of chains"
    
    def test_stability_score_perfect(self):
        """Test perfect stability (zero failures)."""
        grader = HardTaskGrader()
        
        stability = grader.calculate_stability_score()
        assert stability == 1.0, "Zero failures should give perfect stability"
    
    def test_stability_score_degraded(self):
        """Test degraded stability with failures."""
        grader = HardTaskGrader()
        
        # Multiple failures
        for _ in range(3):
            grader.record_failures(1)
        
        stability = grader.calculate_stability_score()
        assert stability < 1.0, "Failures should reduce stability"


def test_grader_reset():
    """Test that graders can be reset between episodes."""
    grader = EasyTaskGrader()
    
    # Do some actions
    alert = Alert(
        id="a1", visible_severity=0.9, confidence=0.9, alert_type="CPU",
        age=1, true_severity=0.9
    )
    action = Action(alert_id="a1", action_type="INVESTIGATE")
    reward = Reward(value=10.0)
    
    grader.grade_action(action, alert, reward)
    assert grader.total_actions == 1
    
    # Reset
    grader.reset()
    assert grader.total_actions == 0
    assert grader.correct_actions == 0
    assert len(grader.action_history) == 0


if __name__ == "__main__":
    pytest.main([__file__, "-v"])