Update app.py

app.py

@@ -796,107 +796,142 @@ class EnhancedVideoGenerator:
         return f"{hours:02d}:{minutes:02d}:{secs:02d},{msecs:03d}"
 
     def create_video(self, script: str, style: str, duration: int, output_path: str, selected_images: List[str]) -> str:
-        """Create video with selected images and improved error handling"""
-        try:
-            # Progress bar
-            progress_bar = st.progress(0)
-            status_text = st.empty()
-            
-            # Validate inputs
-            if not selected_images:
-                raise ValueError("No images selected. Please select at least one image.")
-            
-            if not script.strip():
-                raise ValueError("Script cannot be empty.")
-            
-            # Generate voice-over (20%)
-            status_text.text("Creating voice-over...")
-            audio = self.generate_voice_over(script)
-            progress_bar.progress(20)
-            
-            # Process selected images (40%)
-            status_text.text("Processing images...")
-            processed_images = []
-            
-            for img_url in selected_images:
-                try:
-                    response = requests.get(img_url, timeout=10)
-                    response.raise_for_status()  # Raise exception for bad status codes
-                    img = Image.open(BytesIO(response.content))
-                    img = img.convert('RGB')  # Ensure RGB format
-                    img = img.resize((1920, 1080), Image.Resampling.LANCZOS)
-                    processed_images.append(np.array(img))
-                except Exception as e:
-                    print(f"Error processing image {img_url}: {e}")
-                    continue
-            
-            if not processed_images:
-                raise ValueError("Failed to process any of the selected images.")
-                
-            progress_bar.progress(40)
-            
-            # Create frames with transitions
-            fps = 30
-            total_frames = int(duration * fps)
-            frames = []
-            
-            status_text.text("Generating frames...")
-            frames_per_image = total_frames // len(processed_images)
-            
-            for idx, img in enumerate(processed_images):
-                # Add main frames
-                for _ in range(frames_per_image):
-                    frames.append(img)
-                
-                # Add transition frames to next image
-                if idx < len(processed_images) - 1:
-                    next_img = processed_images[idx + 1]
-                    for alpha in np.linspace(0, 1, 15):
-                        transition_frame = (1 - alpha) * img + alpha * next_img
-                        frames.append(transition_frame.astype(np.uint8))
-            
-            progress_bar.progress(70)
-            
-            # Create video clip
-            status_text.text("Compiling video...")
-            video = ImageSequenceClip(frames, fps=fps)
-            
-            # Ensure audio duration matches video duration
-            audio_duration = audio.duration
-            video_duration = len(frames) / fps
-            
-            if audio_duration > video_duration:
-                audio = audio.subclip(0, video_duration)
-            elif audio_duration < video_duration:
-                video = video.subclip(0, audio_duration)
-            
-            video = video.set_audio(audio)
-            
-            progress_bar.progress(90)
-            
-            # Write final video with error handling
+    """Create video with selected images and improved error handling"""
+    try:
+        # Initialize progress tracking
+        progress_bar = st.progress(0)
+        status_text = st.empty()
+        
+        # Validate inputs
+        if not selected_images:
+            raise ValueError("No images selected. Please select at least one image.")
+        
+        if not script.strip():
+            raise ValueError("Script cannot be empty.")
+        
+        # Generate voice-over
+        status_text.text("Creating voice-over...")
+        audio = self.generate_fallback_audio(script)  # Using fallback audio for reliability
+        progress_bar.progress(20)
+        
+        # Process images
+        status_text.text("Processing images...")
+        processed_images = []
+        
+        for img_url in selected_images:
             try:
-                video.write_videofile(
-                    output_path,
-                    fps=fps,
-                    codec='libx264',
-                    audio_codec='aac',
-                    threads=4,
-                    preset='ultrafast'
-                )
+                response = requests.get(img_url, timeout=10)
+                response.raise_for_status()
+                img = Image.open(BytesIO(response.content))
+                img = img.convert('RGB')
+                img = img.resize((1920, 1080), Image.Resampling.LANCZOS)
+                processed_images.append(img)
             except Exception as e:
-                raise RuntimeError(f"Failed to write video file: {str(e)}")
-            
-            progress_bar.progress(100)
-            status_text.text("Video generation complete!")
-            
-            return output_path
-            
+                print(f"Error processing image {img_url}: {e}")
+                continue
+        
+        if not processed_images:
+            raise ValueError("Failed to process any of the selected images.")
+        
+        progress_bar.progress(40)
+        
+        # Create frames
+        status_text.text("Generating frames...")
+        frames = []
+        fps = 30
+        total_frames = int(duration * fps)
+        frames_per_image = total_frames // len(processed_images)
+        
+        # Convert images to numpy arrays
+        image_arrays = [np.array(img) for img in processed_images]
+        
+        # Generate frames with transitions
+        frame_count = 0
+        for idx, img_array in enumerate(image_arrays):
+            # Calculate how many frames this image should appear
+            if idx == len(image_arrays) - 1:
+                n_frames = total_frames - frame_count
+            else:
+                n_frames = min(frames_per_image, total_frames - frame_count)
+            
+            # Add main frames
+            for _ in range(n_frames):
+                frames.append(img_array)
+                frame_count += 1
+            
+            # Add transition frames to next image
+            if idx < len(image_arrays) - 1:
+                next_img_array = image_arrays[idx + 1]
+                transition_frames = 15  # Number of transition frames
+                for t in range(transition_frames):
+                    if frame_count < total_frames:
+                        alpha = t / transition_frames
+                        transition_frame = cv2.addWeighted(
+                            img_array, 1 - alpha,
+                            next_img_array, alpha, 0
+                        )
+                        frames.append(transition_frame)
+                        frame_count += 1
+        
+        progress_bar.progress(70)
+        
+        # Create video with frames
+        status_text.text("Compiling video...")
+        clip = ImageSequenceClip(frames, fps=fps)
+        
+        # Add audio
+        audio_duration = audio.duration
+        video_duration = len(frames) / fps
+        
+        if audio_duration > video_duration:
+            audio = audio.subclip(0, video_duration)
+        elif audio_duration < video_duration:
+            clip = clip.subclip(0, audio_duration)
+        
+        final_clip = clip.set_audio(audio)
+        
+        # Ensure output directory exists
+        output_dir = os.path.dirname(output_path)
+        if output_dir and not os.path.exists(output_dir):
+            os.makedirs(output_dir)
+        
+        progress_bar.progress(90)
+        
+        # Write video file
+        status_text.text("Saving video...")
+        try:
+            final_clip.write_videofile(
+                output_path,
+                fps=fps,
+                codec='libx264',
+                audio_codec='aac',
+                ffmpeg_params=['-pix_fmt', 'yuv420p'],  # Ensure compatibility
+                verbose=False,
+                logger=None
+            )
+        except Exception as e:
+            raise RuntimeError(f"Failed to write video file: {str(e)}")
+        
+        progress_bar.progress(100)
+        status_text.text("Video generation complete!")
+        
+        return output_path
+        
+    except Exception as e:
+        error_msg = f"Video creation failed: {str(e)}"
+        print(error_msg)  # For debugging
+        raise RuntimeError(error_msg)
+    finally:
+        # Cleanup
+        try:
+            if 'clip' in locals():
+                clip.close()
+            if 'final_clip' in locals():
+                final_clip.close()
+            if 'audio' in locals():
+                audio.close()
         except Exception as e:
-            error_msg = f"Video creation failed: {str(e)}"
-            self.logger.error(error_msg)
-            st.error(error_msg)
-            raise
+            print(f"Cleanup error: {e}")