Fix prepare_huggingface_generation_config

app.py

@@ -148,6 +148,9 @@ def prepare_huggingface_generation_config(generation_config):
     # According to experimentations, it seems that `transformers` behave similarly
 
     # I'm not sure what is the right behavior here, but it is better to be explicit
+    if "is_chat" not in generation_config:
+        generation_config["is_chat"] = False
+
     for name, params in GENERATION_CONFIG_PARAMS.items():
         if (
             "START" in params
@@ -160,19 +163,18 @@ def prepare_huggingface_generation_config(generation_config):
             else:
                 assert generation_config.get("do_sample", False)
 
-    # FIX: use .get() to avoid KeyError
     if generation_config.get("is_chat", False):
         generation_config["max_tokens"] = generation_config.pop("max_new_tokens")
         generation_config["stop"] = generation_config.pop("stop_sequences")
         del generation_config["do_sample"]
         del generation_config["top_k"]
 
+    # FIX: pop safely with default
     is_chat = generation_config.pop("is_chat", False)
 
     return generation_config, is_chat
 
 
-
 def escape_markdown(text):
     escape_dict = {
         "*": r"\*",