Update app.py

app.py

@@ -448,7 +448,7 @@ def display_bookmarks():
     logger.info("HTML display generated")
     return cards
 
-def process_uploaded_file(file, state_bookmarks, bookmark_selector):
+def process_uploaded_file(file, state_bookmarks):
     """
     Process the uploaded bookmarks file.
     """
@@ -457,23 +457,23 @@ def process_uploaded_file(file, state_bookmarks, bookmark_selector):
 
     if file is None:
         logger.warning("No file uploaded")
-        return "Please upload a bookmarks HTML file.", '', state_bookmarks, bookmark_selector.update(choices=[])
+        return "Please upload a bookmarks HTML file.", '', state_bookmarks, gr.update(choices=[])
 
     try:
         file_content = file.decode('utf-8')
     except UnicodeDecodeError as e:
         logger.error(f"Error decoding the file: {e}", exc_info=True)
-        return "Error decoding the file. Please ensure it's a valid HTML file.", '', state_bookmarks, bookmark_selector.update(choices=[])
+        return "Error decoding the file. Please ensure it's a valid HTML file.", '', state_bookmarks, gr.update(choices=[])
 
     try:
         bookmarks = parse_bookmarks(file_content)
     except Exception as e:
         logger.error(f"Error parsing bookmarks: {e}", exc_info=True)
-        return "Error parsing the bookmarks HTML file.", '', state_bookmarks, bookmark_selector.update(choices=[])
+        return "Error parsing the bookmarks HTML file.", '', state_bookmarks, gr.update(choices=[])
 
     if not bookmarks:
         logger.warning("No bookmarks found in the uploaded file")
-        return "No bookmarks found in the uploaded file.", '', state_bookmarks, bookmark_selector.update(choices=[])
+        return "No bookmarks found in the uploaded file.", '', state_bookmarks, gr.update(choices=[])
 
     # Assign unique IDs to bookmarks
     for idx, bookmark in enumerate(bookmarks):
@@ -493,7 +493,7 @@ def process_uploaded_file(file, state_bookmarks, bookmark_selector):
         faiss_index = vectorize_and_index(bookmarks)
     except Exception as e:
         logger.error(f"Error building FAISS index: {e}", exc_info=True)
-        return "Error building search index.", '', state_bookmarks, bookmark_selector.update(choices=[])
+        return "Error building search index.", '', state_bookmarks, gr.update(choices=[])
 
     message = f"✅ Successfully processed {len(bookmarks)} bookmarks."
     logger.info(message)
@@ -506,15 +506,15 @@ def process_uploaded_file(file, state_bookmarks, bookmark_selector):
     # Update state
     state_bookmarks = bookmarks.copy()
 
-    return message, bookmark_html, state_bookmarks, bookmark_selector.update(choices=choices)
+    return message, bookmark_html, state_bookmarks, gr.update(choices=choices)
 
-def delete_selected_bookmarks(selected_indices, state_bookmarks, bookmark_selector, bookmark_display_manage):
+def delete_selected_bookmarks(selected_indices, state_bookmarks):
     """
     Delete selected bookmarks and remove their vectors from the FAISS index.
     """
     global bookmarks, faiss_index
     if not selected_indices:
-        return "⚠️ No bookmarks selected.", bookmark_selector.update(choices=[]), display_bookmarks()
+        return "⚠️ No bookmarks selected.", gr.update(choices=[]), display_bookmarks()
 
     ids_to_delete = []
     indices_to_delete = []
@@ -545,16 +545,16 @@ def delete_selected_bookmarks(selected_indices, state_bookmarks, bookmark_select
     # Update state
     state_bookmarks = bookmarks.copy()
 
-    return message, bookmark_selector.update(choices=choices), display_bookmarks()
+    return message, gr.update(choices=choices), display_bookmarks()
 
-def edit_selected_bookmarks_category(selected_indices, new_category, state_bookmarks, bookmark_selector, bookmark_display_manage):
+def edit_selected_bookmarks_category(selected_indices, new_category, state_bookmarks):
     """
     Edit category of selected bookmarks.
     """
     if not selected_indices:
-        return "⚠️ No bookmarks selected.", bookmark_selector.update(choices=[]), display_bookmarks(), state_bookmarks
+        return "⚠️ No bookmarks selected.", gr.update(choices=[]), display_bookmarks(), state_bookmarks
     if not new_category:
-        return "⚠️ No new category selected.", bookmark_selector.update(choices=[]), display_bookmarks(), state_bookmarks
+        return "⚠️ No new category selected.", gr.update(choices=[]), display_bookmarks(), state_bookmarks
 
     indices = []
     for s in selected_indices:
@@ -581,7 +581,7 @@ def edit_selected_bookmarks_category(selected_indices, new_category, state_bookm
     # Update state
     state_bookmarks = bookmarks.copy()
 
-    return message, bookmark_selector.update(choices=choices), display_bookmarks(), state_bookmarks
+    return message, gr.update(choices=choices), display_bookmarks(), state_bookmarks
 
 def export_bookmarks():
     """
@@ -698,6 +698,12 @@ def build_app():
             # Initialize state
             state_bookmarks = gr.State([])
 
+            # Define 'bookmark_selector' globally
+            bookmark_selector = gr.CheckboxGroup(
+                label="✅ Select Bookmarks",
+                choices=[]
+            )
+
             # General Overview
             gr.Markdown("""
 # 📚 SmartMarks - AI Browser Bookmarks Manager
@@ -742,8 +748,8 @@ Navigate through the tabs to explore each feature in detail.
 
                 process_button.click(
                     process_uploaded_file,
-                    inputs=[upload, state_bookmarks, None],  # 'bookmark_selector' is defined within "Manage Bookmarks" tab
-                    outputs=[output_text, bookmark_display, state_bookmarks, gr.State(None)]
+                    inputs=[upload, state_bookmarks],
+                    outputs=[output_text, bookmark_display, state_bookmarks, bookmark_selector]
                 )
 
             with gr.Tab("Chat with Bookmarks"):
@@ -813,11 +819,9 @@ Navigate through the tabs to explore each feature in detail.
                 bookmark_display_manage = gr.HTML(label="📄 Bookmarks")
 
                 with gr.Row():
-                    # Define 'bookmark_selector' within the tab
-                    bookmark_selector = gr.CheckboxGroup(
-                        label="✅ Select Bookmarks",
-                        choices=[]
-                    )
+                    # Include 'bookmark_selector' within the tab
+                    # It is defined globally and will be displayed only in this tab via CSS
+                    bookmark_selector
 
                 with gr.Row():
                     delete_button = gr.Button("🗑️ Delete Selected")