fix activity log handling

src/controllers/invoice/invoice.controller.ts

@@ -12,7 +12,7 @@ import PwBuilding from "../../models/pwBuildings";
 import PwUnit from "../../models/pwUnits";
 import { logger } from '../../utils/logger';
 import ErrorLog from "../../models/errorLog";
-import { fetchBuildingPropertyManager, fetchWorkorderById } from "../../shared/services/propertyware.service";
+import { fetchBuildingsById, fetchPortfolioById, fetchUnitsById, fetchWorkorderById, fetchBuildingPropertyManager } from "../../shared/services/propertyware.service";
 import { logInvoiceAction } from "../invoiceActivityLogs.controller";
 import InvoiceApproval from "../../models/invoiceApproval";
 import Role from "../../models/roles";
@@ -441,9 +441,97 @@ const updateInvoiceDetails = async (invoiceId: number, billSplit: any[], userId:
 
   const invoiceDetails = await InvoiceDetail.bulkCreate(newInvoiceDetails);
 
-  // Log activity for each detail
-  for (const detail of newInvoiceDetails) {
-    await logInvoiceAction({ invoice_id: invoiceId, user_id: userId, activity_type: 'update', field_name: 'invoice_detail', old_value: JSON.stringify(existingInvoiceDetails), new_value: JSON.stringify(detail) });
+  for (let i = 0; i < newInvoiceDetails.length; i++) {
+    const newDetail: any = newInvoiceDetails[i];
+    const existingDetail: any = existingInvoiceDetails[i] || {};
+
+    const oldPortfolioName = existingDetail.pw_portfolio_id
+      ? (await fetchPortfolioById(existingDetail.pw_portfolio_id))?.name || 'Unknown Portfolio'
+      : 'null';
+    const newPortfolioName = newDetail.pw_portfolio_id
+      ? (await fetchPortfolioById(newDetail.pw_portfolio_id))?.name || ''
+      : 'null';
+
+    const oldBuildingName = existingDetail.pw_building_id
+      ? (await fetchBuildingsById(existingDetail.pw_building_id))?.name || 'Unknown Building'
+      : 'null';
+    const newBuildingName = newDetail.pw_building_id
+      ? (await fetchBuildingsById(newDetail.pw_building_id))?.name || ''
+      : 'null';
+
+    const oldUnitName = existingDetail.pw_unit_id
+      ? (await fetchUnitsById(existingDetail.pw_unit_id))?.name || 'Unknown Unit'
+      : 'null';
+    const newUnitName = newDetail.pw_unit_id
+      ? (await fetchUnitsById(newDetail.pw_unit_id))?.name || ''
+      : 'null';
+
+    if (!existingDetail.id) {
+      const newValue = `${newPortfolioName}, ${newBuildingName}, ${newUnitName}`;
+      await logInvoiceAction({
+        invoice_id: invoiceId,
+        user_id: userId,
+        activity_type: 'create',
+        field_name: 'bills split',
+        old_value: "null",
+        new_value: newValue,
+      });
+    } else {
+      if (oldPortfolioName !== newPortfolioName) {
+        await logInvoiceAction({
+          invoice_id: invoiceId,
+          user_id: userId,
+          activity_type: 'update',
+          field_name: 'portfolio',
+          old_value: oldPortfolioName,
+          new_value: newPortfolioName,
+        });
+      }
+
+      if (oldBuildingName !== newBuildingName) {
+        await logInvoiceAction({
+          invoice_id: invoiceId,
+          user_id: userId,
+          activity_type: 'update',
+          field_name: 'building',
+          old_value: oldBuildingName,
+          new_value: newBuildingName,
+        });
+      }
+
+      if (oldUnitName !== newUnitName) {
+        await logInvoiceAction({
+          invoice_id: invoiceId,
+          user_id: userId,
+          activity_type: 'update',
+          field_name: 'unit',
+          old_value: oldUnitName,
+          new_value: newUnitName,
+        });
+      }
+
+      if (newDetail.amount !== existingDetail.amount) {
+        await logInvoiceAction({
+          invoice_id: invoiceId,
+          user_id: userId,
+          activity_type: 'update',
+          field_name: 'amount',
+          old_value: String(existingDetail.amount || 0),
+          new_value: String(newDetail.amount || 0),
+        });
+      }
+
+      if (newDetail.description !== existingDetail.description) {
+        await logInvoiceAction({
+          invoice_id: invoiceId,
+          user_id: userId,
+          activity_type: 'update',
+          field_name: 'description',
+          old_value: existingDetail.description || '',
+          new_value: newDetail.description || '',
+        });
+      }
+    }
   }
 
   return invoiceDetails;

src/shared/interfaces/InvoiceActivityLog.interface.ts

@@ -4,7 +4,7 @@ export interface InvoiceActivityLogInterface {
     user_id: number;
     activity_type: string;
     field_name: string;
-    old_value?: string;
+    old_value?: string | null;
     new_value?: string;
     created_at?: Date;
   }

src/shared/services/propertyware.service.ts

@@ -36,7 +36,7 @@ export const fetchBuildingPropertyManager = async (buildingId: number  ) => {
 };
 
 export const fetchBuildingsById = async (buildingId: number) => {
-    const response = await apiClientPW.get(`/portfolios/${buildingId}`);
+    const response = await apiClientPW.get(`/buildings/${buildingId}`);
     return response.data;
 };