improvise erro handling of PW response

src/controllers/propertyware/bills.controller.ts

@@ -4,24 +4,32 @@ import Invoice from '../../models/invoice';
 import InvoiceDetail from '../../models/invoicedetail';
 import { createBill } from '../../shared/services/propertyware.service';
 import { formatDate } from '../../utils/dataUtils';
-import ErrorLog from './../../models/errorLog';
+import ErrorLog from '../../models/errorLog';
 import { createAuditLog } from '../auditLog.controller';
 
-export const syncInvoices = async (req: Request, res: Response) => {
+interface ErrorResponse {
+    response: {
+        data: {
+            userMessage: string;
+            errorCode: string;
+            errors?: Array<{ key: string; message: string }>;
+        }
+    }
+}
+
+export const syncInvoices = async (req: Request, res: Response): Promise<void> => {
     try {
         const invoices = await Invoice.findAll({
             where: { status: 'approved' },
-            include: [
-                { model: InvoiceDetail }
-            ]
+            include: [{ model: InvoiceDetail }]
         });
 
-        if (invoices.length == 0) {
+        if (invoices.length === 0) {
             res.end("No invoice to sync");
+            return;
         }
 
-        // Map the invoices to the bill request format
-        invoices.forEach(async (invoice) => {
+        const syncPromises = invoices.map(async (invoice) => {
             const bill = {
                 billDate: formatDate(invoice.invoice_date),
                 billSplits: invoice.InvoiceDetails.map(detail => ({
@@ -33,7 +41,7 @@ export const syncInvoices = async (req: Request, res: Response) => {
                     paid: false,
                     unitID: detail.pw_unit_id
                 })),
-                dueDate: invoice.due_date ? formatDate(invoice.due_date) : null, 
+                dueDate: invoice.due_date ? formatDate(invoice.due_date) : null,
                 vendorID: invoice.pw_vendor_id?.toString(),
                 billNumber: invoice.invoice_number,
                 comments: invoice.description,
@@ -41,32 +49,76 @@ export const syncInvoices = async (req: Request, res: Response) => {
                 terms: invoice.term,
                 workOrderID: invoice.pw_work_order_id,
             };
+
             try {
                 const response = await createBill(bill);
 
-                // add audit log for Update Invoice                
-                const auditLogData = { invoice_id: invoice.id as number, action_by: 1, action: 'Invoice sync to PW', details: `Bill for invoice ${bill.refNo} synced successfully. PW invoice id : ${response.id}`};
-                createAuditLog(auditLogData);
+                // Add audit log for Update Invoice
+                const auditLogData = {
+                    invoice_id: invoice.id as number,
+                    action_by: 1,
+                    action: 'Invoice sync to PW',
+                    details: `Bill for invoice ${bill.refNo} synced successfully. PW invoice id: ${response.id}`
+                };
+                await createAuditLog(auditLogData);
 
-                // Update Invoide status 
-                await invoice.update({status:'Sync success'});
+                // Update Invoice status
+                await invoice.update({ status: 'Sync success' });
 
                 logger.info(`Bill for invoice ${bill.refNo} synced successfully`);
             } catch (error) {
-                if (error instanceof Error ){
-                    await invoice.update({status:'Sync failed'})
+                let errorMessage = `Error syncing bill for invoice ${bill.refNo}.`;
+
+                const errorobj = (error as ErrorResponse);
+
+                const errordata = errorobj.response.data;
+
+                if (errordata) {
+                    if (errordata.errors && Array.isArray(errordata.errors)) {
+                        errorMessage += ` Errors: ${errordata.errors.map(e => `${e.key}: ${e.message}`).join(', ')}`;
+                    } else {
+                        errorMessage += ` ${errordata.userMessage}`;
+                    }
 
-                    logger.error(`Error syncing bill for invoice ${bill.refNo}`);
+                    logger.error(errorMessage);
+
+                    // Add entry to error log
+                    const errorLogData = {
+                        invoice_id: invoice.id as number,
+                        error_type: 'PW Sync Failed',
+                        error_details: errorMessage
+                    };
+                    await ErrorLog.create(errorLogData);
+                } else if (error instanceof Error) {
+
+                    logger.error(`Error syncing bill for invoice ${bill.refNo}: ${error.message}`);
+
+                    // Add entry to error log
+                    const errorLogData = {
+                        invoice_id: invoice.id as number,
+                        error_type: 'PW Sync Failed',
+                        error_details: `Error syncing bill for invoice ${bill.refNo}. ${error.message}`
+                    };
                     
-                    // add entry to error log
-                    const errorLogData = { invoice_id: invoice.id as number, error_type: 'PW Sync Failed', error_details: `Error syncing bill for invoice ${bill.refNo}. ${error.message}`};
+                    await ErrorLog.create(errorLogData);
+                } else {
+
+                    logger.error(`Unknown error syncing bill for invoice ${bill.refNo}`);
+                    logger.error(error);
+
+                    // Add entry to error log
+                    const errorLogData = {
+                        invoice_id: invoice.id as number,
+                        error_type: 'PW Sync Failed',
+                        error_details: `Unknown error syncing bill for invoice ${bill.refNo}`
+                    };
                     await ErrorLog.create(errorLogData);
                 }
-                logger.error(error);
+                await invoice.update({ status: 'Sync failed' });
             }
         });
 
-        
+        await Promise.all(syncPromises);
 
         res.end("Invoice data synced successfully");
     } catch (error) {