create separate service file for property ware syncs

src/controllers/propertyware/bills.controller.ts

@@ -1,13 +1,5 @@
 import { Request, Response } from 'express';
-import { logger } from '../../utils/logger';
-import Invoice from '../../models/invoice';
-import InvoiceDetail from '../../models/invoicedetail';
-import { createBill, uploadBill } from '../../shared/services/propertyware.service';
-import { formatDate } from '../../utils/dataUtils';
-import ErrorLog from '../../models/errorLog';
-import { createAuditLog } from '../auditLog.controller';
-import { updateInvoiceData } from '../invoice/invoice.controller';
-import { getDownloadUrl } from '../../shared/services/invoice.service';
+import { syncInvoicesService } from '../../shared/services/bills.service';
 
 interface ErrorResponse {
     response: {
@@ -27,122 +19,3 @@ export const syncInvoices = async (req: Request, res: Response): Promise<void> =
         res.status(500).send((error as Error).message);
     }
 };
-
-export const syncInvoicesService = async (): Promise<string> => {
-    try {
-        const invoices = await Invoice.findAll({
-            where: { status: 'Approved' },
-            include: [{ model: InvoiceDetail }]
-        });
-
-        if (invoices.length === 0) {
-            return "No invoice to sync";
-        }
-
-         const syncPromises = invoices.map(async (invoice) => {
-            const bill = {
-                billDate: formatDate(invoice.invoice_date),
-                billSplits: invoice.InvoiceDetails.map(detail => ({
-                    amount: detail.amount as number,
-                    glAccountID: detail.pw_gl_account_id,
-                    portfolioID: detail.pw_portfolio_id,
-                    buildingID: detail.pw_building_id,
-                    comments: detail.description,
-                    paid: false,
-                    unitID: detail.pw_unit_id
-                })),
-                dueDate: invoice.due_date ? formatDate(invoice.due_date) : null,
-                vendorID: invoice.pw_vendor_id?.toString(),
-                comments: invoice.description,
-                refNo: invoice.reference_number,
-                terms: invoice.term,
-                workOrderID: invoice.pw_work_order_id,
-            };
-
-            try {
-                const response = await createBill(bill);
-
-                // Add audit log for Update Invoice
-                const auditLogData = {
-                    invoice_id: invoice.id as number,
-                    action_by: 1,
-                    action: 'Invoice sync to PW',
-                    details: `Bill for invoice ${bill.refNo} synced successfully. PW invoice id: ${response.id}`
-                };
-                await createAuditLog(auditLogData);
-
-                try {
-
-                    // upload invoice file to propertyware
-                    if (invoice.filename) {
-                        const formData = new FormData();
-                        formData.append('file', invoice.pdf_url as string);
-                        const PWBillUploadResult = await uploadBill(response.id, formData);
-                    }
-                    
-                } catch (error) {
-                    console.log("invoice file upload failed : ", error);
-                }
-                // Update Invoice status
-                await updateInvoiceData(invoice.id as number, { status: 'Sync success' }, 1);
-
-                logger.info(`Bill for invoice ${bill.refNo} synced successfully`);
-            } catch (error) {
-                let errorMessage = `Error syncing bill for invoice ${bill.refNo}.`;
-                const errorobj = (error as ErrorResponse);
-
-                const errordata = errorobj.response.data;
-                console.log(errordata);
-                if (errordata) {
-                    if (errordata.errors && Array.isArray(errordata.errors)) {
-                        errorMessage += ` Errors: ${errordata.errors.map(e => `${e.key}: ${e.message}`).join(', ')}`;
-                    } else {
-                        errorMessage += ` ${errordata.userMessage}`;
-                    }
-
-                    logger.error(errorMessage);
-
-                    // Add entry to error log
-                    const errorLogData = {
-                        invoice_id: invoice.id as number,
-                        error_type: 'PW Sync Failed',
-                        error_details: errorMessage
-                    };
-                    await ErrorLog.create(errorLogData);
-                } else if (error instanceof Error) {
-
-                    logger.error(`Error syncing bill for invoice ${bill.refNo}: ${error.message}`);
-
-                    // Add entry to error log
-                    const errorLogData = {
-                        invoice_id: invoice.id as number,
-                        error_type: 'PW Sync Failed',
-                        error_details: `Error syncing bill for invoice ${bill.refNo}. ${error.message}`
-                    };
-                    
-                    await ErrorLog.create(errorLogData);
-                } else {
-
-                    logger.error(`Unknown error syncing bill for invoice ${bill.refNo}`);
-                    logger.error(error);
-
-                    // Add entry to error log
-                    const errorLogData = {
-                        invoice_id: invoice.id as number,
-                        error_type: 'PW Sync Failed',
-                        error_details: `Unknown error syncing bill for invoice ${bill.refNo}`
-                    };
-                    await ErrorLog.create(errorLogData);
-                }
-                await updateInvoiceData(invoice.id as number, { status: 'Sync Failed' }, 1);
-            }
-        });
-
-        await Promise.all(syncPromises);
-
-        return "Invoice data sync process completed successfully";
-    } catch (error) {
-        logger.error('Error while syncing invoices to propertyware:', error);
-        throw new Error('Error while syncing invoices to propertyware');
-    }
-};

src/controllers/propertyware/buildings.controller.ts

@@ -3,6 +3,7 @@ import { Request, Response } from 'express';
 import { fetchBuildings } from '../../shared/services/propertyware.service';
 import PwBuildings from '../../models/pwBuildings';
 import { logger } from '../../utils/logger';
+import { syncBuildingsDataService } from '../../shared/services/buildings.service';
 
 export const syncBuildingsData = async (req: Request, res: Response) => {
    try {
@@ -12,24 +13,3 @@ export const syncBuildingsData = async (req: Request, res: Response) => {
         res.status(500).send((error as Error).message);
     }
 };
-
-export const syncBuildingsDataService = async (): Promise<string> => {
-    try {
-        const buildingsData = await fetchBuildings();
-        const buildingsResponseData = buildingsData.map((building: Record<string, string>) => ({
-            pw_id: building.id,
-            name: building.name,
-            pw_portfolio_id: building.portfolioID
-        }));
-
-        await PwBuildings.bulkCreate(buildingsResponseData, {
-            updateOnDuplicate: ['name', 'pw_portfolio_id'],
-        });
-
-        logger.info("Buildings data synced successfully");
-        return "Buildings data synced successfully";
-    } catch (error) {
-        logger.error("Error syncing Buildings: ", error);
-        throw new Error("Error syncing Buildings");
-    }
-};

src/controllers/propertyware/portfolio.controller.ts

@@ -3,6 +3,7 @@ import { Request, Response } from 'express';
 import { fetchPortfolio } from '../../shared/services/propertyware.service';
 import PwPortfolio from './../../models/pwPortfolio';
 import { logger } from '../../utils/logger';
+import { syncPortfolioDataService } from '../../shared/services/portfolio.service';
 
 export const syncPortfolioData = async (req: Request, res: Response) => {
     try {
@@ -12,23 +13,3 @@ export const syncPortfolioData = async (req: Request, res: Response) => {
         res.status(500).send((error as Error).message);
     }
 };
-
-export const syncPortfolioDataService = async (): Promise<string> => {
-    try {
-        const portfolioData = await fetchPortfolio();
-        const portfolioResponseData = portfolioData.map((portfolio: { id: any; name: any; }) => ({
-            pw_id: portfolio.id,
-            name: portfolio.name,
-        }));
-
-        await PwPortfolio.bulkCreate(portfolioResponseData, {
-            updateOnDuplicate: ['name'],
-        });
-
-        logger.info("Portfolio data synced successfully");
-        return "Portfolio data synced successfully";
-    } catch (error) {
-        logger.error("Error syncing Portfolio: ", error);
-        throw new Error("Error syncing Portfolio");
-    }
-};

src/controllers/propertyware/units.controller.ts

@@ -1,9 +1,9 @@
 import { Request, Response } from 'express';
 
 import { fetchBuildings, fetchPortfolio, fetchUnits } from '../../shared/services/propertyware.service';
-import PwUnits from './../../models/pwUnits';
 import { extractIdAndName } from '../../utils/dataUtils';
 import { logger } from '../../utils/logger';
+import { syncUnitsDataService } from '../../shared/services/units.service';
 
 export const syncUnitsData = async (req: Request, res: Response) => {
     try {
@@ -14,28 +14,6 @@ export const syncUnitsData = async (req: Request, res: Response) => {
     }
 };
 
-export const syncUnitsDataService = async (): Promise<string> => {
-    try {
-        const unitsData = await fetchUnits();
-        const unitsResponseData = unitsData.map((unit: Record<string, string>) => ({
-            pw_id: unit.id,
-            name: unit.name,
-            pw_portfolio_id: unit.portfolioID,
-            pw_building_id: unit.buildingID
-        }));
-
-        await PwUnits.bulkCreate(unitsResponseData, {
-            updateOnDuplicate: ['name', 'pw_portfolio_id', 'pw_building_id'],
-        });
-
-        logger.info("Units data synced successfully");
-        return "Units data synced successfully";
-    } catch (error) {
-        logger.error("Error syncing Units: ", error);
-        throw new Error("Error syncing Units");
-    }
-};
-
 export const LocationLookup  = async (req: Request, res: Response) => {
     try {
       // Fetch portfolios

src/shared/services/bills.service.ts

@@ -0,0 +1,138 @@
+import { Request, Response } from 'express';
+import { logger } from '../../utils/logger';
+import Invoice from '../../models/invoice';
+import InvoiceDetail from '../../models/invoicedetail';
+import { createBill, uploadBill } from './propertyware.service';
+import { formatDate } from '../../utils/dataUtils';
+import ErrorLog from '../../models/errorLog';
+import { createAuditLog } from '../../controllers/auditLog.controller';
+import { updateInvoiceData } from '../../controllers/invoice/invoice.controller';
+
+interface ErrorResponse {
+    response: {
+        data: {
+            userMessage: string;
+            errorCode: string;
+            errors?: Array<{ key: string; message: string }>;
+        }
+    }
+}
+
+export const syncInvoicesService = async (): Promise<string> => {
+    try {
+        const invoices = await Invoice.findAll({
+            where: { status: 'Approved' },
+            include: [{ model: InvoiceDetail }]
+        });
+
+        if (invoices.length === 0) {
+            return "No invoice to sync";
+        }
+
+         const syncPromises = invoices.map(async (invoice) => {
+            const bill = {
+                billDate: formatDate(invoice.invoice_date),
+                billSplits: invoice.InvoiceDetails.map(detail => ({
+                    amount: detail.amount as number,
+                    glAccountID: detail.pw_gl_account_id,
+                    portfolioID: detail.pw_portfolio_id,
+                    buildingID: detail.pw_building_id,
+                    comments: detail.description,
+                    paid: false,
+                    unitID: detail.pw_unit_id
+                })),
+                dueDate: invoice.due_date ? formatDate(invoice.due_date) : null,
+                vendorID: invoice.pw_vendor_id?.toString(),
+                comments: invoice.description,
+                refNo: invoice.reference_number,
+                terms: invoice.term,
+                workOrderID: invoice.pw_work_order_id,
+            };
+
+            try {
+                const response = await createBill(bill);
+
+                // Add audit log for Update Invoice
+                const auditLogData = {
+                    invoice_id: invoice.id as number,
+                    action_by: 1,
+                    action: 'Invoice sync to PW',
+                    details: `Bill for invoice ${bill.refNo} synced successfully. PW invoice id: ${response.id}`
+                };
+                await createAuditLog(auditLogData);
+
+                try {
+
+                    // upload invoice file to propertyware
+                    if (invoice.filename) {
+                        const formData = new FormData();
+                        formData.append('file', invoice.pdf_url as string);
+                        const PWBillUploadResult = await uploadBill(response.id, formData);
+                    }
+                    
+                } catch (error) {
+                    console.log("invoice file upload failed : ", error);
+                }
+                // Update Invoice status
+                await updateInvoiceData(invoice.id as number, { status: 'Sync success' }, 1);
+
+                logger.info(`Bill for invoice ${bill.refNo} synced successfully`);
+            } catch (error) {
+                let errorMessage = `Error syncing bill for invoice ${bill.refNo}.`;
+                const errorobj = (error as ErrorResponse);
+
+                const errordata = errorobj.response.data;
+                console.log(errordata);
+                if (errordata) {
+                    if (errordata.errors && Array.isArray(errordata.errors)) {
+                        errorMessage += ` Errors: ${errordata.errors.map(e => `${e.key}: ${e.message}`).join(', ')}`;
+                    } else {
+                        errorMessage += ` ${errordata.userMessage}`;
+                    }
+
+                    logger.error(errorMessage);
+
+                    // Add entry to error log
+                    const errorLogData = {
+                        invoice_id: invoice.id as number,
+                        error_type: 'PW Sync Failed',
+                        error_details: errorMessage
+                    };
+                    await ErrorLog.create(errorLogData);
+                } else if (error instanceof Error) {
+
+                    logger.error(`Error syncing bill for invoice ${bill.refNo}: ${error.message}`);
+
+                    // Add entry to error log
+                    const errorLogData = {
+                        invoice_id: invoice.id as number,
+                        error_type: 'PW Sync Failed',
+                        error_details: `Error syncing bill for invoice ${bill.refNo}. ${error.message}`
+                    };
+                    
+                    await ErrorLog.create(errorLogData);
+                } else {
+
+                    logger.error(`Unknown error syncing bill for invoice ${bill.refNo}`);
+                    logger.error(error);
+
+                    // Add entry to error log
+                    const errorLogData = {
+                        invoice_id: invoice.id as number,
+                        error_type: 'PW Sync Failed',
+                        error_details: `Unknown error syncing bill for invoice ${bill.refNo}`
+                    };
+                    await ErrorLog.create(errorLogData);
+                }
+                await updateInvoiceData(invoice.id as number, { status: 'Sync Failed' }, 1);
+            }
+        });
+
+        await Promise.all(syncPromises);
+
+        return "Invoice data sync process completed successfully";
+    } catch (error) {
+        logger.error('Error while syncing invoices to propertyware:', error);
+        throw new Error('Error while syncing invoices to propertyware');
+    }
+};

src/shared/services/buildings.service.ts

@@ -0,0 +1,24 @@
+import { fetchBuildings } from './propertyware.service';
+import PwBuildings from '../../models/pwBuildings';
+import { logger } from '../../utils/logger';
+
+export const syncBuildingsDataService = async (): Promise<string> => {
+    try {
+        const buildingsData = await fetchBuildings();
+        const buildingsResponseData = buildingsData.map((building: Record<string, string>) => ({
+            pw_id: building.id,
+            name: building.name,
+            pw_portfolio_id: building.portfolioID
+        }));
+
+        await PwBuildings.bulkCreate(buildingsResponseData, {
+            updateOnDuplicate: ['name', 'pw_portfolio_id'],
+        });
+
+        logger.info("Buildings data synced successfully");
+        return "Buildings data synced successfully";
+    } catch (error) {
+        logger.error("Error syncing Buildings: ", error);
+        throw new Error("Error syncing Buildings");
+    }
+};

src/shared/services/cronJobs.ts

@@ -1,9 +1,9 @@
 import cron from 'node-cron';
 import { logger } from '../../utils/logger';
-import { syncPortfolioDataService } from '../../controllers/propertyware/portfolio.controller';
-import { syncBuildingsDataService } from '../../controllers/propertyware/buildings.controller';
-import { syncUnitsDataService } from '../../controllers/propertyware/units.controller';
-import { syncInvoicesService } from '../../controllers/propertyware/bills.controller';
+import { syncBuildingsDataService } from './buildings.service';
+import { syncPortfolioDataService } from './portfolio.service';
+import { syncInvoicesService } from './bills.service';
+import { syncUnitsDataService } from './units.service';
 
 export const setupCronJobs = () => {
     cron.schedule('0 0 * * *', async () => {

src/shared/services/portfolio.service.ts

@@ -0,0 +1,23 @@
+import { fetchPortfolio } from './propertyware.service';
+import PwPortfolio from '../../models/pwPortfolio';
+import { logger } from '../../utils/logger';
+
+export const syncPortfolioDataService = async (): Promise<string> => {
+    try {
+        const portfolioData = await fetchPortfolio();
+        const portfolioResponseData = portfolioData.map((portfolio: { id: any; name: any; }) => ({
+            pw_id: portfolio.id,
+            name: portfolio.name,
+        }));
+
+        await PwPortfolio.bulkCreate(portfolioResponseData, {
+            updateOnDuplicate: ['name'],
+        });
+
+        logger.info("Portfolio data synced successfully");
+        return "Portfolio data synced successfully";
+    } catch (error) {
+        logger.error("Error syncing Portfolio: ", error);
+        throw new Error("Error syncing Portfolio");
+    }
+};

src/shared/services/units.service.ts

@@ -0,0 +1,25 @@
+import { fetchUnits } from './propertyware.service';
+import PwUnits from '../../models/pwUnits';
+import { logger } from '../../utils/logger';
+
+export const syncUnitsDataService = async (): Promise<string> => {
+    try {
+        const unitsData = await fetchUnits();
+        const unitsResponseData = unitsData.map((unit: Record<string, string>) => ({
+            pw_id: unit.id,
+            name: unit.name,
+            pw_portfolio_id: unit.portfolioID,
+            pw_building_id: unit.buildingID
+        }));
+
+        await PwUnits.bulkCreate(unitsResponseData, {
+            updateOnDuplicate: ['name', 'pw_portfolio_id', 'pw_building_id'],
+        });
+
+        logger.info("Units data synced successfully");
+        return "Units data synced successfully";
+    } catch (error) {
+        logger.error("Error syncing Units: ", error);
+        throw new Error("Error syncing Units");
+    }
+};