bydefault get invoice list and users list in descending order, remove ACL restriction

src/controllers/invoice/invoice.controller.ts

@@ -316,7 +316,7 @@ export const getAllInvoices = async (req: AuthenticatedRequest, res: Response):
     if (sort_by && allowedSortColumns.includes(sort_by as string)) {
       options.order = [[sort_by as string, sort_order === 'desc' ? 'DESC' : 'ASC']];
     } else {
-      options.order = [['id', 'ASC']];
+      options.order = [['id', 'DESC']];
     }
 
     let invoices:any = await Invoice.findAll({

src/controllers/user.controller.ts

@@ -166,7 +166,7 @@ const getAllUsers = async (req: Request, res: Response) => {
     if (sort_by && allowedSortColumns.includes(sort_by as string)) {
       options.order = [[sort_by as string, sort_order === 'desc' ? 'DESC' : 'ASC']];
     } else {
-      options.order = [['id', 'ASC']];
+      options.order = [['id', 'DESC']];
     }
 
     const [users, totalUsers] = await Promise.all([

src/middlewares/checkPermissions.ts

@@ -7,28 +7,25 @@ import { APP_CONFIG } from '../config/app.config';
 export const checkPermission = (requiredPermission: string) => {
     return async (req: AuthenticatedRequest, res: Response, next: NextFunction) => {
         try {
-            // TODO : temporary check to disable ACL in staging and local
-            if (APP_CONFIG.env == "development") {
-                const userRoleId = req?.user?.role_id;
+            const userRoleId = req?.user?.role_id;
 
-                const hasPermission = await RolePermission.findOne({
-                    where: {
-                        role_id: userRoleId,
+            const hasPermission = await RolePermission.findOne({
+                where: {
+                    role_id: userRoleId,
+                },
+                include: [
+                    {
+                        model: Permission,
+                        where: { permission_name: requiredPermission },
+                        required: true,
                     },
-                    include: [
-                        {
-                            model: Permission,
-                            where: { permission_name: requiredPermission },
-                            required: true,
-                        },
-                    ],
-                });
+                ],
+            });
 
-                if (!hasPermission) {
-                    return res
-                        .status(403)
-                        .json({ message: 'Forbidden: You do not have permission to access this module' });
-                }
+            if (!hasPermission) {
+                return res
+                    .status(403)
+                    .json({ message: 'Forbidden: You do not have permission to access this module' });
             }
             next();
         } catch (error) {