optimize location lookup api

src/controllers/propertyware/units.controller.ts

@@ -27,53 +27,52 @@ export const syncUnitsDataFromUrl = async (req: Request, res: Response) => {
 
 export const LocationLookup = async (req: Request, res: Response) => {
     try {
-        // Fetch portfolios
-        const portfolios = await PwPortfolio.findAll({
-            attributes: ['pw_id', 'name'],
-          });
+        const unitsWithBuildingPortfolio = await PwUnit.findAll({
+            attributes: [['pw_id', 'id'], 'name'],
+            include: [
+                {
+                    model: PwPortfolio,
+                    as: 'portfolio',
+                    attributes: [['pw_id', 'id'], 'name'],
+                },
+                {
+                    model: PwBuilding,
+                    as: 'building',
+                    attributes: [['pw_id', 'id'], 'name'],
+                },
+            ],
+        });
 
-        const extractedPortfolio = portfolios.map(portfolio => ({
-            id: portfolio.getDataValue('pw_id'),
-            name: portfolio.getDataValue('name'),
-          }));
-
-        // Fetch buildings for each portfolio
-        const portfoliosWithBuildings = await Promise.all(extractedPortfolio.map(async (portfolio: { id: any; }) => {
-
-            const buildings = await PwBuilding.findAll({
-                attributes: ['pw_id', 'name'],
-                where: { pw_portfolio_id: portfolio.id }
-            });
-
-            const extractedBuildings = buildings.map(building => ({
-                id: building.getDataValue('pw_id'),
-                name: building.getDataValue('name'),
-            }));
-
-
-            // Fetch units for each building
-            const buildingsWithUnits = await Promise.all(extractedBuildings.map(async (building: { id: any; }) => {
-                
-                const units = await PwUnit.findAll({
-                    attributes: ['pw_id', 'name'],
-                    where: { pw_building_id: building.id }
-                });
-    
-                const extractedUnits = units.map(unit => ({
-                    id: unit.getDataValue('pw_id'),
-                    name: unit.getDataValue('name'),
-                }));
-                return { ...building, units: extractedUnits };
-            }));
-
-            return { ...portfolio, buildings: buildingsWithUnits };
-        }));
-
-        res.json(portfoliosWithBuildings);
+        const portfolios = transformUnitsToPortfolios(unitsWithBuildingPortfolio)
+        res.json(portfolios);
     } catch (error) {
-        console.log(error);
-        logger.error('Error fetching nested data:', error);
+        console.error('Error fetching location data:', error);
         res.status(500).json({ error: 'An error occurred while fetching data' });
     }
-}
+};
+
+function transformUnitsToPortfolios(units: any[]) {
+    const portfolios: any[] = [];
+  
+    units.forEach(unit => {
+      const { portfolio, building, id, name } = unit;
+  
+      let portfolioEntry = portfolios.find(p => p.id === portfolio.id);
+      if (!portfolioEntry) {
+        portfolioEntry = { id: portfolio.id, name: portfolio.name, buildings: [] };
+        portfolios.push(portfolioEntry);
+      }
+  
+      let buildingEntry = portfolioEntry.buildings.find((b: { id: any; }) => b.id === building.id);
+      if (!buildingEntry) {
+        buildingEntry = { id: building.id, name: building.name, units: [] };
+        portfolioEntry.buildings.push(buildingEntry);
+      }
+  
+      buildingEntry.units.push({ id, name });
+    });
+  
+    return portfolios;
+  }
   
+  

src/models/index.ts

@@ -1,6 +1,9 @@
 import { Options, Sequelize } from "sequelize";
 
 import { config } from "../db/config/db.config";
+import PwPortfolio from "./pwPortfolio";
+import PwBuilding from "./pwBuildings";
+import PwUnit from "./pwUnits";
 
 export const sequelize = new Sequelize(
   config.database as string,

src/models/pwUnits.ts

@@ -70,7 +70,7 @@ PwUnit.init(
     updatedAt: 'updated_at',
   }
 );
-PwUnit.belongsTo(PwPortfolio, { foreignKey: 'pw_portfolio_id', targetKey: 'pw_id' });
-PwUnit.belongsTo(PwBuilding, { foreignKey: 'pw_building_id', targetKey: 'pw_id' });
+PwUnit.belongsTo(PwPortfolio, { foreignKey: 'pw_portfolio_id', targetKey: 'pw_id', as: 'portfolio' });
+PwUnit.belongsTo(PwBuilding, { foreignKey: 'pw_building_id', targetKey: 'pw_id', as: 'building' });
 
 export default PwUnit;