File size: 6,174 Bytes
58d0e85
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
import unittest
from unittest.mock import AsyncMock, patch

from app.models import DNSResult, DisposableResult, SMTPResult, ValidationStatus
from app.validator.engine import EmailValidationEngine
from app.validator.retry_queue import MemoryRetryStore, RetryQueue


def _dns(host="mx.corp.test"):
    return DNSResult(
        domain_exists=True,
        has_mx_records=True,
        mx_records=[{"host": host, "priority": 10}],
    )


def _clean():
    return DisposableResult(
        is_disposable=False, is_free_provider=False, is_role_based=False
    )


class NullCache:
    async def get_dns(self, domain):
        return None

    async def put_dns(self, domain, result):
        return None

    async def get_verdict(self, email, deep):
        return None

    async def put_verdict(self, email, deep, smtp, catch_all):
        return None


class ScriptedProvider:
    def __init__(self, mapping):
        self.mapping = mapping

    async def verify_many(self, pairs):
        return (
            {e: self.mapping.get(e, SMTPResult(verified=True, smtp_code=250)) for e, _ in pairs},
            {},
        )

    async def verify(self, email, mx_host):
        return self.mapping.get(email, SMTPResult(verified=True, smtp_code=250))

    async def catch_all(self, domain, mx_host):
        return (False, 0.9)


class EngineRetryIntegrationTests(unittest.IsolatedAsyncioTestCase):
    """4xx rows must be re-queued (bounded), definitive rows must not."""

    async def test_greylisted_row_is_enqueued(self):
        clock = {"t": 0.0}
        queue = RetryQueue(store=MemoryRetryStore(), backoff_seconds=600, now=lambda: clock["t"])
        engine = EmailValidationEngine(
            mailbox=ScriptedProvider(
                {"a@corp.test": SMTPResult(verified=None, smtp_code=451,
                                           smtp_message="451 greylisted, try later")}
            ),
            cache=NullCache(),
            retry_queue=queue,
        )
        with (
            patch("app.validator.engine.check_dns", new=AsyncMock(return_value=_dns())),
            patch("app.validator.engine.check_disposable", return_value=_clean()),
        ):
            results = await engine.validate_batch(["a@corp.test"], deep=True)

        self.assertEqual(await queue.size(), 1)
        entry = (await queue.due(limit=1)) if clock["t"] > 600 else None
        # Still pending (not yet due), but queued.
        self.assertEqual(results[0].status, ValidationStatus.RISKY)

    async def test_verified_row_is_not_enqueued(self):
        queue = RetryQueue(store=MemoryRetryStore(), now=lambda: 0.0)
        engine = EmailValidationEngine(
            mailbox=ScriptedProvider(
                {"a@corp.test": SMTPResult(verified=True, smtp_code=250)}
            ),
            cache=NullCache(),
            retry_queue=queue,
        )
        with (
            patch("app.validator.engine.check_dns", new=AsyncMock(return_value=_dns())),
            patch("app.validator.engine.check_disposable", return_value=_clean()),
        ):
            await engine.validate_batch(["a@corp.test"], deep=True)

        self.assertEqual(await queue.size(), 0)

    async def test_rejected_row_is_not_enqueued(self):
        queue = RetryQueue(store=MemoryRetryStore(), now=lambda: 0.0)
        engine = EmailValidationEngine(
            mailbox=ScriptedProvider(
                {"a@corp.test": SMTPResult(verified=False, smtp_code=550,
                                           smtp_message="550 no such user")}
            ),
            cache=NullCache(),
            retry_queue=queue,
        )
        with (
            patch("app.validator.engine.check_dns", new=AsyncMock(return_value=_dns())),
            patch("app.validator.engine.check_disposable", return_value=_clean()),
        ):
            await engine.validate_batch(["a@corp.test"], deep=True)

        self.assertEqual(await queue.size(), 0)

    async def test_transport_failure_is_not_enqueued(self):
        # Systemic to the MX — the circuit breaker owns this, not the queue.
        queue = RetryQueue(store=MemoryRetryStore(), now=lambda: 0.0)
        engine = EmailValidationEngine(
            mailbox=ScriptedProvider(
                {"a@corp.test": SMTPResult(verified=None, error="transport_error: timed out")}
            ),
            cache=NullCache(),
            retry_queue=queue,
        )
        with (
            patch("app.validator.engine.check_dns", new=AsyncMock(return_value=_dns())),
            patch("app.validator.engine.check_disposable", return_value=_clean()),
        ):
            await engine.validate_batch(["a@corp.test"], deep=True)

        self.assertEqual(await queue.size(), 0)

    async def test_queue_failure_does_not_break_validation(self):
        class BrokenQueue:
            async def enqueue(self, *a, **k):
                raise RuntimeError("redis down")

        engine = EmailValidationEngine(
            mailbox=ScriptedProvider(
                {"a@corp.test": SMTPResult(verified=None, smtp_code=451)}
            ),
            cache=NullCache(),
            retry_queue=BrokenQueue(),
        )
        with (
            patch("app.validator.engine.check_dns", new=AsyncMock(return_value=_dns())),
            patch("app.validator.engine.check_disposable", return_value=_clean()),
        ):
            results = await engine.validate_batch(["a@corp.test"], deep=True)

        # The row still has a verdict; a broken queue must never lose it.
        self.assertEqual(len(results), 1)

    async def test_engine_without_queue_still_works(self):
        engine = EmailValidationEngine(
            mailbox=ScriptedProvider({"a@corp.test": SMTPResult(verified=True, smtp_code=250)}),
            cache=NullCache(),
        )
        with (
            patch("app.validator.engine.check_dns", new=AsyncMock(return_value=_dns())),
            patch("app.validator.engine.check_disposable", return_value=_clean()),
        ):
            results = await engine.validate_batch(["a@corp.test"], deep=True)

        self.assertEqual(results[0].status, ValidationStatus.VALID)


if __name__ == "__main__":
    unittest.main()