Update rust_highlight/src/lib.rs

rust_highlight/src/lib.rs

@@ -10,38 +10,42 @@ fn render_video(
     words: Vec<(String, (u32, u32, u32, u32))>,
 ) -> PyResult<String> {
     let clip = format!("clip{}.mp4", id);
-    let duration = duration.to_string();
+    let duration_str = duration.to_string();
 
+    // --- FFmpeg drawbox filters for each word ---
     let mut vf = String::new();
     let n = words.len() as f64;
-    for (i, (_, (x, y, w, h))) in words.iter().enumerate() {
-        let word_duration = duration.parse::<f64>().unwrap() / n;
-        let start = (i as f64) * word_duration;
-        let end = start + word_duration;
 
+    for (i, (_, (x, y, w, h))) in words.iter().enumerate() {
+        let start = (i as f64) * (duration / n);
+        let end = start + (duration / n);
         vf.push_str(&format!(
-        "drawbox=x={}:y={}:w={}:h={}:color=yellow@0.0:t=fill:enable='between(t,{:.3},{:.3})',",
-        x, y, w, h, start, end
-    ));
-}
-    vf = vf.trim_end_matches(',').to_string();
+            "drawbox=x={}:y={}:w={}:h={}:color=yellow@0.5:enable='between(t,{:.3},{:.3})',",
+            x, y, w, h, start, end
+        ));
+    }
+
+    // Trim trailing comma and add pixel format fix
+    let vf_with_format = format!("{},format=yuv420p", vf.trim_end_matches(','));
 
+    // --- FFmpeg command ---
     let status = Command::new("ffmpeg")
         .args(&[
-            "-y",
-            "-loop", "1",
-            "-i", image_path,
-            "-i", audio_path,
-            "-vf", &vf,
-            "-t", &duration,
-            "-c:v", "libx264",
-            "-pix_fmt", "yuv420p",
-            "-c:a", "aac",
-            &clip,
+            "-y",                    // Overwrite output
+            "-loop", "1",            // Loop image
+            "-i", image_path,        // Input image
+            "-i", audio_path,        // Input audio
+            "-vf", &vf_with_format,  // Video filter with highlights
+            "-t", &duration_str,     // Duration
+            "-c:v", "libx264",       // Video codec
+            "-pix_fmt", "yuv420p",   // Pixel format (for compatibility)
+            "-c:a", "aac",           // Audio codec
+            &clip,                   // Output file
         ])
         .status()
-        .expect("ffmpeg failed");
+        .expect("Failed to run ffmpeg");
 
+    // Return result
     if status.success() {
         Ok(clip)
     } else {
@@ -52,7 +56,7 @@ fn render_video(
 }
 
 #[pymodule]
-fn rust_highlight(py: Python, m: &PyModule) -> PyResult<()> {
+fn rust_highlight(_py: Python, m: &PyModule) -> PyResult<()> {
     m.add_function(wrap_pyfunction!(render_video, m)?)?;
     Ok(())
 }