File size: 16,904 Bytes
db883b3 7b4e84b 838ef01 db883b3 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 | """Public commit-boundary behavior for canonical execution failures."""
from collections.abc import AsyncIterator
from typing import Any
from unittest.mock import MagicMock, patch
import pytest
from fastapi.testclient import TestClient
from free_claude_code.core.anthropic.stream_contracts import parse_sse_text
from free_claude_code.core.anthropic.streaming import format_sse_event
from free_claude_code.core.failures import ExecutionFailure, FailureKind
from tests.api.support import create_test_app
_PARTIAL_CONTENT = "PARTIAL_ASSISTANT_CONTENT"
class CanonicalFailureProvider:
"""Provider double that raises one request-correlated canonical failure."""
def __init__(
self,
chunks: list[str],
*,
kind: FailureKind,
status_code: int,
message: str,
retryable: bool,
grouped: bool = False,
) -> None:
self._chunks = chunks
self._kind = kind
self._status_code = status_code
self._message = message
self._retryable = retryable
self._grouped = grouped
self.preflight_stream = MagicMock()
self.stream_kwargs: list[dict[str, Any]] = []
async def stream_response(
self,
_request: object,
**kwargs: Any,
) -> AsyncIterator[str]:
self.stream_kwargs.append(kwargs)
for chunk in self._chunks:
yield chunk
request_id = kwargs["request_id"]
failure = ExecutionFailure(
kind=self._kind,
status_code=self._status_code,
message=f"{self._message}\n\nRequest ID: {request_id}",
retryable=self._retryable,
)
if self._grouped:
raise ExceptionGroup(
"provider stream and cleanup failed",
[
RuntimeError("cleanup failed"),
ExceptionGroup("provider request failed", [failure]),
],
)
raise failure
def _messages_payload(*, stream: bool) -> dict[str, object]:
return {
"model": "nvidia_nim/test-model",
"messages": [{"role": "user", "content": "Hello"}],
"max_tokens": 32,
"stream": stream,
}
def _responses_payload() -> dict[str, object]:
return {
"model": "nvidia_nim/test-model",
"input": "Hello",
"max_output_tokens": 32,
}
def _partial_anthropic_stream(*, close_block: bool) -> list[str]:
chunks = [
format_sse_event("message_start", {"type": "message_start", "message": {}}),
format_sse_event(
"content_block_start",
{
"type": "content_block_start",
"index": 0,
"content_block": {"type": "text", "text": ""},
},
),
format_sse_event(
"content_block_delta",
{
"type": "content_block_delta",
"index": 0,
"delta": {"type": "text_delta", "text": _PARTIAL_CONTENT},
},
),
]
if close_block:
chunks.append(
format_sse_event(
"content_block_stop",
{"type": "content_block_stop", "index": 0},
)
)
return chunks
def _client_for(provider: CanonicalFailureProvider):
app = create_test_app()
return (
patch("free_claude_code.api.routes.resolve_provider", return_value=provider),
TestClient(app),
)
def _terminal_trace(trace_mock: MagicMock) -> dict[str, Any]:
return dict(
next(
call.kwargs
for call in trace_mock.call_args_list
if call.kwargs.get("event")
== "free_claude_code.api.response.terminal_execution_error"
)
)
def _grouped_rate_limit_provider(chunks: list[str]) -> CanonicalFailureProvider:
return CanonicalFailureProvider(
chunks,
kind=FailureKind.RATE_LIMIT,
status_code=429,
message="upstream is busy",
retryable=True,
grouped=True,
)
@pytest.mark.parametrize(
("path", "payload", "expected_type"),
[
("/v1/messages", _messages_payload(stream=True), "rate_limit_error"),
("/v1/responses", _responses_payload(), "rate_limit_error"),
],
)
def test_grouped_pre_start_execution_failure_keeps_canonical_wire_error(
path: str,
payload: dict[str, object],
expected_type: str,
) -> None:
provider = _grouped_rate_limit_provider([])
resolver_patch, client = _client_for(provider)
with (
resolver_patch,
patch("free_claude_code.api.response_streams.trace_event") as trace_mock,
client,
):
response = client.post(path, json=payload)
request_id = response.headers["request-id"]
assert response.status_code == 429
assert response.headers["x-should-retry"] == "false"
error = response.json()["error"]
assert error["type"] == expected_type
assert error["message"] == f"upstream is busy\n\nRequest ID: {request_id}"
trace = _terminal_trace(trace_mock)
assert trace["status_code"] == 429
assert trace["error_type"] == "rate_limit_error"
assert trace["exc_type"] == "ExecutionFailure"
assert trace["failure_kind"] == "rate_limit"
@pytest.mark.parametrize("path", ["/v1/messages", "/v1/responses"])
def test_grouped_post_start_execution_failure_keeps_canonical_terminal_event(
path: str,
) -> None:
provider = _grouped_rate_limit_provider(_partial_anthropic_stream(close_block=True))
payload = (
_messages_payload(stream=True)
if path == "/v1/messages"
else _responses_payload()
)
resolver_patch, client = _client_for(provider)
with (
resolver_patch,
patch("free_claude_code.api.response_streams.trace_event") as trace_mock,
client,
):
response = client.post(path, json=payload)
request_id = response.headers["request-id"]
events = parse_sse_text(response.text)
if path == "/v1/messages":
assert events[-1].event == "error"
error = events[-1].data["error"]
else:
assert events[-1].event == "response.failed"
error = events[-1].data["response"]["error"]
assert response.status_code == 200
assert error["type"] == "rate_limit_error"
assert error["message"] == f"upstream is busy\n\nRequest ID: {request_id}"
assert _terminal_trace(trace_mock)["failure_kind"] == "rate_limit"
def test_grouped_stream_false_execution_failure_discards_partial_content() -> None:
provider = _grouped_rate_limit_provider(
_partial_anthropic_stream(close_block=False)
)
resolver_patch, client = _client_for(provider)
with (
resolver_patch,
patch("free_claude_code.api.response_streams.trace_event") as trace_mock,
client,
):
response = client.post("/v1/messages", json=_messages_payload(stream=False))
request_id = response.headers["request-id"]
assert response.status_code == 429
assert response.headers["x-should-retry"] == "false"
assert response.json()["error"] == {
"type": "rate_limit_error",
"message": f"upstream is busy\n\nRequest ID: {request_id}",
}
assert _PARTIAL_CONTENT not in response.text
trace = _terminal_trace(trace_mock)
assert trace["status_code"] == 429
assert trace["error_type"] == "rate_limit_error"
assert trace["exc_type"] == "ExecutionFailure"
assert trace["failure_kind"] == "rate_limit"
def test_messages_pre_start_execution_failure_is_correlated_terminal_json() -> None:
provider = CanonicalFailureProvider(
[],
kind=FailureKind.RATE_LIMIT,
status_code=429,
message="upstream is busy",
retryable=True,
)
resolver_patch, client = _client_for(provider)
with resolver_patch, client:
response = client.post("/v1/messages", json=_messages_payload(stream=True))
request_id = response.headers["request-id"]
assert response.status_code == 429
assert response.headers["content-type"].startswith("application/json")
assert response.headers["x-should-retry"] == "false"
assert "x-request-id" not in response.headers
assert response.json() == {
"type": "error",
"error": {
"type": "rate_limit_error",
"message": f"upstream is busy\n\nRequest ID: {request_id}",
},
"request_id": request_id,
}
assert provider.stream_kwargs[0]["request_id"] == request_id
@pytest.mark.parametrize(
("path", "payload"),
[
("/v1/messages", _messages_payload(stream=True)),
("/v1/responses", _responses_payload()),
],
)
def test_pre_start_permission_failure_preserves_403_without_client_retry(
path: str,
payload: dict[str, object],
) -> None:
provider = CanonicalFailureProvider(
[],
kind=FailureKind.PERMISSION,
status_code=403,
message="Provider denied access.",
retryable=False,
)
resolver_patch, client = _client_for(provider)
with (
resolver_patch,
patch("free_claude_code.api.response_streams.trace_event") as trace_mock,
client,
):
response = client.post(path, json=payload)
request_id = response.headers["request-id"]
error = response.json()["error"]
assert response.status_code == 403
assert response.headers["x-should-retry"] == "false"
assert error["type"] == "permission_error"
assert error["message"] == f"Provider denied access.\n\nRequest ID: {request_id}"
if path == "/v1/messages":
assert response.json()["request_id"] == request_id
assert "x-request-id" not in response.headers
else:
assert response.headers["x-request-id"] == request_id
trace = _terminal_trace(trace_mock)
assert trace["failure_kind"] == "permission"
assert trace["status_code"] == 403
assert trace["error_type"] == "permission_error"
assert trace["provider_retryable"] is False
def test_messages_context_window_failure_triggers_client_compaction() -> None:
provider = CanonicalFailureProvider(
[],
kind=FailureKind.CONTEXT_WINDOW_EXCEEDED,
status_code=400,
message="Provider input exceeds the model context window.",
retryable=False,
)
resolver_patch, client = _client_for(provider)
with (
resolver_patch,
patch("free_claude_code.api.response_streams.trace_event") as trace_mock,
client,
):
response = client.post("/v1/messages", json=_messages_payload(stream=True))
request_id = response.headers["request-id"]
assert response.status_code == 400
assert response.headers["x-should-retry"] == "false"
assert response.json() == {
"type": "error",
"error": {
"type": "invalid_request_error",
"message": (
"prompt is too long\n\n"
"Provider input exceeds the model context window.\n\n"
f"Request ID: {request_id}"
),
},
"request_id": request_id,
}
trace = _terminal_trace(trace_mock)
assert trace["failure_kind"] == "context_window_exceeded"
assert trace["status_code"] == 400
assert trace["error_type"] == "invalid_request_error"
assert trace["provider_retryable"] is False
def test_responses_pre_start_execution_failure_is_correlated_terminal_json() -> None:
provider = CanonicalFailureProvider(
[],
kind=FailureKind.OVERLOADED,
status_code=529,
message="provider overloaded",
retryable=True,
)
resolver_patch, client = _client_for(provider)
with resolver_patch, client:
response = client.post("/v1/responses", json=_responses_payload())
request_id = response.headers["request-id"]
assert response.status_code == 529
assert response.headers["content-type"].startswith("application/json")
assert response.headers["x-should-retry"] == "false"
assert response.headers["x-request-id"] == request_id
assert response.json() == {
"error": {
"message": f"provider overloaded\n\nRequest ID: {request_id}",
"type": "overloaded_error",
"param": None,
"code": None,
}
}
assert provider.stream_kwargs[0]["request_id"] == request_id
def test_messages_post_start_execution_failure_follows_closed_block() -> None:
provider = CanonicalFailureProvider(
_partial_anthropic_stream(close_block=True),
kind=FailureKind.OVERLOADED,
status_code=529,
message="provider overloaded",
retryable=True,
)
resolver_patch, client = _client_for(provider)
with (
resolver_patch,
patch("free_claude_code.api.response_streams.trace_event") as trace_mock,
client,
):
response = client.post("/v1/messages", json=_messages_payload(stream=True))
request_id = response.headers["request-id"]
events = parse_sse_text(response.text)
assert response.status_code == 200
assert "x-should-retry" not in response.headers
assert [event.event for event in events] == [
"message_start",
"content_block_start",
"content_block_delta",
"content_block_stop",
"error",
]
assert events[-1].data["error"] == {
"type": "overloaded_error",
"message": f"provider overloaded\n\nRequest ID: {request_id}",
}
assert "message_stop" not in response.text
assert _terminal_trace(trace_mock) == {
"stage": "egress",
"event": "free_claude_code.api.response.terminal_execution_error",
"source": "api",
"wire_api": "messages",
"request_id": request_id,
"status_code": 529,
"error_type": "overloaded_error",
"client_should_retry": False,
"exc_type": "ExecutionFailure",
"failure_kind": "overloaded",
"provider_retryable": True,
}
def test_responses_post_start_execution_failure_retains_id_after_block_close() -> None:
provider = CanonicalFailureProvider(
_partial_anthropic_stream(close_block=True),
kind=FailureKind.RATE_LIMIT,
status_code=429,
message="upstream is busy",
retryable=True,
)
resolver_patch, client = _client_for(provider)
with (
resolver_patch,
patch("free_claude_code.api.response_streams.trace_event") as trace_mock,
client,
):
response = client.post("/v1/responses", json=_responses_payload())
request_id = response.headers["request-id"]
events = parse_sse_text(response.text)
event_names = [event.event for event in events]
created = events[0].data["response"]
failed = events[-1].data["response"]
assert response.status_code == 200
assert response.headers["x-request-id"] == request_id
assert "x-should-retry" not in response.headers
assert event_names[0] == "response.created"
assert "response.output_item.done" in event_names
assert event_names.index("response.output_item.done") < event_names.index(
"response.failed"
)
assert event_names[-1] == "response.failed"
assert failed["id"] == created["id"]
assert failed["status"] == "failed"
assert failed["error"] == {
"message": f"upstream is busy\n\nRequest ID: {request_id}",
"type": "rate_limit_error",
"param": None,
"code": None,
}
assert _terminal_trace(trace_mock) == {
"stage": "egress",
"event": "free_claude_code.api.response.terminal_execution_error",
"source": "api",
"wire_api": "responses",
"request_id": request_id,
"status_code": 429,
"error_type": "rate_limit_error",
"client_should_retry": False,
"exc_type": "ExecutionFailure",
"failure_kind": "rate_limit",
"provider_retryable": True,
}
def test_messages_stream_false_discards_partial_content_on_execution_failure() -> None:
provider = CanonicalFailureProvider(
_partial_anthropic_stream(close_block=False),
kind=FailureKind.RATE_LIMIT,
status_code=429,
message="upstream is busy",
retryable=True,
)
resolver_patch, client = _client_for(provider)
with resolver_patch, client:
response = client.post("/v1/messages", json=_messages_payload(stream=False))
request_id = response.headers["request-id"]
assert response.status_code == 429
assert response.headers["content-type"].startswith("application/json")
assert response.headers["x-should-retry"] == "false"
assert response.json()["request_id"] == request_id
assert response.json()["error"] == {
"type": "rate_limit_error",
"message": f"upstream is busy\n\nRequest ID: {request_id}",
}
assert _PARTIAL_CONTENT not in response.text
|