Update src/feedback.py

src/feedback.py

@@ -170,18 +170,21 @@ Each entry contains:
         success = False
         messages = []
         
-        # 保存到本地（作为备份）
-        if self.local_backup:
-            try:
-                with open(self.local_file, 'w', encoding='utf-8') as f:
-                    json.dump(feedback_data, f, ensure_ascii=False, indent=2)
+        # Always write local file first — required for HF upload regardless of local_backup setting.
+        # (Bug fix: previously only written inside `if self.local_backup`, causing empty uploads to HF)
+        local_write_ok = False
+        try:
+            with open(self.local_file, 'w', encoding='utf-8') as f:
+                json.dump(feedback_data, f, ensure_ascii=False, indent=2)
+            local_write_ok = True
+            if self.local_backup:
                 messages.append(f"💾 Local backup saved")
                 success = True
-            except Exception as e:
-                messages.append(f"❌ Local save failed: {e}")
-        
-        # 上传到 HF 数据集
-        if self.api and self.dataset_repo_id:
+        except Exception as e:
+            messages.append(f"❌ Local save failed: {e}")
+
+        # 上传到 HF 数据集（仅当本地写入成功时）
+        if self.api and self.dataset_repo_id and local_write_ok:
             try:
                 # 保存为 JSON 文件
                 upload_file(
@@ -192,12 +195,12 @@ Each entry contains:
                     token=self.hf_token,
                     commit_message=f"Add feedback: {feedback_type} at {feedback_entry['timestamp']}"
                 )
-                
+
                 # 同时创建/更新 CSV 版本（方便查看）
                 df = pd.DataFrame(feedback_data)
                 csv_file = self.local_dir / 'feedback_data.csv'
                 df.to_csv(csv_file, index=False)
-                
+
                 upload_file(
                     path_or_fileobj=str(csv_file),
                     path_in_repo="feedback_data.csv",
@@ -206,14 +209,14 @@ Each entry contains:
                     token=self.hf_token,
                     commit_message=f"Update CSV: {len(feedback_data)} total entries"
                 )
-                
+
                 messages.append(f"☁️ Uploaded to HF dataset: {self.dataset_repo_id}")
                 success = True
-                
+
             except Exception as e:
                 messages.append(f"⚠️ HF upload failed: {e}")
-                # 如果 HF 上传失败但本地保存成功，仍然返回成功
-                success = success or self.local_backup
+                # 如果 HF 上传失败但本地写入成功，仍然返回成功
+                success = success or local_write_ok
         
         return success, " | ".join(messages)