Fix: Properly detect and report pipeline failures

- Check pipeline result status before marking as success/failure
- Set hasError=true when pipeline fails or partially completes
- Show appropriate error messages for failed components
- Update pipeline status to 'failed' instead of 'completed' for errors
- Extract component-level error details for better user feedback

api_routes_v2.py

@@ -1234,10 +1234,22 @@ async def chat_unified(
                     prefer_bedrock=bool(prefer_bedrock),
                 )
                 session_manager.update_session(chat_id, {"pipeline_result": result, "state": "initial"})
+                
+                # Check if pipeline actually succeeded or failed
+                pipeline_status = result.get("status", "unknown")
+                completed_steps = result.get("completed_steps", 0)
+                total_steps = result.get("total_steps", 0)
+                has_error = result.get("error") is not None or pipeline_status in ["failed", "partial"]
+                
+                # Determine if this is a real success or a failure
+                is_success = (pipeline_status == "completed" and completed_steps == total_steps and not has_error)
+                
                 # V3: Update pipeline status in S3
                 pipeline_id = proposed.get("pipeline_id")
                 if pipeline_id:
-                    _update_pipeline_status(pipeline_id, chat_id, "completed", result=result)
+                    # Mark as failed if not successful, otherwise completed
+                    final_status = "completed" if is_success else "failed"
+                    _update_pipeline_status(pipeline_id, chat_id, final_status, result=result)
                     _record_model_attribution(
                         pipeline_id=pipeline_id,
                         session_id=chat_id,
@@ -1246,11 +1258,45 @@ async def chat_unified(
                         is_fallback=False
                     )
                 
-                # Extract user-facing output
-                result_text = _extract_user_facing_text(result)
-                friendly = f"🎉 Pipeline completed successfully!"
-                output = {"component_summary": "Pipeline executed successfully", "steps": len(proposed.get("pipeline_steps", proposed.get("components", [])))}
-                final_output = {"text": result_text}
+                # Build response based on actual success/failure
+                if is_success:
+                    # Extract user-facing output
+                    result_text = _extract_user_facing_text(result)
+                    friendly = f"🎉 Pipeline completed successfully!"
+                    output = {"component_summary": "Pipeline executed successfully", "steps": total_steps}
+                    final_output = {"text": result_text}
+                    api_type = "pipeline_completed"
+                    exception_msg = None
+                else:
+                    # Pipeline failed or partially completed
+                    error_msg = result.get("error", "Pipeline execution incomplete")
+                    
+                    # Check for component-level errors
+                    failed_components = []
+                    for comp in result.get("components_executed", []):
+                        if comp.get("status") == "failed" or comp.get("error"):
+                            failed_components.append({
+                                "tool_name": comp.get("tool_name", comp.get("tool", "unknown")),
+                                "error": comp.get("error", comp.get("result", {}).get("error", "Unknown error"))
+                            })
+                    
+                    if failed_components:
+                        # Show specific component error
+                        first_error = failed_components[0]
+                        friendly = f"❌ Pipeline failed: {first_error['tool_name']} - {first_error['error']}"
+                    else:
+                        friendly = f"⚠️ Pipeline partially completed: {error_msg}"
+                    
+                    output = {
+                        "component_summary": f"Pipeline {pipeline_status}",
+                        "steps": total_steps,
+                        "completed": completed_steps,
+                        "failed": total_steps - completed_steps
+                    }
+                    final_output = {"text": f"Pipeline execution {pipeline_status} with {completed_steps}/{total_steps} steps completed"}
+                    api_type = "pipeline_failed" if pipeline_status == "failed" else "pipeline_partial"
+                    exception_msg = error_msg
+                
                 # Add output_id and download_url from pipeline_manager
                 if pipeline_id:
                     try:
@@ -1264,7 +1310,7 @@ async def chat_unified(
                         print(f"Warning: Could not get output_id/download_url: {e}")
                 
                 api_data = {
-                    "type": "pipeline_completed",
+                    "type": api_type,
                     "result": result,
                     "pipeline": proposed
                 }
@@ -1275,7 +1321,8 @@ async def chat_unified(
                     api_data=api_data,
                     state="initial",
                     output=output,
-                    final_output=final_output
+                    final_output=final_output,
+                    exception=exception_msg  # This will set hasError=True when not None
                 )
             except Exception as e:
                 session_manager.update_session(chat_id, {"state": "initial"})