Made changes in ideation

api/routers/context_analysis.py

@@ -54,4 +54,4 @@ def context_analysis(msg: UserMessage):
 
         yield json.dumps(final_payload) + "\n"
 
-    return StreamingResponse(event_generator(), media_type="event-stream")
+    return StreamingResponse(event_generator(), media_type="text/event-stream")

api/routers/ideation.py

@@ -20,10 +20,10 @@ def ideation_endpoint():
         },
         config=config,
         )
-        stored_data['final_ideation'] = result['improver_response'][-1]
+        stored_data['final_ideation'] = result['formatted_response'][-1]
         stored_data['final_ideation']=ast.literal_eval(stored_data['final_ideation'])
 
-        return {'response':ast.literal_eval(result['improver_response'][-1])}
+        return {'response':ast.literal_eval(result['formatted_response'][-1])}
     except GraphRecursionError:
         result = idea_graph.get_state({"configurable": {"thread_id": "ideation_thread123"}})
         return {'response': result[0]}

logs/access.log

@@ -189,3 +189,20 @@
 2025-08-10 14:33:24,030 | INFO | access_logger | Response status: 200
 2025-08-10 15:14:49,865 | INFO | access_logger | Request: POST http://localhost:8000/api/brainstorm
 2025-08-10 15:14:49,880 | INFO | access_logger | Response status: 200
+2025-08-11 13:42:55,059 | INFO | access_logger | Request: GET http://127.0.0.1:8000/docs
+2025-08-11 13:42:55,076 | INFO | access_logger | Response status: 200
+2025-08-11 13:42:55,453 | INFO | access_logger | Request: GET http://127.0.0.1:8000/openapi.json
+2025-08-11 13:42:55,505 | INFO | access_logger | Response status: 200
+2025-08-11 13:46:16,491 | INFO | access_logger | Request: POST http://127.0.0.1:8000/api/ideation
+2025-08-11 13:47:27,569 | INFO | access_logger | Response status: 200
+2025-08-11 13:53:19,240 | INFO | access_logger | Request: POST http://127.0.0.1:8000/api/context-analysis
+2025-08-11 13:53:19,315 | INFO | access_logger | Response status: 200
+2025-08-11 13:53:39,072 | INFO | access_logger | Request: POST http://127.0.0.1:8000/api/context-analysis
+2025-08-11 13:53:39,074 | INFO | access_logger | Response status: 200
+2025-08-11 14:24:10,065 | INFO | access_logger | Request: POST http://127.0.0.1:8000/api/ideation
+2025-08-11 14:25:02,611 | INFO | access_logger | Response status: 200
+2025-08-11 14:25:29,940 | INFO | access_logger | Request: POST http://127.0.0.1:8000/api/ideation
+2025-08-11 14:26:51,558 | INFO | access_logger | Response status: 200
+2025-08-11 14:37:03,225 | INFO | access_logger | Request: POST http://127.0.0.1:8000/api/ideation
+2025-08-11 14:39:51,118 | INFO | access_logger | Request: POST http://127.0.0.1:8000/api/ideation
+2025-08-11 14:40:35,783 | INFO | access_logger | Response status: 200

src/genai/ideation_agent/agent.py

@@ -1,6 +1,6 @@
 from langgraph.graph import StateGraph, START, END , MessagesState
 from .utils.state import State
-from .utils.nodes import ideator , critic , improver , validator1 , validator2 , validator3 , validator4 , route1_after_validation , route2_after_validation , route3_after_validation , route4_after_validation
+from .utils.nodes import ideator , critic , format_response , validator1 , validator2 , route1_after_validation , route2_after_validation 
 from langgraph.checkpoint.memory import MemorySaver
 memory = MemorySaver()
 
@@ -9,27 +9,22 @@ def ideation_graph():
     graph_builder= StateGraph(State)
     graph_builder.add_node(ideator)
     graph_builder.add_node(critic)
-    graph_builder.add_node(improver)
+    graph_builder.add_node(format_response)
     graph_builder.add_node(validator1)
     graph_builder.add_node(validator2)
-    graph_builder.add_node(validator3)
-    graph_builder.add_node(validator4)
 
 
     graph_builder.add_edge(START, "ideator")  # Start the graph with node_1
     graph_builder.add_edge("ideator", "critic")
-    graph_builder.add_edge("critic", "improver")
-    graph_builder.add_edge("improver", "validator1")
+    graph_builder.add_edge("critic", "format_response")
+    graph_builder.add_edge("format_response", "validator1")
     graph_builder.add_edge("validator1", "validator2")
-    graph_builder.add_edge("validator2", "validator3")
-    graph_builder.add_edge("validator3", "validator4")
-    graph_builder.add_edge("validator4", END)
+    graph_builder.add_edge("validator2", END)
+
 
     # Use conditional routing from validator
-    graph_builder.add_conditional_edges("validator1", route1_after_validation,{False:'improver',True:'validator2'})
-    graph_builder.add_conditional_edges("validator2", route2_after_validation,{False:'improver',True:'validator3'})
-    graph_builder.add_conditional_edges("validator3", route3_after_validation,{False:'improver',True:'validator4'})
-    graph_builder.add_conditional_edges("validator4", route4_after_validation,{False:'improver',True:END})
+    graph_builder.add_conditional_edges("validator1", route1_after_validation,{False:'critic',True:'validator2'})
+    graph_builder.add_conditional_edges("validator2", route2_after_validation,{False:'critic',True:END})
 
     return graph_builder.compile(checkpointer=memory)
 

src/genai/ideation_agent/utils/nodes.py

@@ -1,8 +1,8 @@
-from .state import State , ValidationFormatter , ImproverResponseFormatter
+from .state import State , ValidationFormatter , ImproverResponseFormatter, CriticResponseFormatter
 from .tools import retrieve_tool
 from langgraph.prebuilt import create_react_agent
 from src.genai.utils.models_loader import ideator_llm, critic_llm , improver_llm , validator_llm, llm
-from langchain_core.messages import SystemMessage , HumanMessage, ToolMessage
+from langchain_core.messages import SystemMessage , HumanMessage
 from .prompts import ideator_prompt , critic_prompt , improver_prompt , validator_prompt, idea_refinement_prompt
 
 
@@ -22,11 +22,13 @@ improver_agent = create_react_agent(
     )
 
 
+
 def ideator(state:State):
     template = ideator_prompt(state)
+    # imdb_reference = retrieve_tool(state.business_details[-1])
     messages = [SystemMessage(content=template),
-                    HumanMessage(content=f'''The business_details is:\n{state.business_details[-1]}\n
-                                 The information of the image is:\n{state.image_caption[-1]}''')]
+                HumanMessage(content=f'''The business_details is\n{state.business_details[-1]}\n 
+                            The information of the image is:\n{state.image_caption[-1]}''')]
     try:
         response = ideator_agent.invoke({'messages':messages})
         print('Ideator Response:',response)
@@ -43,8 +45,10 @@ def ideator(state:State):
 
 def critic(state:State):
     template = critic_prompt(state)
+    # imdb_reference= retrieve_tool(state.business_details[-1])
     messages = [SystemMessage(content=template),
-                    HumanMessage(content=f'''The business_details is\n{state.business_details[-1]}\n The information of the image is:\n{state.image_caption[-1]}''')]
+                HumanMessage(content=f'''The business_details is\n{state.business_details[-1]}\n 
+                            The information of the image is:\n{state.image_caption[-1]}''')]
     
     try:
         response = critic_agent.invoke({'messages':messages})
@@ -59,24 +63,39 @@ def critic(state:State):
         print('Critic backup Response:',response.content)
         state.critic_response.append(response.content)
         return state
-
-
-def improver(state:State):
+    
+def format_response(state:State):
     response_list = []
-    template = improver_prompt(state)
-    messages = [SystemMessage(content=template),
-                HumanMessage(content=f'''The business_details is:\n{state.business_details[-1]}\n The information of the image is:\n{state.image_caption[-1]}''')]
-    print('Improver Prompt:',messages)
-    response = improver_llm.with_structured_output(ImproverResponseFormatter).invoke(messages)
+    messages = [SystemMessage(content='''Just extract all the 4 improved ideas and the faults of critic as it is from the critic's response'''), 
+                HumanMessage(content=f'''The critic's response is: \n {state.critic_response[-1]}''')]
+    response = critic_llm.with_structured_output(CriticResponseFormatter).invoke(messages)
     response_list.append(response.improved_idea1)
     response_list.append(response.improved_idea2)
     response_list.append(response.improved_idea3)
     response_list.append(response.improved_idea4)
-
-    state.improver_response.append(str(response_list))
-    state.critic_fault.append(response.faults)
-    print('Improver response:',response_list)
+    state.formatted_response.append(str(response_list))
+    state.ideator_fault.append(response.faults)
+    print('Formatted Response:', response_list)
     return state
+
+
+
+# def improver(state:State):
+#     response_list = []
+#     template = improver_prompt(state)
+#     messages = [SystemMessage(content=template),
+#                 HumanMessage(content=f'''The business_details is:\n{state.business_details[-1]}\n The information of the image is:\n{state.image_caption[-1]}''')]
+#     print('Improver Prompt:',messages)
+#     response = improver_llm.with_structured_output(ImproverResponseFormatter).invoke(messages)
+#     response_list.append(response.improved_idea1)
+#     response_list.append(response.improved_idea2)
+#     response_list.append(response.improved_idea3)
+#     response_list.append(response.improved_idea4)
+
+#     state.improver_response.append(str(response_list))
+#     state.critic_fault.append(response.faults)
+#     print('Improver response:',response_list)
+#     return state
     
 
 
@@ -106,31 +125,31 @@ def validator2(state:State):
         state.disagreement_reason.append(response.reason)
     return state
 
-def validator3(state:State):
-    template = validator_prompt(state)
-    messages = [SystemMessage(content=template),
-                HumanMessage(content=f'''The business_details is:\n{state.business_details[-1]}''')]
-
-    response = critic_llm.with_structured_output(ValidationFormatter).invoke(messages)
-    print(f'Validator 3 response: {response}')
-    state.validator3_response.append(response.result)
-    print('The state check:',state.validator1_response[-1])
-    if 'not validated' in response.result:
-        state.disagreement_reason.append(response.reason)
-    return state
-
-def validator4(state:State):
-    template = validator_prompt(state)
-    messages = [SystemMessage(content=template),
-                HumanMessage(content=f'''The business_details is:\n{state.business_details[-1]}''')]
-
-    response = improver_llm.with_structured_output(ValidationFormatter).invoke(messages)
-    print(f'Validator 4 response: {response}')
-    state.validator4_response.append(response.result)
-    print('The state check:',state.validator1_response[-1])
-    if 'not validated' in response.result:
-        state.disagreement_reason.append(response.reason)
-    return state
+# def validator3(state:State):
+#     template = validator_prompt(state)
+#     messages = [SystemMessage(content=template),
+#                 HumanMessage(content=f'''The business_details is:\n{state.business_details[-1]}''')]
+
+#     response = critic_llm.with_structured_output(ValidationFormatter).invoke(messages)
+#     print(f'Validator 3 response: {response}')
+#     state.validator3_response.append(response.result)
+#     print('The state check:',state.validator1_response[-1])
+#     if 'not validated' in response.result:
+#         state.disagreement_reason.append(response.reason)
+#     return state
+
+# def validator4(state:State):
+#     template = validator_prompt(state)
+#     messages = [SystemMessage(content=template),
+#                 HumanMessage(content=f'''The business_details is:\n{state.business_details[-1]}''')]
+
+#     response = improver_llm.with_structured_output(ValidationFormatter).invoke(messages)
+#     print(f'Validator 4 response: {response}')
+#     state.validator4_response.append(response.result)
+#     print('The state check:',state.validator1_response[-1])
+#     if 'not validated' in response.result:
+#         state.disagreement_reason.append(response.reason)
+#     return state
 
 def route1_after_validation(state:State):
     if 'not validated' in state.validator1_response[-1]:
@@ -146,15 +165,15 @@ def route2_after_validation(state:State):
         return True
 
 
-def route3_after_validation(state:State):
-    if 'not validated' in state.validator3_response[-1]:
-        return False
-    else:
-        return True
+# def route3_after_validation(state:State):
+#     if 'not validated' in state.validator3_response[-1]:
+#         return False
+#     else:
+#         return True
 
 
-def route4_after_validation(state:State):
-    if 'not validated' in state.validator4_response[-1]:
-        return False
-    else:
-        return True
+# def route4_after_validation(state:State):
+#     if 'not validated' in state.validator4_response[-1]:
+#         return False
+#     else:
+#         return True

src/genai/ideation_agent/utils/prompts.py

@@ -226,7 +226,7 @@ Each idea creatively tells a short story that connects indirectly to the busines
 {state.business_details[-1]}
 
 **Final 4 Ideas from Improver**:  
-{state.improver_response[-1]}
+{state.formatted_response[-1]}
 
 ---
 

src/genai/ideation_agent/utils/state.py

@@ -7,8 +7,8 @@ class State(BaseModel):
   business_details : Annotated[list[dict],operator.add] = []
   ideator_response: Annotated[list[str],operator.add] = []
   critic_response: Annotated[list[str],operator.add] = []
-  critic_fault: Annotated[list[str],operator.add] = []
-  improver_response: Annotated[list[str],operator.add] = []
+  ideator_fault: Annotated[list[str],operator.add] = []
+  formatted_response: Annotated[list[str],operator.add] = []
   validator1_response: Annotated[list[str],operator.add] = []
   validator2_response: Annotated[list[str],operator.add] = []
   validator3_response: Annotated[list[str],operator.add] = []
@@ -30,4 +30,11 @@ class ValidationFormatter(BaseModel):
   result: str = Field(description="Returns **validated** if the idea is validated. Returns **not validated** if story is not validated.")
   reason: str = Field(description="If the idea is **not validated**, it returns the reason why it is not validated.")
 
+class CriticResponseFormatter(BaseModel):
+   faults: str= Field(description="Returns the faults in the critic's response if any.")
+   improved_idea1: str = Field(description="Returns the first improved idea of exactly 40 words. ")
+   improved_idea2: str = Field(description="Returns the second improved idea of exactly 40 words. ")
+   improved_idea3: str = Field(description="Returns the third improved idea of exactly 40 words. ")
+   improved_idea4: str = Field(description="Returns the fourth improved idea of exactly 40 words. ")
+
 

src/genai/ideation_agent/utils/tools.py

@@ -55,7 +55,7 @@ def retrieve_tool_old(business_details):
     return encoding.decode(trimmed_response)
 
 
-@tool("imdb_movies_ideas_retrieval_tool", args_schema=QueryFormatter, return_direct=False,description="Retrieve imdb movies-related idea for a given query.")
+# @tool("imdb_movies_ideas_retrieval_tool", args_schema=QueryFormatter, return_direct=False,description="Retrieve imdb movies-related idea for a given query.")
 def retrieve_tool(business_details):
     '''
     Always invoke this tool.
@@ -64,7 +64,7 @@ def retrieve_tool(business_details):
     query_embedding = np.array(embedding_model.embed_query(str(business_details))).reshape(1, -1).astype('float32')
     faiss.normalize_L2(query_embedding)
 
-    top_k = 5
+    top_k = 10
     distances, indices = ideas_index.search(query_embedding, top_k)
 
     outer_list = []
@@ -81,4 +81,13 @@ def retrieve_tool(business_details):
         outer_list.append(inner_list)
 
     cleaned_response = clean_text(str(outer_list))
-    return str(cleaned_response)
+    return str(cleaned_response)
+
+# business_details= {
+#     "business_type": "restaurant",
+#     "platform": "instagram",
+#     "target_audience": "youths",
+#     "business_goals": "to increase sales",
+#     "offerings": "nepali local foods",
+#     "Challenges_faced": "competition with other restaurants"
+#   },