msid api bug fix

DataEmbeddings.bin

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:635f548709847a5fe1b3f49a1890f315c771880bacb1f1472e090cf20c984344
-size 986618
+oid sha256:54e444e5881756030f44025dd516011affa16cd20449642677778a144f06a468
+size 988422

app.py

@@ -203,15 +203,38 @@ async def get_recommendations_by_id_api(msid: str, k: int = 5):
     Get recommendations based on a given MSID.
     """
     try:
+        # Validate input parameters
+        if not msid or not isinstance(msid, str):
+            raise HTTPException(status_code=400, detail="Invalid MSID provided")
+            
+        if not isinstance(k, int) or k < 1 or k > 10:
+            raise HTTPException(status_code=400, detail="k must be an integer between 1 and 10")
+
+        # Check if recommender service is available
         if not hasattr(fastapi_app.state, "recommender") or fastapi_app.state.recommender is None:
             logger.error("Recommender is not available.")
             raise HTTPException(status_code=503, detail="Recommender service not available")
 
-        response = fastapi_app.state.recommender.get_recommendations_by_id(msid, k)
-        return response
+        # Get recommendations with error handling
+        try:
+            response = fastapi_app.state.recommender.get_recommendations_by_id(msid, k)
+            if not response:
+                raise HTTPException(status_code=404, detail=f"No recommendations found for MSID: {msid}")
+            return response
+            
+        except ValueError as ve:
+            logger.error(f"Value error in get_recommendations_by_id for msid '{msid}': {ve}")
+            raise HTTPException(status_code=400, detail=str(ve))
+            
+        except Exception as e:
+            logger.error(f"Error getting recommendations for msid '{msid}': {e}", exc_info=True)
+            raise HTTPException(status_code=500, detail="Internal server error while getting recommendations")
+            
+    except HTTPException as he:
+        raise he
     except Exception as e:
-        logger.error(f"API Error in get_recommendations_by_id_api for msid '{msid}': {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=f"An error occurred: {str(e)}")
+        logger.error(f"Unexpected error in get_recommendations_by_id_api for msid '{msid}': {e}", exc_info=True)
+        raise HTTPException(status_code=500, detail="An unexpected error occurred")
 
 @fastapi_app.post("/recommendations/feedback/user/", response_model=FeedbackResponse)
 async def submit_user_feedback_api(payload: FeedbackPayload):