Update app.py

app.py

@@ -14,6 +14,9 @@ vectorstore    = None
 qa_chain       = None
 retrieved_docs = {}
 
+# ── Groq key from HF Secret ───────────────────────────────────
+GROQ_API_KEY = os.environ.get("GROQ_API_KEY", "")
+
 # ── Embedding model (loaded once) ─────────────────────────────
 embeddings = HuggingFaceEmbeddings(
     model_name="sentence-transformers/all-MiniLM-L6-v2",
@@ -28,9 +31,9 @@ def format_docs(docs):
         for doc in docs
     )
 
-def build_chain(groq_api_key: str):
+def build_chain():
     llm = ChatGroq(
-        api_key=groq_api_key,
+        api_key=GROQ_API_KEY,
         model="llama-3.3-70b-versatile",
         temperature=0.2,
         max_tokens=1024,
@@ -63,22 +66,21 @@ Answer:""",
             "question": question
         }
 
-    chain = (
+    return (
         RunnableLambda(retrieve_and_format)
         | PROMPT
         | llm
         | StrOutputParser()
     )
-    return chain
 
 # ── Core functions ────────────────────────────────────────────
-def process_pdf(pdf_file, groq_api_key, progress=gr.Progress()):
+def process_pdf(pdf_file, progress=gr.Progress()):
     global vectorstore, qa_chain
 
     if pdf_file is None:
         return "⚠️ Please upload a PDF file."
-    if not groq_api_key.strip():
-        return "⚠️ Please enter your Groq API key."
+    if not GROQ_API_KEY:
+        return "❌ GROQ_API_KEY secret is not set in HF Space settings."
 
     try:
         progress(0.1, desc="Loading PDF...")
@@ -97,7 +99,7 @@ def process_pdf(pdf_file, groq_api_key, progress=gr.Progress()):
         vectorstore = FAISS.from_documents(chunks, embeddings)
 
         progress(0.9, desc="Setting up RAG chain...")
-        qa_chain = build_chain(groq_api_key.strip())
+        qa_chain = build_chain()
 
         progress(1.0, desc="Done!")
         return f"✅ Ready! Loaded **{len(pages)} pages** → **{len(chunks)} chunks**."
@@ -108,7 +110,8 @@ def process_pdf(pdf_file, groq_api_key, progress=gr.Progress()):
 
 def answer_question(question, history):
     if vectorstore is None or qa_chain is None:
-        history.append((question, "⚠️ Please upload a PDF and enter your Groq API key first."))
+        history.append({"role": "user",      "content": question})
+        history.append({"role": "assistant", "content": "⚠️ Please upload a PDF first."})
         return "", history
     if not question.strip():
         return "", history
@@ -125,9 +128,10 @@ def answer_question(question, history):
             answer += f"\n\n📄 *Sources: pages {pages}*"
 
     except Exception as e:
-        answer = f"❌ Error generating answer: {str(e)}"
+        answer = f"❌ Error: {str(e)}"
 
-    history.append((question, answer))
+    history.append({"role": "user",      "content": question})
+    history.append({"role": "assistant", "content": answer})
     return "", history
 
 
@@ -138,33 +142,25 @@ def clear_all():
     retrieved_docs = {}
     return [], "", "🗑️ Cleared. Upload a new PDF to start again."
 
-# ── Gradio UI (Gradio 6 compatible) ──────────────────────────
-with gr.Blocks(title="PDF RAG Chatbot") as demo:          # ← theme removed from here
 
-    gr.Markdown("""
-    # 📚 PDF RAG Chatbot
-    Upload a PDF, enter your Groq API key, then ask questions about the document.
-    """)
+# ── Gradio UI ─────────────────────────────────────────────────
+with gr.Blocks(title="PDF RAG Chatbot") as demo:
+
+    gr.Markdown("# 📚 PDF RAG Chatbot\nUpload a PDF and ask questions about it.")
 
     with gr.Row():
+
+        # ── Left panel ────────────────────────────────────────
         with gr.Column(scale=1):
-            gr.Markdown("### ⚙️ Setup")
-            groq_key_box = gr.Textbox(
-                label="Groq API Key",
-                placeholder="gsk_...",
-                type="password",
-                value=os.environ.get("GROQ_API_KEY", "")
-            )
-            pdf_upload = gr.File(
-                label="Upload PDF",
-                file_types=[".pdf"]
-            )
+            gr.Markdown("### 📄 Upload Document")
+            pdf_upload  = gr.File(label="Choose PDF", file_types=[".pdf"])
             process_btn = gr.Button("📥 Process PDF", variant="primary")
             status_box  = gr.Markdown("*Upload a PDF to begin.*")
 
+        # ── Right panel ───────────────────────────────────────
         with gr.Column(scale=2):
             gr.Markdown("### 💬 Chat")
-            chatbot = gr.Chatbot(height=480)               # ← bubble_full_width removed
+            chatbot = gr.Chatbot(height=500, type="messages")
             with gr.Row():
                 question_box = gr.Textbox(
                     placeholder="Ask a question about your PDF...",
@@ -174,10 +170,10 @@ with gr.Blocks(title="PDF RAG Chatbot") as demo:          # ← theme removed fr
                 submit_btn = gr.Button("Send", variant="primary", scale=1)
             clear_btn = gr.Button("🗑️ Clear Chat & Reset")
 
-    # ── Event handlers ─────────────────────────────────────────
+    # ── Event handlers ────────────────────────────────────────
     process_btn.click(
         process_pdf,
-        inputs=[pdf_upload, groq_key_box],
+        inputs=[pdf_upload],
         outputs=[status_box]
     )
     submit_btn.click(
@@ -195,4 +191,4 @@ with gr.Blocks(title="PDF RAG Chatbot") as demo:          # ← theme removed fr
         outputs=[chatbot, question_box, status_box]
     )
 
-demo.launch(theme=gr.themes.Soft())                        # ← theme moved here
+demo.launch(theme=gr.themes.Soft())