File size: 10,036 Bytes
383cb38 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 | """
Comprehensive Error Handling Middleware
Provides detailed error responses and logging for production use
"""
from datetime import datetime
import json
import logging
import traceback
from typing import Any, Dict, Optional
import uuid
from fastapi import HTTPException, Request, Response
from fastapi.responses import JSONResponse
from starlette.middleware.base import BaseHTTPMiddleware
# Configure error logging
error_logger = logging.getLogger("atom.errors")
performance_logger = logging.getLogger("atom.performance")
class ErrorHandlingMiddleware(BaseHTTPMiddleware):
"""Comprehensive error handling middleware"""
def __init__(self, app, debug: bool = False):
super().__init__(app)
self.debug = debug
self.setup_logging()
def setup_logging(self):
"""Setup error logging configuration"""
# Create file handler for errors
error_handler = logging.FileHandler("logs/errors.log")
error_handler.setLevel(logging.ERROR)
error_formatter = logging.Formatter(
'%(asctime)s - %(name)s - %(levelname)s - %(message)s'
)
error_handler.setFormatter(error_formatter)
error_logger.addHandler(error_handler)
# Create performance handler
perf_handler = logging.FileHandler("logs/performance.log")
perf_handler.setLevel(logging.INFO)
perf_handler.setFormatter(error_formatter)
performance_logger.addHandler(perf_handler)
async def dispatch(self, request: Request, call_next):
"""Process request and handle any errors"""
# Generate request ID for tracking
request_id = str(uuid.uuid4())
start_time = datetime.now()
# Add request ID to request state
request.state.request_id = request_id
try:
# Process the request
response = await call_next(request)
# Log performance metrics
duration = (datetime.now() - start_time).total_seconds()
self.log_performance(request, response, duration, request_id)
# Add request ID to response headers
response.headers["X-Request-ID"] = request_id
return response
except HTTPException as e:
# Handle HTTP exceptions (client errors)
return await self.handle_http_exception(e, request, request_id, start_time)
except Exception as e:
# Handle unexpected errors (server errors)
return await self.handle_server_error(e, request, request_id, start_time)
async def handle_http_exception(
self,
exception: HTTPException,
request: Request,
request_id: str,
start_time: datetime
) -> JSONResponse:
"""Handle HTTP exceptions (4xx errors)"""
error_response = {
"error": {
"type": "http_error",
"code": exception.status_code,
"message": exception.detail,
"request_id": request_id,
"timestamp": datetime.now().isoformat(),
"path": str(request.url.path),
"method": request.method
}
}
# Add debug information in development
if self.debug:
error_response["debug"] = {
"headers": dict(request.headers),
"query_params": dict(request.query_params)
}
# Log the error
error_logger.warning(
f"HTTP {exception.status_code} - {request.method} {request.url.path} - "
f"{exception.detail} - Request ID: {request_id}"
)
return JSONResponse(
status_code=exception.status_code,
content=error_response
)
async def handle_server_error(
self,
exception: Exception,
request: Request,
request_id: str,
start_time: datetime
) -> JSONResponse:
"""Handle server errors (5xx errors)"""
# Get full traceback
error_traceback = traceback.format_exc()
# Log the full error
error_logger.error(
f"Server Error - {request.method} {request.url.path} - "
f"{str(exception)} - Request ID: {request_id}\n"
f"Traceback:\n{error_traceback}"
)
# Create user-friendly error response
error_response = {
"error": {
"type": "server_error",
"code": 500,
"message": "Internal server error occurred",
"request_id": request_id,
"timestamp": datetime.now().isoformat(),
"path": str(request.url.path),
"method": request.method
}
}
# Add debug information in development
if self.debug:
error_response["debug"] = {
"exception": str(exception),
"traceback": error_traceback.split('\n'),
"headers": dict(request.headers)
}
return JSONResponse(
status_code=500,
content=error_response
)
def log_performance(
self,
request: Request,
response: Response,
duration: float,
request_id: str
):
"""Log performance metrics"""
# Log slow requests (> 2 seconds)
if duration > 2.0:
performance_logger.warning(
f"Slow Request - {request.method} {request.url.path} - "
f"{duration:.3f}s - Status: {response.status_code} - "
f"Request ID: {request_id}"
)
else:
performance_logger.info(
f"Request - {request.method} {request.url.path} - "
f"{duration:.3f}s - Status: {response.status_code} - "
f"Request ID: {request_id}"
)
class ValidationErrorMiddleware(BaseHTTPMiddleware):
"""Middleware for handling Pydantic validation errors"""
async def dispatch(self, request: Request, call_next):
try:
return await call_next(request)
except Exception as e:
# Check if it's a validation error
if "validation" in str(e).lower() or "pydantic" in str(e).lower():
return self.handle_validation_error(e, request)
else:
# Let other middleware handle it
raise
def handle_validation_error(self, exception: Exception, request: Request) -> JSONResponse:
"""Handle validation errors with detailed feedback"""
# Try to extract validation details
validation_errors = []
try:
# Parse validation error from exception message
error_str = str(exception)
# Common patterns for validation errors
if "field required" in error_str.lower():
validation_errors.append({
"field": "unknown",
"message": "Required field is missing",
"type": "missing"
})
# Add more validation error parsing as needed
# This is a simplified version for the MVP
except Exception as e:
logger.warning(f"Failed to parse validation error detail: {e}")
error_response = {
"error": {
"type": "validation_error",
"code": 422,
"message": "Invalid request data",
"timestamp": datetime.now().isoformat(),
"path": str(request.url.path),
"method": request.method,
"validation_errors": validation_errors
}
}
return JSONResponse(
status_code=422,
content=error_response
)
class CircuitBreakerMiddleware(BaseHTTPMiddleware):
"""Simple circuit breaker for critical endpoints"""
def __init__(self, app, failure_threshold: int = 5, timeout: int = 60):
super().__init__(app)
self.failure_threshold = failure_threshold
self.timeout = timeout
self.failure_count = {}
self.last_failure_time = {}
async def dispatch(self, request: Request, call_next):
endpoint = f"{request.method}_{request.url.path}"
# Check if circuit is open
if self.is_circuit_open(endpoint):
return JSONResponse(
status_code=503,
content={
"error": {
"type": "service_unavailable",
"message": "Service temporarily unavailable. Please try again later.",
"retry_after": self.timeout
}
}
)
try:
response = await call_next(request)
# Reset failure count on success
if endpoint in self.failure_count:
del self.failure_count[endpoint]
if endpoint in self.last_failure_time:
del self.last_failure_time[endpoint]
return response
except Exception as e:
# Increment failure count
self.failure_count[endpoint] = self.failure_count.get(endpoint, 0) + 1
self.last_failure_time[endpoint] = datetime.now()
# Log circuit breaker activation
if self.failure_count[endpoint] >= self.failure_threshold:
error_logger.critical(
f"Circuit breaker opened for endpoint: {endpoint} - "
f"Failure count: {self.failure_count[endpoint]}"
)
raise
def setup_error_middleware(app, debug: bool = False):
"""Setup all error handling middleware"""
# Add error handling middleware (last to first)
app.add_middleware(ValidationErrorMiddleware)
app.add_middleware(CircuitBreakerMiddleware)
app.add_middleware(ErrorHandlingMiddleware, debug=debug)
# Create logs directory if it doesn't exist
import os
os.makedirs("logs", exist_ok=True) |