Spaces:
Sleeping
Sleeping
File size: 13,774 Bytes
cc036ff | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 | """
Auth 2FA Routes API Tests
Tests for two-factor authentication endpoints including:
- Getting 2FA status
- Setting up 2FA
- Enabling 2FA
- Disabling 2FA
"""
import pytest
from fastapi.testclient import TestClient
from unittest.mock import Mock, patch, AsyncMock
from sqlalchemy.orm import Session
from main_api_app import app
from core.auth import get_current_user
from core.models import User
class TestAuth2FARoutes:
"""Test 2FA authentication API endpoints."""
@pytest.fixture
def mock_user(self):
"""Create mock user."""
user = Mock(spec=User)
user.id = "user-123"
user.email = "user@example.com"
user.two_factor_enabled = False
user.two_factor_secret = None
user.two_factor_backup_codes = None
return user
@pytest.fixture
def client(self, mock_user):
"""Create test client with auth override."""
app.dependency_overrides[get_current_user] = lambda: mock_user
try:
yield TestClient(app)
finally:
app.dependency_overrides.clear()
def test_get_2fa_status_disabled(self, client, mock_user):
"""Test getting 2FA status when disabled."""
mock_user.two_factor_enabled = False
response = client.get("/api/auth/2fa/status")
assert response.status_code == 200
data = response.json()
assert "enabled" in data
assert data["enabled"] is False
def test_get_2fa_status_enabled(self, client, mock_user):
"""Test getting 2FA status when enabled."""
mock_user.two_factor_enabled = True
response = client.get("/api/auth/2fa/status")
assert response.status_code == 200
data = response.json()
assert "enabled" in data
assert data["enabled"] is True
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_setup_2fa_success(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test successful 2FA setup."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_pyotp.random_base32.return_value = "test-secret-123"
mock_totp = Mock()
mock_totp.provisioning_uri.return_value = "otpauth://totp/test"
mock_pyotp.totp.TOTP.return_value = mock_totp
response = client.post("/api/auth/2fa/setup")
assert response.status_code == 200
data = response.json()
assert "secret" in data
assert "otpauth_url" in data
assert data["secret"] == "test-secret-123"
def test_setup_2fa_already_enabled(self, client, mock_user):
"""Test setup when 2FA is already enabled."""
mock_user.two_factor_enabled = True
response = client.post("/api/auth/2fa/setup")
assert response.status_code == 409 # Conflict
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_enable_2fa_success(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test successfully enabling 2FA."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_user.two_factor_enabled = False
mock_user.two_factor_secret = "existing-secret"
mock_totp = Mock()
mock_totp.verify.return_value = True
mock_pyotp.TOTP.return_value = mock_totp
mock_audit.log_event = Mock()
response = client.post(
"/api/auth/2fa/enable",
json={"code": "123456"}
)
assert response.status_code == 200
data = response.json()
assert "backup_codes" in data or "success" in data
assert mock_user.two_factor_enabled is True
def test_enable_2fa_already_enabled(self, client, mock_user):
"""Test enable when 2FA is already enabled."""
mock_user.two_factor_enabled = True
response = client.post(
"/api/auth/2fa/enable",
json={"code": "123456"}
)
assert response.status_code == 409 # Conflict
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.get_db')
def test_enable_2fa_no_setup(self, mock_get_db, mock_pyotp, client, mock_user):
"""Test enable without prior setup."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_user.two_factor_enabled = False
mock_user.two_factor_secret = None
response = client.post(
"/api/auth/2fa/enable",
json={"code": "123456"}
)
assert response.status_code in [400, 422] # Validation error
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_enable_2fa_invalid_code(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test enable with invalid verification code."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_user.two_factor_enabled = False
mock_user.two_factor_secret = "test-secret"
mock_totp = Mock()
mock_totp.verify.return_value = False
mock_pyotp.TOTP.return_value = mock_totp
response = client.post(
"/api/auth/2fa/enable",
json={"code": "000000"}
)
assert response.status_code in [400, 422] # Validation error
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_disable_2fa_success(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test successfully disabling 2FA."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_user.two_factor_enabled = True
mock_user.two_factor_secret = "test-secret"
mock_totp = Mock()
mock_totp.verify.return_value = True
mock_pyotp.TOTP.return_value = mock_totp
mock_audit.log_event = Mock()
response = client.post(
"/api/auth/2fa/disable",
json={"code": "123456"}
)
assert response.status_code == 200
assert mock_user.two_factor_enabled is False
assert mock_user.two_factor_secret is None
def test_disable_2fa_not_enabled(self, client, mock_user):
"""Test disable when 2FA is not enabled."""
mock_user.two_factor_enabled = False
response = client.post(
"/api/auth/2fa/disable",
json={"code": "123456"}
)
assert response.status_code in [400, 422] # Validation error
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_disable_2fa_invalid_code(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test disable with invalid verification code."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_user.two_factor_enabled = True
mock_user.two_factor_secret = "test-secret"
mock_totp = Mock()
mock_totp.verify.return_value = False
mock_pyotp.TOTP.return_value = mock_totp
response = client.post(
"/api/auth/2fa/disable",
json={"code": "000000"}
)
assert response.status_code in [400, 422] # Validation error
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_2fa_endpoints_require_auth(self, mock_get_db, mock_audit, mock_pyotp):
"""Test that 2FA endpoints require authentication."""
# Create client without auth override
client = TestClient(app)
# Test status endpoint
response = client.get("/api/auth/2fa/status")
assert response.status_code == 401
# Test setup endpoint
response = client.post("/api/auth/2fa/setup")
assert response.status_code == 401
# Test enable endpoint
response = client.post("/api/auth/2fa/enable", json={"code": "123456"})
assert response.status_code == 401
# Test disable endpoint
response = client.post("/api/auth/2fa/disable", json={"code": "123456"})
assert response.status_code == 401
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_2fa_workflow_full_cycle(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test full 2FA enable/disable cycle."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_pyotp.random_base32.return_value = "secret-123"
mock_totp = Mock()
mock_totp.provisioning_uri.return_value = "otpauth://test"
mock_totp.verify.return_value = True
mock_pyotp.totp.TOTP.return_value = mock_totp
mock_audit.log_event = Mock()
# Setup 2FA
response = client.post("/api/auth/2fa/setup")
assert response.status_code == 200
assert mock_user.two_factor_secret == "secret-123"
# Enable 2FA
response = client.post(
"/api/auth/2fa/enable",
json={"code": "123456"}
)
assert response.status_code == 200
assert mock_user.two_factor_enabled is True
# Disable 2FA
response = client.post(
"/api/auth/2fa/disable",
json={"code": "123456"}
)
assert response.status_code == 200
assert mock_user.two_factor_enabled is False
assert mock_user.two_factor_secret is None
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_enable_creates_backup_codes(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test that enabling 2FA creates backup codes."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_user.two_factor_enabled = False
mock_user.two_factor_secret = "secret"
mock_totp = Mock()
mock_totp.verify.return_value = True
mock_pyotp.TOTP.return_value = mock_totp
mock_audit.log_event = Mock()
response = client.post(
"/api/auth/2fa/enable",
json={"code": "123456"}
)
assert response.status_code == 200
assert mock_user.two_factor_backup_codes is not None
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_enable_logs_audit_event(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test that enabling 2FA logs audit event."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_user.two_factor_enabled = False
mock_user.two_factor_secret = "secret"
mock_totp = Mock()
mock_totp.verify.return_value = True
mock_pyotp.TOTP.return_value = mock_totp
mock_audit.log_event = Mock()
response = client.post(
"/api/auth/2fa/enable",
json={"code": "123456"}
)
assert response.status_code == 200
mock_audit.log_event.assert_called_once()
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_disable_logs_audit_event(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test that disabling 2FA logs audit event."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
mock_user.two_factor_enabled = True
mock_user.two_factor_secret = "secret"
mock_totp = Mock()
mock_totp.verify.return_value = True
mock_pyotp.TOTP.return_value = mock_totp
mock_audit.log_event = Mock()
response = client.post(
"/api/auth/2fa/disable",
json={"code": "123456"}
)
assert response.status_code == 200
mock_audit.log_event.assert_called_once()
@patch('api.auth_2fa_routes.pyotp')
@patch('api.auth_2fa_routes.audit_service')
@patch('api.auth_2fa_routes.get_db')
def test_2fa_endpoints_return_json(self, mock_get_db, mock_audit, mock_pyotp, client, mock_user):
"""Test that 2FA endpoints return JSON."""
mock_db = Mock(spec=Session)
mock_get_db.return_value = mock_db
# Test status endpoint
response = client.get("/api/auth/2fa/status")
assert response.headers["content-type"].startswith("application/json")
# Setup mocks for POST endpoints
mock_pyotp.random_base32.return_value = "secret"
mock_totp = Mock()
mock_totp.provisioning_uri.return_value = "otpauth://test"
mock_totp.verify.return_value = True
mock_pyotp.totp.TOTP.return_value = mock_totp
# Test setup endpoint
response = client.post("/api/auth/2fa/setup")
assert response.headers["content-type"].startswith("application/json")
# Test enable endpoint
mock_user.two_factor_enabled = False
mock_user.two_factor_secret = "secret"
response = client.post("/api/auth/2fa/enable", json={"code": "123456"})
assert response.headers["content-type"].startswith("application/json")
# Test disable endpoint
mock_user.two_factor_enabled = True
response = client.post("/api/auth/2fa/disable", json={"code": "123456"})
assert response.headers["content-type"].startswith("application/json")
|