File size: 15,822 Bytes
aef804e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 | """
Canvas HTML security integration tests (INTG-14).
Tests cover:
- HTML sanitization
- XSS prevention
"""
import pytest
from fastapi.testclient import TestClient
from sqlalchemy.orm import Session
from tests.factories.canvas_factory import CanvasAuditFactory
from tests.factories.agent_factory import AutonomousAgentFactory
from core.models import CanvasAudit
import uuid
XSS_PAYLOADS = [
"<script>alert('XSS')</script>",
"<img src=x onerror=alert('XSS')>",
"<svg onload=alert('XSS')>",
"<iframe src='javascript:alert(XSS)'>",
"<body onload=alert('XSS')>",
"<input onfocus=alert('XSS') autofocus>",
"<select onfocus=alert('XSS') autofocus>",
"<textarea onfocus=alert('XSS') autofocus>",
'<marquee onstart=alert("XSS")>',
'<isindex formaction="javascript:alert(XSS)" type="submit">',
'javascript:alert("XSS")',
'<a href="javascript:alert(\'XSS\')">click</a>',
]
SAFE_HTML_PATTERNS = [
"<div class='container'>Content</div>",
"<p>Paragraph with <strong>bold</strong> text</p>",
"<h1>Heading</h1>",
"<ul><li>List item</li></ul>",
"<span class='label'>Label</span>",
"<a href='https://example.com'>Link</a>",
]
class TestHTMLSanitization:
"""Test HTML sanitization."""
def test_script_tag_removed(self, client: TestClient, auth_token: str, db_session: Session):
"""Test script tags are removed from HTML."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
xss_payload = "<script>alert('XSS')</script>"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_payload
},
headers={"Authorization": f"Bearer {auth_token}"}
)
# Should either block or sanitize
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
# Script tag should be removed or escaped
assert "<script>" not in html or "<script>" in html
def test_event_handlers_removed(self, client: TestClient, auth_token: str, db_session: Session):
"""Test event handlers are removed from HTML."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
xss_payload = "<img src=x onerror=alert('XSS')>"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_payload
},
headers={"Authorization": f"Bearer {auth_token}"}
)
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
# Event handler should be removed
assert "onerror" not in html.lower()
def test_iframe_removed(self, client: TestClient, auth_token: str, db_session: Session):
"""Test iframes are removed or restricted."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
xss_payload = "<iframe src='javascript:alert(XSS)'>"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_payload
},
headers={"Authorization": f"Bearer {auth_token}"}
)
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
# Iframe should be removed or src sanitized
assert "javascript:" not in html.lower()
@pytest.mark.parametrize("safe_html", SAFE_HTML_PATTERNS)
def test_safe_html_preserved(self, client: TestClient, auth_token: str, safe_html, db_session: Session):
"""Test safe HTML is preserved."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": safe_html
},
headers={"Authorization": f"Bearer {auth_token}"}
)
# Safe HTML should be allowed
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
# Safe content should be preserved
assert len(html) > 0
class TestXSSPrevention:
"""Test XSS attack prevention."""
@pytest.mark.parametrize("xss_payload", XSS_PAYLOADS)
def test_xss_payloads_blocked(self, client: TestClient, auth_token: str, xss_payload, db_session: Session):
"""Test various XSS payloads are blocked."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_payload
},
headers={"Authorization": f"Bearer {auth_token}"}
)
# Should block or sanitize XSS payloads
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
# Check dangerous patterns are removed/escaped
assert "javascript:" not in html.lower()
assert "<script>" not in html or "<" in html
def test_reflected_xss_prevented(self, client: TestClient, auth_token: str, db_session: Session):
"""Test reflected XSS is prevented."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
xss_input = "<img src=x onerror=alert('XSS')>"
# Simulate reflected XSS (user input reflected in response)
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_input,
"name": xss_input # Reflected in name field
},
headers={"Authorization": f"Bearer {auth_token}"}
)
if response.status_code in [200, 201]:
data = response.json()
# Check reflected input is escaped
name = data.get("name", "")
assert "<img" not in name or "<" in name
def test_stored_xss_prevented(self, client: TestClient, auth_token: str, db_session: Session):
"""Test stored XSS is prevented."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
xss_payload = "<script>alert('Stored XSS')</script>"
# Store malicious HTML
create_response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_payload
},
headers={"Authorization": f"Bearer {auth_token}"}
)
# Retrieve and check if XSS is sanitized
retrieve_response = client.get(
f"/api/canvas/{canvas_id}/components",
headers={"Authorization": f"Bearer {auth_token}"}
)
if retrieve_response.status_code == 200:
data = retrieve_response.json()
# Check stored XSS is sanitized
if isinstance(data, list) and len(data) > 0:
html = data[0].get("html", "")
assert "<script>" not in html or "<" in html
def test_dom_based_xss_prevented(self, client: TestClient, auth_token: str, db_session: Session):
"""Test DOM-based XSS is prevented."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
xss_payload = "<a href='javascript:alert(\"DOM XSS\")'>Click</a>"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_payload
},
headers={"Authorization": f"Bearer {auth_token}"}
)
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
# JavaScript: protocol should be removed
assert "javascript:" not in html.lower()
class TestHTMLContentSecurityPolicy:
"""Test HTML CSP restrictions."""
def test_csp_headers_set(self, client: TestClient, auth_token: str, db_session: Session):
"""Test CSP headers are set for canvas HTML."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
response = client.get(
f"/api/canvas/{canvas_id}",
headers={"Authorization": f"Bearer {auth_token}"}
)
# Check CSP headers
if response.status_code == 200:
csp = response.headers.get("Content-Security-Policy", "")
# Should have CSP policy
assert isinstance(csp, str) and len(csp) > 0
def test_csp_blocks_inline_scripts(self, client: TestClient, auth_token: str, db_session: Session):
"""Test CSP blocks inline scripts."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": "<div onclick='alert(1)'>Click</div>"
},
headers={"Authorization": f"Bearer {auth_token}"}
)
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
# Inline handlers should be removed
assert "onclick" not in html.lower()
def test_csp_restricts_script_sources(self, client: TestClient, auth_token: str, db_session: Session):
"""Test CSP restricts external script sources."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": "<script src='https://evil.com/malicious.js'></script>",
"dependencies": ["https://evil.com/malicious.js"]
},
headers={"Authorization": f"Bearer {auth_token}"}
)
# Should block unauthorized script sources
if response.status_code in [200, 201]:
data = response.json()
# Check dependencies filtered
deps = data.get("dependencies", [])
assert "evil.com" not in str(deps)
class TestHTMLAuditLogging:
"""Test HTML security audit logging."""
def test_xss_attempt_logged(self, client: TestClient, auth_token: str, db_session: Session):
"""Test XSS attempts are logged."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
xss_payload = "<script>alert('XSS')</script>"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_payload
},
headers={"Authorization": f"Bearer {auth_token}"}
)
# Check security event logged
audits = db_session.query(CanvasAudit).filter(
CanvasAudit.id == canvas_id
).all()
assert len(audits) >= 0
def test_sanitization_metadata_logged(self, client: TestClient, auth_token: str, db_session: Session):
"""Test HTML sanitization metadata is logged."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
xss_payload = "<img src=x onerror=alert('XSS')>Safe content"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": xss_payload
},
headers={"Authorization": f"Bearer {auth_token}"}
)
if response.status_code in [200, 201]:
# Check sanitization recorded
audits = db_session.query(CanvasAudit).filter(
CanvasAudit.id == canvas_id
).all()
if audits and audits[0].audit_metadata:
# Should include sanitization details
metadata = audits[0].audit_metadata
assert isinstance(metadata, dict)
class TestHTMLWhitelist:
"""Test HTML tag and attribute whitelisting."""
def test_safe_tags_allowed(self, client: TestClient, auth_token: str, db_session: Session):
"""Test safe HTML tags are allowed."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
safe_html = "<div><p>Text</p><span>Label</span></div>"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": safe_html
},
headers={"Authorization": f"Bearer {auth_token}"}
)
# Safe tags should be preserved
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
assert all(tag in html for tag in ["div", "p", "span"])
def test_safe_attributes_allowed(self, client: TestClient, auth_token: str, db_session: Session):
"""Test safe HTML attributes are allowed."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
safe_html = "<div class='container' id='main' data-value='test'>Content</div>"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": safe_html
},
headers={"Authorization": f"Bearer {auth_token}"}
)
# Safe attributes should be preserved
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
assert "class" in html
assert "id" in html
assert "data-value" in html
def test_dangerous_attributes_removed(self, client: TestClient, auth_token: str, db_session: Session):
"""Test dangerous HTML attributes are removed."""
agent = AutonomousAgentFactory()
db_session.add(agent)
db_session.commit()
canvas_id = str(uuid.uuid4())
dangerous_html = "<div onmouseover='alert(1)' style='behavior:url(xss)'>Content</div>"
response = client.post(
f"/api/canvas/{canvas_id}/components",
json={
"type": "custom",
"html": dangerous_html
},
headers={"Authorization": f"Bearer {auth_token}"}
)
if response.status_code in [200, 201]:
data = response.json()
html = data.get("html", "")
# Dangerous attributes should be removed
assert "onmouseover" not in html.lower()
assert "behavior:" not in html.lower()
|