File size: 20,441 Bytes
aef804e
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
"""
Agent CRUD operations database integration tests (Phase 3, Plan 1, Task 2.2).

Tests cover:
- Agent CRUD operations with database
- Agent filtering and sorting
- Agent pagination
- Agent relationship queries (executions, feedback)

Coverage target: All query patterns tested with actual database
"""

import pytest
from datetime import datetime, timedelta
from sqlalchemy.orm import Session
from sqlalchemy import and_, or_, desc

from core.models import (
    AgentRegistry, AgentExecution, AgentFeedback, AgentStatus,
    User
)


class TestAgentCRUDOperations:
    """Integration tests for agent CRUD operations."""

    def test_create_agent(self, db_session: Session):
        """Test creating an agent in database."""
        agent = AgentRegistry(
            name="CRUDAgent",
            category="test",
            module_path="test.module",
            class_name="CRUDAgent",
            status=AgentStatus.INTERN.value,
            confidence_score=0.6,
            description="A CRUD test agent"
        )
        db_session.add(agent)
        db_session.commit()
        db_session.refresh(agent)

        assert agent.id is not None
        assert agent.name == "CRUDAgent"
        assert agent.category == "test"
        assert agent.status == AgentStatus.INTERN.value

    def test_read_agent_by_id(self, db_session: Session):
        """Test reading an agent by ID."""
        agent = AgentRegistry(
            name="ReadAgent",
            category="test",
            module_path="test.module",
            class_name="ReadAgent",
            status=AgentStatus.SUPERVISED.value,
            confidence_score=0.8
        )
        db_session.add(agent)
        db_session.commit()
        db_session.refresh(agent)

        retrieved = db_session.query(AgentRegistry).filter_by(id=agent.id).first()
        assert retrieved is not None
        assert retrieved.id == agent.id
        assert retrieved.name == "ReadAgent"

    def test_update_agent(self, db_session: Session):
        """Test updating an agent."""
        agent = AgentRegistry(
            name="UpdateAgent",
            category="test",
            module_path="test.module",
            class_name="UpdateAgent",
            status=AgentStatus.STUDENT.value,
            confidence_score=0.3
        )
        db_session.add(agent)
        db_session.commit()
        db_session.refresh(agent)

        # Update agent
        agent.name = "UpdatedAgent"
        agent.confidence_score = 0.75
        agent.status = AgentStatus.SUPERVISED.value
        db_session.commit()
        db_session.refresh(agent)

        assert agent.name == "UpdatedAgent"
        assert agent.confidence_score == 0.75
        assert agent.status == AgentStatus.SUPERVISED.value

    def test_delete_agent(self, db_session: Session):
        """Test deleting an agent."""
        agent = AgentRegistry(
            name="DeleteAgent",
            category="test",
            module_path="test.module",
            class_name="DeleteAgent",
            status=AgentStatus.STUDENT.value,
            confidence_score=0.3
        )
        db_session.add(agent)
        db_session.commit()
        db_session.refresh(agent)

        agent_id = agent.id

        db_session.delete(agent)
        db_session.commit()

        deleted = db_session.query(AgentRegistry).filter_by(id=agent_id).first()
        assert deleted is None

    def test_bulk_agent_creation(self, db_session: Session):
        """Test creating multiple agents."""
        agents = []
        for i in range(5):
            agent = AgentRegistry(
                name=f"BulkAgent{i}",
                category="test",
                module_path="test.module",
                class_name=f"BulkAgent{i}",
                status=AgentStatus.INTERN.value,
                confidence_score=0.5 + (i * 0.1)
            )
            agents.append(agent)
            db_session.add(agent)

        db_session.commit()

        count = db_session.query(AgentRegistry).filter(
            AgentRegistry.name.like("BulkAgent%")
        ).count()
        assert count == 5


class TestAgentFiltering:
    """Integration tests for agent filtering."""

    def test_filter_by_status(self, db_session: Session):
        """Test filtering agents by status."""
        # Create agents with different statuses
        for status in [AgentStatus.STUDENT, AgentStatus.INTERN, AgentStatus.SUPERVISED]:
            agent = AgentRegistry(
                name=f"FilterAgent{status.value}",
                category="test",
                module_path="test.module",
                class_name="FilterAgent",
                status=status.value,
                confidence_score=0.5
            )
            db_session.add(agent)
        db_session.commit()

        interns = db_session.query(AgentRegistry).filter_by(
            status=AgentStatus.INTERN.value
        ).all()

        assert len(interns) == 1
        assert interns[0].status == AgentStatus.INTERN.value

    def test_filter_by_category(self, db_session: Session):
        """Test filtering agents by category."""
        categories = ["sales", "support", "finance"]
        for cat in categories:
            agent = AgentRegistry(
                name=f"{cat.capitalize()}Agent",
                category=cat,
                module_path="test.module",
                class_name="CategoryAgent",
                status=AgentStatus.INTERN.value,
                confidence_score=0.6
            )
            db_session.add(agent)
        db_session.commit()

        sales_agents = db_session.query(AgentRegistry).filter_by(
            category="sales"
        ).all()

        assert len(sales_agents) == 1
        assert sales_agents[0].category == "sales"

    def test_filter_by_confidence_range(self, db_session: Session):
        """Test filtering agents by confidence score range."""
        # Create agents with different confidence scores
        for score in [0.3, 0.5, 0.7, 0.9]:
            agent = AgentRegistry(
                name=f"ConfidenceAgent{int(score*10)}",
                category="test",
                module_path="test.module",
                class_name="ConfidenceAgent",
                status=AgentStatus.INTERN.value,
                confidence_score=score
            )
            db_session.add(agent)
        db_session.commit()

        high_confidence = db_session.query(AgentRegistry).filter(
            AgentRegistry.confidence_score >= 0.7
        ).all()

        assert len(high_confidence) == 2

    def test_filter_by_multiple_conditions(self, db_session: Session):
        """Test filtering agents with multiple conditions."""
        agent1 = AgentRegistry(
            name="MultiFilter1",
            category="sales",
            module_path="test.module",
            class_name="MultiAgent",
            status=AgentStatus.INTERN.value,
            confidence_score=0.6
        )
        agent2 = AgentRegistry(
            name="MultiFilter2",
            category="sales",
            module_path="test.module",
            class_name="MultiAgent",
            status=AgentStatus.SUPERVISED.value,
            confidence_score=0.8
        )
        db_session.add(agent1)
        db_session.add(agent2)
        db_session.commit()

        results = db_session.query(AgentRegistry).filter(
            and_(
                AgentRegistry.category == "sales",
                AgentRegistry.confidence_score >= 0.7
            )
        ).all()

        assert len(results) == 1
        assert results[0].name == "MultiFilter2"

    def test_filter_with_or_condition(self, db_session: Session):
        """Test filtering agents with OR condition."""
        agent1 = AgentRegistry(
            name="OrFilter1",
            category="sales",
            module_path="test.module",
            class_name="OrAgent",
            status=AgentStatus.STUDENT.value,
            confidence_score=0.3
        )
        agent2 = AgentRegistry(
            name="OrFilter2",
            category="support",
            module_path="test.module",
            class_name="OrAgent",
            status=AgentStatus.INTERN.value,
            confidence_score=0.6
        )
        agent3 = AgentRegistry(
            name="OrFilter3",
            category="finance",
            module_path="test.module",
            class_name="OrAgent",
            status=AgentStatus.AUTONOMOUS.value,
            confidence_score=0.95
        )
        db_session.add(agent1)
        db_session.add(agent2)
        db_session.add(agent3)
        db_session.commit()

        results = db_session.query(AgentRegistry).filter(
            or_(
                AgentRegistry.category == "sales",
                AgentRegistry.category == "support"
            )
        ).all()

        assert len(results) == 2


class TestAgentSorting:
    """Integration tests for agent sorting."""

    def test_sort_by_name(self, db_session: Session):
        """Test sorting agents by name."""
        names = ["Zebra", "Alpha", "Charlie"]
        for name in names:
            agent = AgentRegistry(
                name=name,
                category="test",
                module_path="test.module",
                class_name="SortAgent",
                status=AgentStatus.INTERN.value,
                confidence_score=0.6
            )
            db_session.add(agent)
        db_session.commit()

        agents = db_session.query(AgentRegistry).order_by(
            AgentRegistry.name
        ).all()

        assert agents[0].name == "Alpha"
        assert agents[1].name == "Charlie"
        assert agents[2].name == "Zebra"

    def test_sort_by_confidence_desc(self, db_session: Session):
        """Test sorting agents by confidence descending."""
        for score in [0.3, 0.9, 0.6]:
            agent = AgentRegistry(
                name=f"SortScore{int(score*10)}",
                category="test",
                module_path="test.module",
                class_name="SortScoreAgent",
                status=AgentStatus.INTERN.value,
                confidence_score=score
            )
            db_session.add(agent)
        db_session.commit()

        agents = db_session.query(AgentRegistry).order_by(
            desc(AgentRegistry.confidence_score)
        ).all()

        assert agents[0].confidence_score == 0.9
        assert agents[1].confidence_score == 0.6
        assert agents[2].confidence_score == 0.3

    def test_sort_by_created_at(self, db_session: Session):
        """Test sorting agents by creation time."""
        agent1 = AgentRegistry(
            name="FirstAgent",
            category="test",
            module_path="test.module",
            class_name="TimeAgent",
            status=AgentStatus.INTERN.value,
            confidence_score=0.6,
            created_at=datetime.utcnow() - timedelta(hours=2)
        )
        agent2 = AgentRegistry(
            name="SecondAgent",
            category="test",
            module_path="test.module",
            class_name="TimeAgent",
            status=AgentStatus.INTERN.value,
            confidence_score=0.6,
            created_at=datetime.utcnow() - timedelta(hours=1)
        )
        db_session.add(agent1)
        db_session.add(agent2)
        db_session.commit()

        agents = db_session.query(AgentRegistry).order_by(
            AgentRegistry.created_at
        ).all()

        assert agents[0].name == "FirstAgent"
        assert agents[1].name == "SecondAgent"


class TestAgentPagination:
    """Integration tests for agent pagination."""

    def test_paginate_agents(self, db_session: Session):
        """Test paginating agent list."""
        # Create 15 agents
        for i in range(15):
            agent = AgentRegistry(
                name=f"PageAgent{i}",
                category="test",
                module_path="test.module",
                class_name="PageAgent",
                status=AgentStatus.INTERN.value,
                confidence_score=0.6
            )
            db_session.add(agent)
        db_session.commit()

        # Get first page (limit 5)
        page1 = db_session.query(AgentRegistry).filter(
            AgentRegistry.name.like("PageAgent%")
        ).limit(5).all()

        assert len(page1) == 5

        # Get second page (offset 5, limit 5)
        page2 = db_session.query(AgentRegistry).filter(
            AgentRegistry.name.like("PageAgent%")
        ).offset(5).limit(5).all()

        assert len(page2) == 5
        # Verify different agents
        assert page1[0].name != page2[0].name

    def test_paginate_with_ordering(self, db_session: Session):
        """Test paginating with ordering."""
        # Create agents
        names = ["AgentZ", "AgentA", "AgentM", "AgentB", "AgentY"]
        for name in names:
            agent = AgentRegistry(
                name=name,
                category="test",
                module_path="test.module",
                class_name="OrderedAgent",
                status=AgentStatus.INTERN.value,
                confidence_score=0.6
            )
            db_session.add(agent)
        db_session.commit()

        # Get first page ordered by name
        page1 = db_session.query(AgentRegistry).filter(
            AgentRegistry.name.like("Agent%")
        ).order_by(AgentRegistry.name).limit(2).all()

        assert len(page1) == 2
        assert page1[0].name == "AgentA"
        assert page1[1].name == "AgentB"

        # Get second page
        page2 = db_session.query(AgentRegistry).filter(
            AgentRegistry.name.like("Agent%")
        ).order_by(AgentRegistry.name).offset(2).limit(2).all()

        assert len(page2) == 2
        assert page2[0].name == "AgentM"
        assert page2[1].name == "AgentY"


class TestAgentRelationshipQueries:
    """Integration tests for agent relationship queries."""

    def test_agent_with_executions(self, db_session: Session):
        """Test querying agent executions relationship."""
        agent = AgentRegistry(
            name="RelAgent",
            category="test",
            module_path="test.module",
            class_name="RelAgent",
            status=AgentStatus.AUTONOMOUS.value,
            confidence_score=0.95
        )
        db_session.add(agent)
        db_session.commit()

        # Create executions
        for i in range(3):
            execution = AgentExecution(
                agent_id=agent.id,
                workspace_id="default",
                status="completed",
                input_data={"execution": i}
            )
            db_session.add(execution)
        db_session.commit()

        # Query executions
        executions = db_session.query(AgentExecution).filter_by(
            agent_id=agent.id
        ).all()

        assert len(executions) == 3
        for exec in executions:
            assert exec.agent_id == agent.id

    def test_agent_with_feedback(self, db_session: Session):
        """Test querying agent feedback relationship."""
        agent = AgentRegistry(
            name="FeedbackAgent",
            category="test",
            module_path="test.module",
            class_name="FeedbackAgent",
            status=AgentStatus.SUPERVISED.value,
            confidence_score=0.8
        )
        db_session.add(agent)
        db_session.commit()

        # Create execution
        execution = AgentExecution(
            agent_id=agent.id,
            workspace_id="default",
            status="completed",
            input_data={}
        )
        db_session.add(execution)
        db_session.commit()

        # Create feedback
        feedback = AgentFeedback(
            agent_id=agent.id,
            execution_id=execution.id,
            rating=5,
            feedback="Excellent work!"
        )
        db_session.add(feedback)
        db_session.commit()

        # Query feedback
        feedbacks = db_session.query(AgentFeedback).filter_by(
            agent_id=agent.id
        ).all()

        assert len(feedbacks) == 1
        assert feedbacks[0].rating == 5

    def test_join_agent_with_executions(self, db_session: Session):
        """Test joining agents with executions."""
        agent1 = AgentRegistry(
            name="JoinAgent1",
            category="test",
            module_path="test.module",
            class_name="JoinAgent",
            status=AgentStatus.AUTONOMOUS.value,
            confidence_score=0.95
        )
        agent2 = AgentRegistry(
            name="JoinAgent2",
            category="test",
            module_path="test.module",
            class_name="JoinAgent",
            status=AgentStatus.INTERN.value,
            confidence_score=0.6
        )
        db_session.add(agent1)
        db_session.add(agent2)
        db_session.commit()

        # Create execution only for agent1
        execution = AgentExecution(
            agent_id=agent1.id,
            workspace_id="default",
            status="completed",
            input_data={}
        )
        db_session.add(execution)
        db_session.commit()

        # Join query
        results = db_session.query(AgentRegistry).join(
            AgentExecution,
            AgentRegistry.id == AgentExecution.agent_id
        ).all()

        # Should only return agent1 which has executions
        assert len(results) == 1
        assert results[0].name == "JoinAgent1"

    def test_count_executions_per_agent(self, db_session: Session):
        """Test counting executions per agent."""
        agent1 = AgentRegistry(
            name="CountAgent1",
            category="test",
            module_path="test.module",
            class_name="CountAgent",
            status=AgentStatus.AUTONOMOUS.value,
            confidence_score=0.95
        )
        agent2 = AgentRegistry(
            name="CountAgent2",
            category="test",
            module_path="test.module",
            class_name="CountAgent",
            status=AgentStatus.AUTONOMOUS.value,
            confidence_score=0.95
        )
        db_session.add(agent1)
        db_session.add(agent2)
        db_session.commit()

        # Create different number of executions
        for i in range(5):
            execution = AgentExecution(
                agent_id=agent1.id,
                workspace_id="default",
                status="completed",
                input_data={}
            )
            db_session.add(execution)

        for i in range(2):
            execution = AgentExecution(
                agent_id=agent2.id,
                workspace_id="default",
                status="completed",
                input_data={}
            )
            db_session.add(execution)
        db_session.commit()

        # Count executions
        agent1_count = db_session.query(AgentExecution).filter_by(
            agent_id=agent1.id
        ).count()
        agent2_count = db_session.query(AgentExecution).filter_by(
            agent_id=agent2.id
        ).count()

        assert agent1_count == 5
        assert agent2_count == 2

    def test_average_feedback_per_agent(self, db_session: Session):
        """Test calculating average feedback rating per agent."""
        agent = AgentRegistry(
            name="AvgAgent",
            category="test",
            module_path="test.module",
            class_name="AvgAgent",
            status=AgentStatus.SUPERVISED.value,
            confidence_score=0.8
        )
        db_session.add(agent)
        db_session.commit()

        # Create execution
        execution = AgentExecution(
            agent_id=agent.id,
            workspace_id="default",
            status="completed",
            input_data={}
        )
        db_session.add(execution)
        db_session.commit()

        # Create feedback with different ratings
        ratings = [5, 4, 5, 3, 4]
        for rating in ratings:
            feedback = AgentFeedback(
                agent_id=agent.id,
                execution_id=execution.id,
                rating=rating,
                feedback=f"Rating {rating}"
            )
            db_session.add(feedback)
        db_session.commit()

        # Calculate average
        from sqlalchemy import func
        avg_rating = db_session.query(func.avg(AgentFeedback.rating)).filter_by(
            agent_id=agent.id
        ).scalar()

        expected_avg = sum(ratings) / len(ratings)
        assert avg_rating == expected_avg