File size: 22,013 Bytes
aef804e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 | """
Coverage expansion tests for Canvas Presentation.
Target: 80%+ coverage for canvas_tool.py:
- Chart presentation (line, bar, pie)
- Form presentation and validation
- Canvas state management (update, close)
- Governance integration (maturity-based permissions)
- WebSocket broadcast verification
Tests use mocked WebSocket to focus on canvas logic.
"""
import pytest
from unittest.mock import AsyncMock, Mock, patch
from datetime import datetime
from core.models import AgentStatus, AgentRegistry, CanvasAudit
# Add parent directory to path for imports
import sys
from pathlib import Path
sys.path.insert(0, str(Path(__file__).parent.parent.parent.parent))
# ============================================================================
# Fixtures
# ============================================================================
@pytest.fixture
def mock_db():
"""Mock database session."""
db = Mock()
db.add = Mock()
db.commit = Mock()
db.refresh = Mock()
db.rollback = Mock()
db.query = Mock(return_value=Mock(first=Mock(return_value=None)))
return db
@pytest.fixture
def mock_db_context():
"""Mock database context manager."""
with patch('core.database.get_db_session') as mock_ctx:
db = Mock()
db.add = Mock()
db.commit = Mock()
db.refresh = Mock()
db.rollback = Mock()
# Track different types of objects
mock_agent = None
mock_agent_execution = None
mock_canvas_audit = None
def capture_add(obj):
"""Capture added objects."""
nonlocal mock_agent, mock_agent_execution, mock_canvas_audit
if hasattr(obj, 'module_path'): # AgentRegistry
mock_agent = obj
elif hasattr(obj, 'triggered_by'): # AgentExecution
mock_agent_execution = obj
elif hasattr(obj, 'canvas_id'): # CanvasAudit
mock_canvas_audit = obj
db.add = Mock(side_effect=capture_add)
def mock_query(model):
"""Mock query that returns appropriate object."""
query_obj = Mock()
def mock_filter(*args, **kwargs):
result = Mock()
if hasattr(model, '__tablename__'):
if model.__tablename__ == 'agent_registry':
result.first = Mock(return_value=mock_agent)
elif model.__tablename__ == 'agent_execution':
result.first = Mock(return_value=mock_agent_execution)
elif model.__tablename__ == 'canvas_audit':
result.first = Mock(return_value=mock_canvas_audit)
else:
result.first = Mock(return_value=None)
else:
result.first = Mock(return_value=None)
return result
query_obj.filter = mock_filter
return query_obj
db.query = Mock(side_effect=mock_query)
mock_ctx.return_value.__enter__ = Mock(return_value=db)
mock_ctx.return_value.__exit__ = Mock(return_value=False)
yield mock_ctx
@pytest.fixture
def mock_ws_manager():
"""Mock WebSocket manager with AsyncMock for async broadcast methods."""
# Create mock manager with AsyncMock for async methods
mock_mgr = Mock()
mock_mgr.broadcast = AsyncMock()
# Patch ws_manager in canvas_tool module
with patch('tools.canvas_tool.ws_manager', mock_mgr):
yield mock_mgr
@pytest.fixture
def mock_canvas_type_registry():
"""Mock canvas type registry."""
with patch('tools.canvas_tool.canvas_type_registry') as mock_registry:
mock_registry.validate_canvas_type = Mock(return_value=True)
mock_registry.validate_component = Mock(return_value=True)
mock_registry.validate_layout = Mock(return_value=True)
# Mock get_min_maturity to return student (lowest maturity)
mock_maturity = Mock()
mock_maturity.value = "student"
mock_registry.get_min_maturity = Mock(return_value=mock_maturity)
yield mock_registry
# ============================================================================
# Task 1: Test canvas chart presentation and rendering
# ============================================================================
class TestChartPresentation:
"""Test chart presentation for all types (line, bar, pie)."""
@pytest.mark.asyncio
async def test_present_line_chart(self, mock_db_context, mock_ws_manager):
"""Test presenting a line chart with data."""
from tools.canvas_tool import present_chart
chart_data = [
{"x": "Jan", "y": 100},
{"x": "Feb", "y": 200},
{"x": "Mar", "y": 150},
]
result = await present_chart(
user_id="test_user",
chart_type="line_chart",
data=chart_data,
title="Monthly Sales"
)
assert result["success"] is True
assert "canvas_id" in result
assert result["chart_type"] == "line_chart"
assert mock_ws_manager.broadcast.called
@pytest.mark.asyncio
async def test_present_bar_chart(self, mock_db_context, mock_ws_manager):
"""Test presenting a bar chart with categories."""
from tools.canvas_tool import present_chart
chart_data = [
{"category": "A", "value": 100},
{"category": "B", "value": 200},
{"category": "C", "value": 150}
]
result = await present_chart(
user_id="test_user",
chart_type="bar_chart",
data=chart_data,
title="Category Comparison"
)
assert result["success"] is True
assert result["chart_type"] == "bar_chart"
assert mock_ws_manager.broadcast.called
@pytest.mark.asyncio
async def test_present_pie_chart(self, mock_db_context, mock_ws_manager):
"""Test presenting a pie chart with slices."""
from tools.canvas_tool import present_chart
chart_data = [
{"slice": "Product A", "value": 45},
{"slice": "Product B", "value": 30},
{"slice": "Product C", "value": 25}
]
result = await present_chart(
user_id="test_user",
chart_type="pie_chart",
data=chart_data,
title="Market Share"
)
assert result["success"] is True
assert result["chart_type"] == "pie_chart"
assert mock_ws_manager.broadcast.called
@pytest.mark.asyncio
async def test_chart_with_custom_options(self, mock_db_context, mock_ws_manager):
"""Test chart with custom colors, axes, legend options."""
from tools.canvas_tool import present_chart
chart_data = [{"x": 1, "y": 2}]
result = await present_chart(
user_id="test_user",
chart_type="line_chart",
data=chart_data,
title="Custom Chart",
color="#FF0000",
show_legend=True,
x_axis_label="Time",
y_axis_label="Value"
)
assert result["success"] is True
# Verify custom options passed to canvas state
call_args = mock_ws_manager.broadcast.call_args
canvas_data = call_args[0][1]["data"]["data"]
assert canvas_data["color"] == "#FF0000"
assert canvas_data["show_legend"] is True
# ============================================================================
# Task 2: Test canvas form presentation and validation
# ============================================================================
class TestFormPresentation:
"""Test form presentation and field validation."""
@pytest.mark.asyncio
async def test_present_form(self, mock_db_context, mock_ws_manager):
"""Test presenting a form with email and name fields."""
from tools.canvas_tool import present_form
form_schema = {
"fields": [
{"name": "email", "type": "email", "label": "Email", "required": True},
{"name": "name", "type": "text", "label": "Name", "required": True}
]
}
result = await present_form(
user_id="test_user",
form_schema=form_schema,
title="User Information"
)
assert result["success"] is True
assert "canvas_id" in result
assert mock_ws_manager.broadcast.called
@pytest.mark.asyncio
async def test_form_validation_email_field(self, mock_db_context, mock_ws_manager):
"""Test form validation for email field type."""
from tools.canvas_tool import present_form
form_schema = {
"fields": [
{"name": "email", "type": "email", "required": True},
{"name": "age", "type": "number", "min": 18}
]
}
result = await present_form(
user_id="test_user",
form_schema=form_schema,
title="Registration Form"
)
assert result["success"] is True
# Verify form schema includes validation rules
call_args = mock_ws_manager.broadcast.call_args
schema = call_args[0][1]["data"]["data"]["schema"]
assert schema["fields"][0]["type"] == "email"
assert schema["fields"][1]["min"] == 18
@pytest.mark.asyncio
async def test_form_validation_invalid_email(self, mock_db_context, mock_ws_manager):
"""Test form validation rejects invalid email format."""
from tools.canvas_tool import present_form
form_schema = {
"fields": [
{"name": "email", "type": "email", "required": True}
]
}
result = await present_form(
user_id="test_user",
form_schema=form_schema,
title="Email Validation"
)
# Form presentation succeeds (validation happens on submission)
assert result["success"] is True
@pytest.mark.asyncio
async def test_form_validation_age_below_minimum(self, mock_db_context, mock_ws_manager):
"""Test form validation enforces minimum age constraint."""
from tools.canvas_tool import present_form
form_schema = {
"fields": [
{"name": "age", "type": "number", "min": 18, "label": "Age"}
]
}
result = await present_form(
user_id="test_user",
form_schema=form_schema,
title="Age Verification"
)
assert result["success"] is True
# Verify min constraint in schema
call_args = mock_ws_manager.broadcast.call_args
schema = call_args[0][1]["data"]["data"]["schema"]
assert schema["fields"][0]["min"] == 18
@pytest.mark.asyncio
async def test_form_validation_required_field(self, mock_db_context, mock_ws_manager):
"""Test form validation enforces required fields."""
from tools.canvas_tool import present_form
form_schema = {
"fields": [
{"name": "email", "type": "email", "required": True},
{"name": "phone", "type": "text", "required": False}
]
}
result = await present_form(
user_id="test_user",
form_schema=form_schema,
title="Contact Form"
)
assert result["success"] is True
# Verify required field constraint
call_args = mock_ws_manager.broadcast.call_args
schema = call_args[0][1]["data"]["data"]["schema"]
assert schema["fields"][0]["required"] is True
assert schema["fields"][1]["required"] is False
# ============================================================================
# Task 3: Test canvas state management and governance integration
# ============================================================================
class TestCanvasStateManagement:
"""Test canvas state updates and lifecycle."""
@pytest.mark.asyncio
async def test_update_canvas_state(self, mock_db_context, mock_ws_manager):
"""Test updating canvas state with new data."""
from tools.canvas_tool import present_chart, update_canvas
# Create canvas first
create_result = await present_chart(
user_id="test_user",
chart_type="line_chart",
data=[{"x": 1, "y": 2}],
title="Original Title"
)
canvas_id = create_result["canvas_id"]
# Update canvas
update_result = await update_canvas(
user_id="test_user",
canvas_id=canvas_id,
updates={"title": "Updated Title", "data": [{"x": 1, "y": 5}]}
)
assert update_result["success"] is True
assert update_result["canvas_id"] == canvas_id
assert "title" in update_result["updated_fields"]
@pytest.mark.asyncio
async def test_close_canvas(self, mock_db_context, mock_ws_manager):
"""Test closing a canvas."""
from tools.canvas_tool import close_canvas
result = await close_canvas(
user_id="test_user",
session_id="session-123"
)
assert result["success"] is True
assert mock_ws_manager.broadcast.called
# Verify close action in broadcast
call_args = mock_ws_manager.broadcast.call_args
assert call_args[0][1]["data"]["action"] == "close"
@pytest.mark.asyncio
async def test_canvas_state_serialization(self, mock_db_context, mock_ws_manager):
"""Test canvas state serializes to JSON without circular references."""
from tools.canvas_tool import present_chart
result = await present_chart(
user_id="test_user",
chart_type="line_chart",
data=[{"x": 1, "y": 2}, {"x": 2, "y": 4}],
title="Serialization Test"
)
assert result["success"] is True
# Verify broadcast data is serializable
call_args = mock_ws_manager.broadcast.call_args
broadcast_data = call_args[0][1]
# Should not raise TypeError
import json
json.dumps(broadcast_data)
class TestGovernanceIntegration:
"""Test governance checks for canvas operations."""
@pytest.mark.asyncio
async def test_student_agent_can_present_charts(self, mock_db_context, mock_ws_manager):
"""Test that STUDENT agents can present charts (complexity 1)."""
from tools.canvas_tool import present_chart
# Create STUDENT agent mock
mock_agent = Mock(spec=AgentRegistry)
mock_agent.id = "student-agent-1"
mock_agent.name = "StudentAgent"
mock_agent.status = AgentStatus.STUDENT.value
with patch('tools.canvas_tool.AgentContextResolver') as resolver_mock:
resolver = Mock()
resolver.resolve_agent_for_request = AsyncMock(return_value=(mock_agent, {}))
resolver_mock.return_value = resolver
with patch('tools.canvas_tool.ServiceFactory') as factory_mock:
governance = Mock()
# Charts are complexity 1, allowed for STUDENT
governance.can_perform_action = Mock(return_value={
"allowed": True,
"reason": None
})
factory_mock.get_governance_service = Mock(return_value=governance)
result = await present_chart(
user_id="test_user",
chart_type="line_chart",
data=[{"x": 1, "y": 2}],
title="Student Chart",
agent_id=mock_agent.id
)
assert result["success"] is True
@pytest.mark.asyncio
async def test_student_agent_blocked_from_forms(self, mock_db_context, mock_ws_manager):
"""Test that STUDENT agents are blocked from forms (complexity 3)."""
from tools.canvas_tool import present_form
# Create STUDENT agent mock
mock_agent = Mock(spec=AgentRegistry)
mock_agent.id = "student-agent-1"
mock_agent.name = "StudentAgent"
mock_agent.status = AgentStatus.STUDENT.value
with patch('tools.canvas_tool.AgentContextResolver') as resolver_mock:
resolver = Mock()
resolver.resolve_agent_for_request = AsyncMock(return_value=(mock_agent, {}))
resolver_mock.return_value = resolver
with patch('tools.canvas_tool.ServiceFactory') as factory_mock:
governance = Mock()
# Forms are complexity 3, blocked for STUDENT
governance.can_perform_action = Mock(return_value={
"allowed": False,
"reason": "STUDENT agents cannot present forms"
})
factory_mock.get_governance_service = Mock(return_value=governance)
result = await present_form(
user_id="test_user",
form_schema={"fields": []},
title="Student Form",
agent_id=mock_agent.id
)
assert result["success"] is False
assert "not permitted" in result["error"].lower()
@pytest.mark.asyncio
async def test_autonomous_agent_full_access(self, mock_db_context, mock_ws_manager):
"""Test that AUTONOMOUS agents have full access to all operations."""
from tools.canvas_tool import present_chart, present_form
# Create AUTONOMOUS agent mock
mock_agent = Mock(spec=AgentRegistry)
mock_agent.id = "autonomous-agent-1"
mock_agent.name = "AutonomousAgent"
mock_agent.status = AgentStatus.AUTONOMOUS.value
with patch('tools.canvas_tool.AgentContextResolver') as resolver_mock:
resolver = Mock()
resolver.resolve_agent_for_request = AsyncMock(return_value=(mock_agent, {}))
resolver_mock.return_value = resolver
with patch('tools.canvas_tool.ServiceFactory') as factory_mock:
governance = Mock()
# AUTONOMOUS agents can do everything
governance.can_perform_action = Mock(return_value={
"allowed": True,
"reason": None
})
factory_mock.get_governance_service = Mock(return_value=governance)
# Test chart (complexity 1)
chart_result = await present_chart(
user_id="test_user",
chart_type="line_chart",
data=[{"x": 1, "y": 2}],
agent_id=mock_agent.id
)
# Test form (complexity 3)
form_result = await present_form(
user_id="test_user",
form_schema={"fields": []},
agent_id=mock_agent.id
)
assert chart_result["success"] is True
assert form_result["success"] is True
@pytest.mark.asyncio
async def test_intern_agent_chart_access(self, mock_db_context, mock_ws_manager):
"""Test that INTERN agents can present charts (complexity 1-2)."""
from tools.canvas_tool import present_chart
# Create INTERN agent mock
mock_agent = Mock(spec=AgentRegistry)
mock_agent.id = "intern-agent-1"
mock_agent.name = "InternAgent"
mock_agent.status = AgentStatus.INTERN.value
with patch('tools.canvas_tool.AgentContextResolver') as resolver_mock:
resolver = Mock()
resolver.resolve_agent_for_request = AsyncMock(return_value=(mock_agent, {}))
resolver_mock.return_value = resolver
with patch('tools.canvas_tool.ServiceFactory') as factory_mock:
governance = Mock()
# Charts are complexity 1, allowed for INTERN
governance.can_perform_action = Mock(return_value={
"allowed": True,
"reason": None
})
factory_mock.get_governance_service = Mock(return_value=governance)
result = await present_chart(
user_id="test_user",
chart_type="bar_chart",
data=[{"category": "A", "value": 100}],
agent_id=mock_agent.id
)
assert result["success"] is True
@pytest.mark.asyncio
async def test_supervised_agent_form_access(self, mock_db_context, mock_ws_manager):
"""Test that SUPERVISED agents can present forms (complexity 1-3)."""
from tools.canvas_tool import present_form
# Create SUPERVISED agent mock
mock_agent = Mock(spec=AgentRegistry)
mock_agent.id = "supervised-agent-1"
mock_agent.name = "SupervisedAgent"
mock_agent.status = AgentStatus.SUPERVISED.value
with patch('tools.canvas_tool.AgentContextResolver') as resolver_mock:
resolver = Mock()
resolver.resolve_agent_for_request = AsyncMock(return_value=(mock_agent, {}))
resolver_mock.return_value = resolver
with patch('tools.canvas_tool.ServiceFactory') as factory_mock:
governance = Mock()
# Forms are complexity 3, allowed for SUPERVISED
governance.can_perform_action = Mock(return_value={
"allowed": True,
"reason": None
})
factory_mock.get_governance_service = Mock(return_value=governance)
result = await present_form(
user_id="test_user",
form_schema={
"fields": [
{"name": "field1", "type": "text", "label": "Field 1"}
]
},
agent_id=mock_agent.id
)
assert result["success"] is True
|