File size: 48,973 Bytes
aef804e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 | """
Agent Execution Orchestration Tests
Comprehensive end-to-end tests for agent execution flow:
- Governance validation before execution
- LLM streaming with BYOK handler
- WebSocket token delivery
- Chat history persistence
- AgentExecution audit trail
- Episode creation triggering
- Error handling scenarios
- Sync execution wrapper
Coverage Target: 50%+ on agent_execution_service.py
"""
import pytest
import asyncio
from unittest.mock import Mock, AsyncMock, MagicMock, patch
from datetime import datetime
from sqlalchemy.orm import Session
from core.agent_execution_service import execute_agent_chat, execute_agent_chat_sync
from core.models import AgentExecution, AgentRegistry, ChatSession
from core.llm.byok_handler import QueryComplexity
# ============================================================================
# Test Fixtures
# ============================================================================
@pytest.fixture
def mock_autonomous_agent(db_session):
"""Create AUTONOMOUS agent for testing"""
agent = AgentRegistry(
id="test_autonomous_agent",
name="TestAutonomousAgent",
category="testing",
status="autonomous", # lowercase to match AgentStatus enum
description="Test autonomous agent",
module_path="test.agent",
class_name="TestAgent"
)
db_session.add(agent)
db_session.commit()
db_session.refresh(agent)
yield agent
# Cleanup
db_session.query(AgentExecution).filter(AgentExecution.agent_id == agent.id).delete()
db_session.query(AgentRegistry).filter(AgentRegistry.id == agent.id).delete()
db_session.commit()
@pytest.fixture
def mock_student_agent(db_session):
"""Create STUDENT agent for governance testing"""
agent = AgentRegistry(
id="test_student_agent",
name="TestStudentAgent",
category="testing",
status="student", # lowercase to match AgentStatus enum
description="Test student agent",
module_path="test.student_agent",
class_name="StudentAgent"
)
db_session.add(agent)
db_session.commit()
db_session.refresh(agent)
yield agent
# Cleanup
db_session.query(AgentExecution).filter(AgentExecution.agent_id == agent.id).delete()
db_session.query(AgentRegistry).filter(AgentRegistry.id == agent.id).delete()
db_session.commit()
@pytest.fixture
def mock_byok_handler():
"""Mock BYOK handler for LLM streaming"""
byok_instance = MagicMock()
byok_instance.analyze_query_complexity.return_value = QueryComplexity.SIMPLE
byok_instance.get_optimal_provider.return_value = ("openai", "gpt-4")
async def mock_stream(**kwargs):
tokens = ["Hello", " ", "world", "!"]
for token in tokens:
yield token
byok_instance.stream_completion = mock_stream
return byok_instance
@pytest.fixture
def mock_agent_resolver(mock_autonomous_agent):
"""Mock agent context resolver"""
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {"resolution_path": ["explicit_agent_id"]})
)
# Mock governance check
governance = MagicMock()
governance.can_perform_action.return_value = {
"proceed": True,
"allowed": True
}
resolver.governance = governance
return resolver
@pytest.fixture
def mock_websocket_manager():
"""Mock WebSocket manager for streaming"""
ws_instance = MagicMock()
ws_instance.broadcast = AsyncMock()
mock_ws = MagicMock()
mock_ws.broadcast = ws_instance.broadcast
mock_ws.STREAMING_UPDATE = "streaming:update"
mock_ws.STREAMING_COMPLETE = "streaming:complete"
return mock_ws
# ============================================================================
# Test: Governance Validation
# ============================================================================
class TestGovernanceValidation:
"""Tests for governance checks before execution"""
@pytest.mark.asyncio
async def test_governance_check_passes_for_authorized_agent(self, mock_autonomous_agent, db_session):
"""AUTONOMOUS agent passes governance check"""
with patch('core.agent_execution_service.LLMService') as mock_llm:
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.SessionLocal', return_value=db_session):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
llm_instance = MagicMock()
llm.analyze_query_complexity.return_value = QueryComplexity.SIMPLE
llm.get_optimal_provider.return_value = ("openai", "gpt-4")
async def mock_stream(**kwargs):
yield "Test response"
llm.stream_completion = mock_stream
mock_llm.return_value = llm_instance
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="Hello",
user_id="test_user",
stream=False
)
assert result["success"] is True
assert "response" in result
@pytest.mark.asyncio
async def test_governance_check_blocks_unauthorized_action(self, mock_student_agent, db_session):
"""STUDENT agent blocked from chat"""
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_student_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={
"proceed": False,
"allowed": False,
"reason": "STUDENT agent blocked from chat"
}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_student_agent.id,
message="test",
user_id="user_123"
)
assert result["success"] is False
assert "blocked" in result["error"].lower()
@pytest.mark.asyncio
async def test_governance_emergency_bypass_allows_execution(self, mock_student_agent, db_session, monkeypatch):
"""Emergency bypass disables governance checks"""
monkeypatch.setenv("EMERGENCY_GOVERNANCE_BYPASS", "true")
with patch('core.agent_execution_service.LLMService') as mock_llm:
with patch('core.agent_execution_service.ws_manager'):
llm_instance = MagicMock()
llm.analyze_query_complexity.return_value = QueryComplexity.SIMPLE
llm.get_optimal_provider.return_value = ("openai", "gpt-4")
async def mock_stream(**kwargs):
yield "Bypass response"
llm.stream_completion = mock_stream
mock_llm.return_value = llm_instance
result = await execute_agent_chat(
agent_id=mock_student_agent.id,
message="test",
user_id="user_123"
)
# With emergency bypass, governance is skipped but execution may succeed
assert "success" in result or "error" in result
@pytest.mark.asyncio
async def test_governance_flag_disables_checks(self, mock_student_agent, db_session, monkeypatch):
"""STREAMING_GOVERNANCE_ENABLED=false skips governance"""
monkeypatch.setenv("STREAMING_GOVERNANCE_ENABLED", "false")
with patch('core.agent_execution_service.LLMService') as mock_llm:
with patch('core.agent_execution_service.ws_manager'):
llm_instance = MagicMock()
llm.analyze_query_complexity.return_value = QueryComplexity.SIMPLE
llm.get_optimal_provider.return_value = ("openai", "gpt-4")
async def mock_stream(**kwargs):
yield "Disabled governance response"
llm.stream_completion = mock_stream
mock_llm.return_value = llm_instance
result = await execute_agent_chat(
agent_id=mock_student_agent.id,
message="test",
user_id="user_123"
)
# Governance disabled, execution proceeds
assert "success" in result or "error" in result
# ============================================================================
# Test: LLM Streaming Execution
# ============================================================================
class TestLLMStreamingExecution:
"""Tests for BYOK handler streaming"""
@pytest.mark.asyncio
async def test_llm_streaming_accumulates_tokens(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Tokens are accumulated correctly from streaming"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
stream=False
)
assert result["success"] is True
assert result["response"] == "Hello world!"
assert result["tokens"] == 4
@pytest.mark.asyncio
async def test_llm_provider_selection(self, mock_autonomous_agent, db_session):
"""Optimal provider is selected based on query complexity"""
with patch('core.agent_execution_service.LLMService') as mock_llm:
with patch('core.agent_execution_service.ws_manager'):
llm_instance = MagicMock()
llm.analyze_query_complexity.return_value = QueryComplexity.COMPLEX
llm.get_optimal_provider.return_value = ("anthropic", "claude-3-opus")
async def mock_stream(**kwargs):
yield "Complex query response"
llm.stream_completion = mock_stream
mock_llm.return_value = llm_instance
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="Complex question requiring reasoning",
user_id="user_123"
)
assert result["success"] is True
assert result["provider"] == "anthropic"
assert result["model"] == "claude-3-opus"
@pytest.mark.asyncio
async def test_llm_streaming_with_conversation_history(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Conversation history is included in LLM context"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
history = [
{"role": "user", "content": "Previous question"},
{"role": "assistant", "content": "Previous answer"}
]
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="Follow-up question",
user_id="user_123",
conversation_history=history
)
assert result["success"] is True
# Verify history was used (check would require inspecting BYOK call)
@pytest.mark.asyncio
async def test_llm_error_propagation(self, mock_autonomous_agent, db_session):
"""LLM streaming errors are handled gracefully"""
with patch('core.agent_execution_service.LLMService') as mock_llm:
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": True, "allowed": True
}
mock_resolver.return_value = resolver
llm_instance = MagicMock()
llm.analyze_query_complexity.return_value = QueryComplexity.SIMPLE
async def mock_stream_error(**kwargs):
raise Exception("LLM API error")
llm.stream_completion = mock_stream_error
mock_llm.return_value = llm_instance
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
assert result["success"] is False
assert "error" in result
# ============================================================================
# Test: WebSocket Streaming
# ============================================================================
class TestWebSocketStreaming:
"""Tests for WebSocket token delivery"""
@pytest.mark.asyncio
async def test_websocket_sends_start_message(self, mock_autonomous_agent, mock_byok_handler, mock_websocket_manager, db_session):
"""WebSocket sends streaming:start message"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager', mock_websocket_manager):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
stream=True
)
assert result["success"] is True
# Verify start message was sent
mock_websocket_manager.broadcast.assert_any_call(
"user:user_123",
{
"type": "streaming:start",
"id": result["message_id"],
"model": "gpt-4",
"provider": "openai",
"agent_id": mock_autonomous_agent.id,
"agent_name": mock_autonomous_agent.name,
"execution_id": result["execution_id"]
}
)
@pytest.mark.asyncio
async def test_websocket_sends_update_messages(self, mock_autonomous_agent, mock_byok_handler, mock_websocket_manager, db_session):
"""WebSocket sends streaming:update messages for each token"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager', mock_websocket_manager):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
stream=True
)
assert result["success"] is True
# Verify update messages were sent
assert mock_websocket_manager.broadcast.call_count >= 5 # start + 4 tokens + complete
@pytest.mark.asyncio
async def test_websocket_sends_complete_message(self, mock_autonomous_agent, mock_byok_handler, mock_websocket_manager, db_session):
"""WebSocket sends streaming:complete message with full content"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager', mock_websocket_manager):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
stream=True
)
assert result["success"] is True
# Verify complete message was sent
complete_calls = [
call for call in mock_websocket_manager.broadcast.call_args_list
if "streaming:complete" in str(call)
]
assert len(complete_calls) > 0
@pytest.mark.asyncio
async def test_websocket_skipped_when_stream_false(self, mock_autonomous_agent, mock_byok_handler, mock_websocket_manager, db_session):
"""No WebSocket messages when stream=False"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager', mock_websocket_manager):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
stream=False
)
assert result["success"] is True
# Verify no WebSocket calls when stream=False
mock_websocket_manager.broadcast.assert_not_called()
# ============================================================================
# Test: Chat History Persistence
# ============================================================================
class TestChatHistoryPersistence:
"""Tests for chat history saving"""
@pytest.mark.asyncio
async def test_chat_session_created_on_execution(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""New chat session is created if none provided"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
session_id=None
)
assert result["success"] is True
assert "session_id" in result
@pytest.mark.asyncio
async def test_messages_saved_to_chat_history(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""User and assistant messages are saved to chat history"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="Hello world",
user_id="user_123"
)
assert result["success"] is True
assert result["response"] == "Hello world!"
@pytest.mark.asyncio
async def test_chat_history_persistence_error_doesnt_fail_execution(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Execution succeeds even if chat history persistence fails"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.get_chat_history_manager') as mock_history:
mock_history.side_effect = Exception("Chat history DB error")
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": True, "allowed": True
}
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
# Execution should succeed despite chat history error
assert result["success"] is True
@pytest.mark.asyncio
async def test_existing_session_reused_for_continuity(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Existing session_id is reused for conversation continuity"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
existing_session_id = "test_session_123"
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
session_id=existing_session_id
)
assert result["success"] is True
assert result["session_id"] == existing_session_id
# ============================================================================
# Test: Agent Execution Audit Trail
# ============================================================================
class TestAgentExecutionAuditTrail:
"""Tests for AgentExecution records"""
@pytest.mark.asyncio
async def test_agent_execution_record_created(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""AgentExecution record is created on execution start"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
stream=False
)
# Verify AgentExecution record was created
execution = db_session.query(AgentExecution).filter(
AgentExecution.agent_id == mock_autonomous_agent.id
).first()
assert execution is not None
assert execution.status == "completed"
assert execution.agent_name == mock_autonomous_agent.name
@pytest.mark.asyncio
async def test_execution_record_updated_on_completion(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""AgentExecution status updated to completed with output data"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
# Verify record updated with completion data
execution = db_session.query(AgentExecution).filter(
AgentExecution.agent_id == mock_autonomous_agent.id
).first()
assert execution.status == "completed"
assert execution.output_data is not None
assert execution.output_data["response"] == "Hello world!"
assert execution.output_data["tokens"] == 4
assert execution.duration_ms > 0
assert execution.end_time is not None
@pytest.mark.asyncio
async def test_execution_record_marked_failed_on_error(self, mock_autonomous_agent, db_session):
"""AgentExecution marked as failed on execution error"""
with patch('core.agent_execution_service.LLMService') as mock_llm:
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": True, "allowed": True
}
mock_resolver.return_value = resolver
llm_instance = MagicMock()
llm.analyze_query_complexity.return_value = QueryComplexity.SIMPLE
async def mock_stream_error(**kwargs):
raise Exception("LLM API failure")
llm.stream_completion = mock_stream_error
mock_llm.return_value = llm_instance
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
# Verify failure recorded
execution = db_session.query(AgentExecution).filter(
AgentExecution.agent_id == mock_autonomous_agent.id
).first()
assert execution is not None
assert execution.status == "failed"
assert execution.error_message is not None
@pytest.mark.asyncio
async def test_execution_metadata_includes_governance_context(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Execution metadata includes governance check details"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolution_context = {"resolution_path": ["explicit_agent_id"]}
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, resolution_context)
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": True, "allowed": True, "maturity_level": "AUTONOMOUS"
}
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
# Verify metadata includes governance context
execution = db_session.query(AgentExecution).filter(
AgentExecution.agent_id == mock_autonomous_agent.id
).first()
assert execution is not None
assert execution.metadata is not None
assert "governance_check" in execution.metadata
# ============================================================================
# Test: Episode Creation Triggering
# ============================================================================
class TestEpisodeCreationTriggering:
"""Tests for episode creation after execution"""
@pytest.mark.asyncio
async def test_episode_creation_triggered_after_execution(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Episode creation is triggered after successful execution"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.trigger_episode_creation') as mock_episode:
mock_episode.return_value = None
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": True, "allowed": True
}
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
# Verify episode creation was triggered
mock_episode.assert_called_once()
@pytest.mark.asyncio
async def test_episode_creation_error_doesnt_fail_execution(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Execution succeeds even if episode creation fails"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.trigger_episode_creation') as mock_episode:
mock_episode.side_effect = Exception("Episode service error")
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": True, "allowed": True
}
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
# Execution should succeed despite episode error
assert result["success"] is True
@pytest.mark.asyncio
async def test_episode_creation_with_session_context(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Episode creation includes session and agent context"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.trigger_episode_creation') as mock_episode:
mock_episode.return_value = None
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": True, "allowed": True
}
mock_resolver.return_value = resolver
session_id = "test_session_456"
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
session_id=session_id
)
# Verify episode creation called with correct context
mock_episode.assert_called_once()
call_args = mock_episode.call_args
assert call_args[1]["session_id"] == session_id
assert call_args[1]["agent_id"] == mock_autonomous_agent.id
@pytest.mark.asyncio
async def test_episode_creation_for_governance_blocked_execution(self, mock_student_agent, db_session):
"""Episode creation not triggered for governance-blocked executions"""
with patch('core.agent_execution_service.trigger_episode_creation') as mock_episode:
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_student_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": False,
"allowed": False,
"reason": "STUDENT agent blocked"
}
mock_resolver.return_value = resolver
result = await execute_agent_chat(
agent_id=mock_student_agent.id,
message="test",
user_id="user_123"
)
# Episode creation should not be triggered for blocked executions
mock_episode.assert_not_called()
# ============================================================================
# Test: Error Handling
# ============================================================================
class TestErrorHandling:
"""Tests for error scenarios"""
@pytest.mark.asyncio
async def test_llm_failure_caught_and_logged(self, mock_autonomous_agent, db_session):
"""LLM provider failures are caught and returned as errors"""
with patch('core.agent_execution_service.LLMService') as mock_llm:
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action.return_value = {
"proceed": True, "allowed": True
}
mock_resolver.return_value = resolver
llm_instance = MagicMock()
llm.analyze_query_complexity.return_value = QueryComplexity.SIMPLE
async def mock_stream_error(**kwargs):
raise Exception("OpenAI API timeout")
llm.stream_completion = mock_stream_error
mock_llm.return_value = llm_instance
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
assert result["success"] is False
assert "OpenAI API timeout" in result["error"]
@pytest.mark.asyncio
async def test_database_connection_error_returns_error_response(self, mock_autonomous_agent, db_session, monkeypatch):
"""Database connection errors are handled gracefully"""
# Simulate DB error by breaking session
with patch('core.agent_execution_service.SessionLocal') as mock_db:
mock_db.side_effect = Exception("Database connection failed")
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123"
)
# Should handle DB error gracefully
# May succeed without governance or fail gracefully
assert "success" in result or "error" in result
@pytest.mark.asyncio
async def test_websocket_disconnection_doesnt_affect_execution(self, mock_autonomous_agent, mock_byok_handler, db_session):
"""Execution completes even if WebSocket disconnects"""
with patch('core.agent_execution_service.LLMService', return_value=mock_llm_service):
with patch('core.agent_execution_service.ws_manager') as mock_ws:
# Simulate WebSocket error
mock_ws.broadcast.side_effect = Exception("WebSocket disconnected")
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_autonomous_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
# WebSocket error should propagate
try:
result = await execute_agent_chat(
agent_id=mock_autonomous_agent.id,
message="test",
user_id="user_123",
stream=True
)
# If it succeeds, that's okay too (WS errors are logged)
assert result["success"] is True or "error" in result
except Exception as e:
# WebSocket disconnection may raise exception
assert "WebSocket" in str(e)
# ============================================================================
# Test: Sync Execution Wrapper
# ============================================================================
class TestSyncExecutionWrapper:
"""Tests for execute_agent_chat_sync()"""
def test_sync_wrapper_creates_event_loop(self):
"""Sync wrapper creates event loop if none exists"""
with patch('core.agent_execution_service.LLMService') as mock_llm:
with patch('core.agent_execution_service.ws_manager'):
with patch('core.agent_execution_service.AgentContextResolver') as mock_resolver:
# Mock agent
mock_agent = MagicMock()
mock_agent.id = "test_agent"
mock_agent.name = "TestAgent"
resolver = MagicMock()
resolver.resolve_agent_for_request = AsyncMock(
return_value=(mock_agent, {})
)
resolver.governance = MagicMock()
resolver.governance.can_perform_action = MagicMock(
return_value={"proceed": True, "allowed": True}
)
mock_resolver.return_value = resolver
llm_instance = MagicMock()
llm.analyze_query_complexity.return_value = QueryComplexity.SIMPLE
llm.get_optimal_provider.return_value = ("openai", "gpt-4")
async def mock_stream(**kwargs):
yield "Sync response"
llm.stream_completion = mock_stream
mock_llm.return_value = llm_instance
result = execute_agent_chat_sync(
agent_id="test_agent",
message="test message",
user_id="user_123",
stream=False
)
assert "success" in result or "error" in result
def test_sync_wrapper_disables_streaming(self):
"""Sync wrapper forces stream=False regardless of input"""
with patch('core.agent_execution_service.execute_agent_chat') as mock_execute:
mock_execute.return_value = {"success": True, "response": "test"}
result = execute_agent_chat_sync(
agent_id="test_agent",
message="test",
user_id="user_123",
stream=True # Should be ignored
)
# Verify execute_agent_chat called with stream=False
mock_execute.assert_called_once()
call_kwargs = mock_execute.call_args[1]
assert call_kwargs["stream"] is False
def test_sync_wrapper_reuses_existing_event_loop(self):
"""Sync wrapper reuses existing event loop"""
import asyncio
# Create event loop
loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
try:
with patch('core.agent_execution_service.execute_agent_chat') as mock_execute:
mock_execute.return_value = {"success": True, "response": "test"}
result = execute_agent_chat_sync(
agent_id="test_agent",
message="test",
user_id="user_123"
)
assert result["success"] is True
finally:
loop.close()
def test_sync_wrapper_propagates_execution_result(self):
"""Sync wrapper returns full execution result"""
with patch('core.agent_execution_service.execute_agent_chat') as mock_execute:
mock_execute.return_value = {
"success": True,
"execution_id": "exec_123",
"response": "Test response",
"tokens": 2,
"provider": "openai",
"model": "gpt-4"
}
result = execute_agent_chat_sync(
agent_id="test_agent",
message="test",
user_id="user_123"
)
assert result["success"] is True
assert result["execution_id"] == "exec_123"
assert result["response"] == "Test response"
|