Spaces:
Paused
Paused
File size: 11,334 Bytes
4ae946d | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 | #!/usr/bin/env python3
"""
Security Audit for Authentication Flow
Analyzes authentication implementation for security vulnerabilities
"""
import json
import os
import re
from datetime import datetime
from typing import Any, Dict, List
class AuthSecurityAuditor:
"""Security auditor for authentication systems"""
def __init__(self):
self.findings = []
self.risk_levels = {"critical": [], "high": [], "medium": [], "low": []}
def audit_file(self, file_path: str, content: str) -> None:
"""Audit a single file for authentication security issues"""
filename = os.path.basename(file_path)
# Backend authentication service audit
if "auth" in filename.lower() and file_path.endswith((".py", ".ts")):
self._audit_backend_auth(file_path, content)
elif "client" in filename.lower() and file_path.endswith((".ts", ".tsx")):
self._audit_frontend_client(file_path, content)
def _audit_backend_auth(self, file_path: str, content: str) -> None:
"""Audit backend authentication code"""
# Check for hardcoded secrets
if re.search(r"(password|secret|key).*=\s*['\"][^'\"]*['\"]", content, re.IGNORECASE):
if not any(word in content.lower() for word in ["hash", "bcrypt", "argon2", "pbkdf2"]):
self._add_finding(
"high",
"Potential hardcoded credentials",
file_path,
"Found what appears to be hardcoded password/secret/key",
)
# Check for weak password policies
if "password" in content.lower():
if not re.search(r"min.*length|strength|complexity", content, re.IGNORECASE):
self._add_finding(
"medium", "Weak password policy", file_path, "No apparent password strength requirements found"
)
# Check for proper hashing
if "hash" in content.lower():
if not any(algo in content.lower() for algo in ["argon2", "bcrypt", "pbkdf2", "scrypt"]):
self._add_finding(
"high",
"Weak password hashing",
file_path,
"No secure password hashing algorithm (Argon2, bcrypt, PBKDF2, scrypt) detected",
)
# Check for token expiration
if "token" in content.lower():
if not re.search(r"exp|expire|timeout", content, re.IGNORECASE):
self._add_finding(
"medium", "Missing token expiration", file_path, "JWT tokens should have expiration times"
)
# Check for MFA implementation
if "mfa" in content.lower() or "2fa" in content.lower():
if not re.search(r"totp|otp|pyotp", content, re.IGNORECASE):
self._add_finding(
"medium",
"Incomplete MFA implementation",
file_path,
"MFA mentioned but no TOTP/OTP implementation found",
)
# Check for account lockout
if "login" in content.lower():
if not re.search(r"lock|attempt|brute", content, re.IGNORECASE):
self._add_finding(
"medium",
"No account lockout protection",
file_path,
"No apparent brute force protection via account lockout",
)
# Check for secure cookie settings
if "cookie" in content.lower():
if not re.search(r"httponly|secure|samesite", content, re.IGNORECASE):
self._add_finding(
"high", "Insecure cookie settings", file_path, "Cookies should be HttpOnly, Secure, and SameSite"
)
# Check for proper error handling
if "except" in content:
if re.search(r"password.*except|auth.*except", content, re.IGNORECASE):
if not re.search(r"log|security|alert", content, re.IGNORECASE):
self._add_finding(
"medium",
"Insufficient auth error handling",
file_path,
"Authentication errors should be logged for security monitoring",
)
def _audit_frontend_client(self, file_path: str, content: str) -> None:
"""Audit frontend client code"""
# Check for token storage security
if "localStorage" in content:
if re.search(r"token|auth", content, re.IGNORECASE):
self._add_finding(
"high",
"Insecure token storage",
file_path,
"Authentication tokens stored in localStorage are vulnerable to XSS",
)
# Check for proper token handling
if "token" in content.lower():
if not re.search(r"refresh|renew|expire", content, re.IGNORECASE):
self._add_finding("medium", "Missing token refresh", file_path, "No apparent token refresh mechanism")
# Check for credential exposure
if re.search(r"password|secret|key.*=.*['\"]", content, re.IGNORECASE):
self._add_finding(
"critical",
"Credentials in client code",
file_path,
"Client-side code should not contain credentials or secrets",
)
def _add_finding(self, risk: str, title: str, file: str, description: str) -> None:
"""Add a security finding"""
finding = {
"risk": risk,
"title": title,
"file": file,
"description": description,
"timestamp": datetime.now().isoformat(),
}
self.findings.append(finding)
self.risk_levels[risk].append(finding)
def generate_report(self) -> Dict[str, Any]:
"""Generate comprehensive security audit report"""
return {
"audit_timestamp": datetime.now().isoformat(),
"total_findings": len(self.findings),
"findings_by_risk": {risk: len(findings) for risk, findings in self.risk_levels.items()},
"findings": self.findings,
"recommendations": self._generate_recommendations(),
}
def _generate_recommendations(self) -> List[str]:
"""Generate security recommendations based on findings"""
recommendations = []
if self.risk_levels["critical"]:
recommendations.append(
"CRITICAL: Address all critical findings immediately - these pose immediate security risks"
)
if any(f["title"] == "Insecure token storage" for f in self.risk_levels["high"]):
recommendations.append("HIGH: Move authentication tokens from localStorage to HttpOnly cookies")
if any("password hashing" in f["title"] for f in self.risk_levels["high"]):
recommendations.append("HIGH: Implement secure password hashing (Argon2 recommended)")
if any("MFA" in f["title"] for f in self.risk_levels["medium"]):
recommendations.append("MEDIUM: Implement proper MFA using TOTP standard")
if any("lockout" in f["title"] for f in self.risk_levels["medium"]):
recommendations.append("MEDIUM: Implement account lockout protection against brute force attacks")
if not recommendations:
recommendations.append("β
No critical security issues found in authentication flow")
return recommendations
def main():
"""Main audit function"""
auditor = AuthSecurityAuditor()
# Audit backend auth files
backend_auth_files = [
"app/modules/auth/service.py",
"app/modules/auth/router.py",
"app/services/infrastructure/auth_service.py",
]
for file_path in backend_auth_files:
full_path = f"{file_path}"
if os.path.exists(full_path):
try:
with open(full_path, "r", encoding="utf-8") as f:
content = f.read()
auditor.audit_file(full_path, content)
print(f"β
Audited: {file_path}")
except Exception as e:
print(f"β Failed to audit {file_path}: {e}")
else:
print(f"β οΈ File not found: {file_path}")
# Audit frontend auth files
frontend_auth_files = [
"../frontend/src/shared/api/client.ts",
"../frontend/src/shared/api/interceptors.ts",
"../frontend/src/features/auth/services/auth.ts",
]
for file_path in frontend_auth_files:
if os.path.exists(file_path):
try:
with open(file_path, "r", encoding="utf-8") as f:
content = f.read()
auditor.audit_file(file_path, content)
print(f"β
Audited: {file_path}")
except Exception as e:
print(f"β Failed to audit {file_path}: {e}")
else:
print(f"β οΈ File not found: {file_path}")
# Audit frontend auth files
frontend_auth_files = [
"src/shared/api/client.ts",
"src/shared/api/interceptors.ts",
"src/features/auth/services/auth.ts",
]
for file_path in frontend_auth_files:
full_path = f"frontend/{file_path}"
if os.path.exists(full_path):
try:
with open(full_path, "r", encoding="utf-8") as f:
content = f.read()
auditor.audit_file(full_path, content)
print(f"β
Audited: {file_path}")
except Exception as e:
print(f"β Failed to audit {file_path}: {e}")
else:
print(f"β οΈ File not found: {file_path}")
# Generate report
report = auditor.generate_report()
print("\n" + "=" * 80)
print("π AUTHENTICATION SECURITY AUDIT REPORT")
print("=" * 80)
print("\nπ SUMMARY:")
print(f"Total findings: {report['total_findings']}")
print(f"Critical: {report['findings_by_risk']['critical']}")
print(f"High: {report['findings_by_risk']['high']}")
print(f"Medium: {report['findings_by_risk']['medium']}")
print(f"Low: {report['findings_by_risk']['low']}")
print("\nπ§ RECOMMENDATIONS:")
for rec in report["recommendations"]:
print(f"β’ {rec}")
if report["findings"]:
print("\nπ¨ DETAILED FINDINGS:")
for finding in report["findings"]:
print(f"\n[{finding['risk'].upper()}] {finding['title']}")
print(f"File: {finding['file']}")
print(f"Description: {finding['description']}")
# Save detailed report
report_file = "auth_security_audit_report.json"
with open(report_file, "w") as f:
json.dump(report, f, indent=2)
print(f"\nπ Detailed report saved to: {report_file}")
# Exit with error code if critical issues found
if report["findings_by_risk"]["critical"] > 0:
print("\nβ CRITICAL SECURITY ISSUES FOUND!")
exit(1)
elif report["findings_by_risk"]["high"] > 0:
print("\nβ οΈ HIGH PRIORITY SECURITY ISSUES FOUND!")
exit(1)
else:
print("\nβ
AUTHENTICATION SECURITY AUDIT PASSED!")
exit(0)
if __name__ == "__main__":
main()
|