Update app.py

app.py

@@ -1344,12 +1344,13 @@ def create_clip(media_asset, tts_path, estimated_duration, target_resolution,
             color="red",
             align='center',
             size=(target_resolution[0] * 0.9, None)
-        ).set_position('center').set_duration(error_duration)
+        ).set_position('center').set_duration(black_clip.duration) # Error text duration matches placeholder
         clip = CompositeVideoClip([black_clip, error_txt_clip])
-        silent_audio_path = generate_silent_audio(error_duration)
+        silent_audio_path = generate_silent_audio(clip.duration) # Generate silent audio matching placeholder duration
         if silent_audio_path and os.path.exists(silent_audio_path):
             try:
-                clip = clip.set_audio(AudioFileClip(silent_audio_path))
+                # Use the actual placeholder clip duration for silent audio
+                clip = clip.set_audio(AudioFileClip(silent_audio_path).subclip(0, clip.duration))
             except Exception as audio_e:
                  print(f"Error setting silent audio for error clip {segment_index}: {audio_e}")
                  clip = clip.set_audio(None)
@@ -1728,12 +1729,36 @@ def generate_script_and_show_editor(user_input, resolution_choice,
           )
 
 
-def generate_video_from_edited(run_config, segments_data, segment_texts, segment_uploads, bg_music_volume):
+# Update generate_video_from_edited to accept the unpacked dynamic arguments
+# It will receive: run_config_val, segments_data_val, then MAX_SEGMENTS_FOR_EDITING text values,
+# then MAX_SEGMENTS_FOR_EDITING file values, then bg_music_volume_val.
+def generate_video_from_edited(run_config_val, segments_data_val, *dynamic_segment_inputs, bg_music_volume_val):
     """
     Takes the edited segment data (text, uploaded files) and configuration,
     and generates the final video.
     Uses yield to update status.
     """
+    # Re-pack the dynamic inputs into lists
+    # dynamic_segment_inputs contains all text and file inputs from the UI, in order.
+    # The first MAX_SEGMENTS_FOR_EDITING are text inputs, the next MAX_SEGMENTS_FOR_EDITING are file inputs.
+    num_dynamic_per_segment = 2 # Textbox and File
+    expected_dynamic_count = MAX_SEGMENTS_FOR_EDITING * num_dynamic_per_segment
+
+    if len(dynamic_segment_inputs) != expected_dynamic_count:
+         print(f"Error: Expected {expected_dynamic_count} dynamic inputs, but received {len(dynamic_segment_inputs)}.")
+         yield "Error: Mismatch in segment inputs received. Please regenerate script.", None
+         return # Cannot proceed with incorrect inputs
+
+    segment_texts = list(dynamic_segment_inputs[:MAX_SEGMENTS_FOR_EDITING])
+    segment_uploads = list(dynamic_segment_inputs[MAX_SEGMENTS_FOR_EDITING:])
+
+
+    # Now use the re-packed lists and the correctly named arguments
+    run_config = run_config_val
+    segments_data = segments_data_val
+    bg_music_volume = bg_music_volume_val
+
+
     if not segments_data:
         yield "No segments to process. Generate script first.", None
         return
@@ -1752,7 +1777,7 @@ def generate_video_from_edited(run_config, segments_data, segment_texts, segment
          TEMP_FOLDER = None # Reset global
          return
 
-    # Extract config from run_config
+    # Extract other config from run_config
     TARGET_RESOLUTION = run_config.get("resolution", (1920, 1080)) # Default if missing
     CAPTION_ENABLED = run_config.get("caption_enabled", True) # Default if missing
     CAPTION_COLOR = run_config.get("caption_color", "#FFFFFF") # Default if missing
@@ -1845,7 +1870,7 @@ def generate_video_from_edited(run_config, segments_data, segment_texts, segment
                  placeholder_clip = placeholder_clip.set_audio(AudioFileClip(silent_audio_path))
             error_text = f"Segment {idx+1} Failed"
             if segment.get('text'): error_text += f":\n{segment['text'][:50]}..."
-            error_txt_clip = TextClip(error_text, fontsize=30, color="red", align='center', size=(TARGET_RESOLUTION[0] * 0.9, None)).set_position('center').set_duration(placeholder_clip.duration)
+            error_txt_clip = TextClip(error_text, fontsize=30, color="red", align='center', size=(TARGET_RESOLUTION[0] * 0.9, None)).set_position('center').set_duration(placeholder_clip.duration) # Error text duration matches placeholder
             placeholder_clip = CompositeVideoClip([placeholder_clip, error_txt_clip])
             clips.append(placeholder_clip)
 
@@ -2045,14 +2070,16 @@ with gr.Blocks() as demo:
     )
 
     # Generate Video Button Click
+    # Inputs must match the definition of generate_video_from_edited
     generate_video_btn.click(
         fn=generate_video_from_edited,
         inputs=[
-            run_config_state, # Pass run config (includes music path now)
-            segments_state, # Pass the original parsed segments data (needed for original_prompt and duration)
-            *segment_text_inputs, # Pass list of edited text values
-            *segment_file_inputs, # Pass list of uploaded file paths
-            bg_music_volume_slider # Pass background music volume
+            run_config_state, # 1st arg
+            segments_state, # 2nd arg
+            # All segment text and file inputs will be collected by *dynamic_segment_inputs
+            *segment_text_inputs,
+            *segment_file_inputs,
+            bg_music_volume_slider # Last arg
         ],
         outputs=[status_output, final_video_output] # Yield status updates and final video
     )
@@ -2077,3 +2104,4 @@ if __name__ == "__main__":
         print("Warning: OPENROUTER_API_KEY is not configured. Script generation will fail.")
 
     demo.launch(share=True) # Set share=True to get a public link
+