fix(mcp+pipeline): share demos with operator + harden data-quality consumers

- mcp_server: every MCP build shares the created model + liveboard with the operator
(MCP_SHARE_WITH, default mike.boone@thoughtspot.com) so demos are visible no matter
who ran them. Owner unchanged — the build still authenticates AS owner_email, so the
caller passed in owns the objects.
- blueprint.from_dict: drop non-numeric seasonal `monthly` params too (line 261) — the
merged author can emit a dict there like it did for params.
- engine + validator: _safe_date() tolerates a non-ISO insight window bound (e.g. the
LLM token 'relative_minus_8_months') instead of crashing on date.fromisoformat — the
second merge bug that failed Cloudscape.

Root theme: the merged blueprint author emits richer output than the parser/engine
expected; harden the consumers to tolerate it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

demoprep_app/dataset/engine.py

@@ -31,6 +31,18 @@ from demoprep_app.scenario.blueprint import (
 from demoprep_app.scenario.contract import DimensionSpec, ScenarioContract
 
 
+def _safe_date(value):
+    """Parse an ISO date; return None if missing or not a valid ISO string (e.g. an
+    LLM-invented relative token like 'relative_minus_8_months'), so a bad insight
+    window bound is skipped rather than crashing dataset generation."""
+    if not value:
+        return None
+    try:
+        return date.fromisoformat(value)
+    except (ValueError, TypeError):
+        return None
+
+
 class BlueprintEngine:
     """Deterministic executor for DemoBlueprint -> DatasetBundle."""
 
@@ -276,9 +288,11 @@ def _insight_multiplier(entries, picked: dict[str, str], d: date) -> float:
     for i, effmult in entries:
         if i.insight_type != "seasonal_spike" and picked.get(i.dimension) != i.dimension_value:
             continue
-        if i.window_start and d < date.fromisoformat(i.window_start):
+        _ws = _safe_date(i.window_start)
+        if _ws and d < _ws:
             continue
-        if i.window_end and d > date.fromisoformat(i.window_end):
+        _we = _safe_date(i.window_end)
+        if _we and d > _we:
             continue
         mult *= effmult
     return mult

demoprep_app/dataset/validator.py

@@ -145,6 +145,18 @@ def _row_date(row: dict[str, Any]) -> date | None:
     return None
 
 
+def _safe_date(value):
+    """Parse an ISO date; return None if missing or not a valid ISO string (e.g. an
+    LLM-invented relative token), so a bad insight window bound is ignored rather than
+    crashing validation."""
+    if not value:
+        return None
+    try:
+        return date.fromisoformat(value)
+    except (ValueError, TypeError):
+        return None
+
+
 def _check_insight(
     blueprint: DemoBlueprint,
     insight: PlantedInsight,
@@ -155,8 +167,8 @@ def _check_insight(
     laggard = promised < 1.0
     required = 1.0 + (promised - 1.0) * MIN_REALIZED_FRACTION  # works for both directions
 
-    start = date.fromisoformat(insight.window_start) if insight.window_start else None
-    end = date.fromisoformat(insight.window_end) if insight.window_end else None
+    start = _safe_date(insight.window_start)
+    end = _safe_date(insight.window_end)
 
     def in_window(d: date | None) -> bool:
         if d is None:

demoprep_app/scenario/blueprint.py

@@ -259,7 +259,8 @@ class DemoBlueprint:
 
         seas_raw = raw.get("seasonality") or {}
         seasonality = Seasonality(
-            monthly={int(k): float(v) for k, v in (seas_raw.get("monthly") or {}).items()},
+            monthly={int(k): float(v) for k, v in (seas_raw.get("monthly") or {}).items()
+                     if str(k).lstrip("-").isdigit() and isinstance(v, (int, float)) and not isinstance(v, bool)},
             trend_pct_per_year=float(seas_raw.get("trend_pct_per_year", 6.0) or 0.0),
             narrative=[str(s) for s in (seas_raw.get("narrative") or [])],
         )

mcp_server.py

@@ -366,6 +366,11 @@ def _run_build(run_id: str, brief: str, company_name: str, use_case: str, compan
         controller.settings["model"] = controller.settings.get("model") or DEFAULT_LLM_MODEL
         controller.settings["thoughtspot_url"] = ts_target_url
         controller.settings["thoughtspot_trusted_auth_key"] = ts_auth_key
+        # Always share the created model + liveboard with the operator, so every demo is
+        # visible no matter who ran it. The OWNER is unchanged — whoever was passed as
+        # owner_email (the build authenticates AS that user, so they own the objects);
+        # this just adds the operator as a viewer. Override target via MCP_SHARE_WITH.
+        controller.settings["share_with"] = os.getenv("MCP_SHARE_WITH", "mike.boone@thoughtspot.com")
 
         # vertical / function / use_case_config exactly as the runner does
         controller.vertical, controller.function = parse_use_case(use_case or "")