Update app.py

app.py

@@ -105,31 +105,64 @@ import httpx
 import tempfile
 import asyncio
 
+# async def download_file_from_url(url: str, retries: int = 3, delay: float = 2.0) -> str | None:
+#     """
+#     Downloads a file from a URL and returns the path to a temporary file.
+#     Retries on failure up to `retries` times, waiting `delay` seconds between attempts.
+#     Returns None if all attempts fail.
+#     """
+#     for attempt in range(1, retries + 1):
+#         try:
+#             async with httpx.AsyncClient(timeout=60.0) as client:  # increased timeout
+#                 response = await client.get(url)
+#                 response.raise_for_status()  # raises for non-200 status codes
+
+#             # Save to a temporary file
+#             temp_file = tempfile.NamedTemporaryFile(delete=False, suffix=".wav")
+#             temp_file.write(response.content)
+#             temp_file.close()
+#             print(f"Downloaded {url} successfully on attempt {attempt}")
+#             return temp_file.name
+
+#         except Exception as e:
+#             print(f"Attempt {attempt} failed for {url}: {e}")
+#             if attempt < retries:
+#                 await asyncio.sleep(delay)  # wait before retrying
+
+#     print(f"All {retries} attempts failed for {url}")
+#     return None
+
+download_cache = {}
+
 async def download_file_from_url(url: str, retries: int = 3, delay: float = 2.0) -> str | None:
     """
     Downloads a file from a URL and returns the path to a temporary file.
-    Retries on failure up to `retries` times, waiting `delay` seconds between attempts.
-    Returns None if all attempts fail.
+    If download fails after `retries` attempts, returns None instead of raising an error.
+    Caches successful downloads to avoid repeated requests.
     """
+    if url in download_cache:
+        print(f"{url} is got from cache")
+        return download_cache[url]
+    
     for attempt in range(1, retries + 1):
         try:
-            async with httpx.AsyncClient(timeout=60.0) as client:  # increased timeout
+            async with httpx.AsyncClient(timeout=60.0) as client:
                 response = await client.get(url)
-                response.raise_for_status()  # raises for non-200 status codes
+                response.raise_for_status()
 
-            # Save to a temporary file
             temp_file = tempfile.NamedTemporaryFile(delete=False, suffix=".wav")
             temp_file.write(response.content)
             temp_file.close()
-            print(f"Downloaded {url} successfully on attempt {attempt}")
+
+            download_cache[url] = temp_file.name
             return temp_file.name
 
         except Exception as e:
             print(f"Attempt {attempt} failed for {url}: {e}")
             if attempt < retries:
-                await asyncio.sleep(delay)  # wait before retrying
+                await asyncio.sleep(delay)
 
-    print(f"All {retries} attempts failed for {url}")
+    print(f"All {retries} attempts failed for {url}, skipping...")
     return None
 
 #-----------------------------------------------------------
@@ -242,9 +275,12 @@ async def concat_story_audio(story: StoryCreationDTO, base_output: str, final_pa
             # --- Add SFX for location if available ---
             if scene.location.path:
                 sfx_file = await download_file_from_url(scene.location.path)
-                sfx_audio = AudioSegment.from_wav(sfx_file)
-                scene_audio = scene_audio.overlay(sfx_audio)
-                os.remove(sfx_file)
+                if sfx_file:
+                    sfx_audio = AudioSegment.from_wav(sfx_file)
+                    scene_audio = scene_audio.overlay(sfx_audio)
+                    os.remove(sfx_file)
+                else:
+                    print(f"SFX skipped for {scene.location.locationName}")
 
             # --- Add background music if available ---
             if scene.bgMusic and scene.bgMusic.musicPath: