Update app.py

app.py

@@ -1,78 +1,83 @@
 import os
 import random
-import cv2
 import gradio as gr
 from PIL import Image
 import numpy as np
-from datasets import load_dataset
 
-def generate_and_delete_word_image(word):
-    """Generates a combined image, displays it, and deletes it afterward.
+import cv2
+
+
+def generate_and_display_word_image(word):
+  
+    """Generates a combined image using the Reticular method and displays it in a secure manner.
+
     Args:
-        word: The user-provided word (uppercase).
+        word (str): The user-provided word (uppercase).
+
     Returns:
-        The image data for displaying.
+        None: The function displays the image using Gradio and doesn't return a value.
     """
+    
+    # Securely access dataset using environment variables (replace with actual names)
+    dataset_dir = os.getenv("udayjawheri/Random_Word_Genrator/dataset/")
+    if not dataset_dir:
+        raise ValueError("Environment variable WORD_IMAGE_DATASET_DIR not set!")
 
-    # Load the dataset
-    dataset = load_dataset("udayjawheri/0-9_A-Z_Dataset")
-
-    # Initialize an empty list to store the resized images
     resized_images = []
-
-    # Iterate over each letter in the word
     for letter in word:
-        # Get the corresponding folder for the letter
-        letter_folder = dataset[letter]
+        letter_folder_path = os.path.join(dataset_dir, letter)
 
-        # Check if the folder exists
-        if not letter_folder:
-            print("Folder not found for the letter:", letter)
+        # Validate folder existence to prevent potential path traversal attacks
+        if not os.path.isdir(letter_folder_path):
+            print(f"Folder not found for letter: {letter}")
             continue
 
-        # Get the list of images in the folder
-        images_in_folder = list(letter_folder)
+        images_in_folder = [img for img in os.listdir(letter_folder_path)
+                           if img.endswith(".jpg") or img.endswith(".png")]
 
-        # Check if there are any images in the folder
         if not images_in_folder:
-            print("No images found for the letter:", letter)
+            print(f"No images found for letter: {letter}")
             continue
 
-        # Randomly select an image from the folder
-        random_image = random.choice(images_in_folder)
-
-        # Load the image using PIL, ensuring RGB mode
-        image = Image.open(random_image).convert("RGB")
-
-        # Resize the image to 250x250 pixels
-        resized_image = np.array(image.resize((250, 250)))
+        # Randomly select an image from the folder securely (prevent path traversal)
+        random_image_name = random.choice(images_in_folder)
+        validated_image_path = os.path.join(letter_folder_path, random_image_name)
+        # Check if the path falls within the expected dataset directory
+        if not validated_image_path.startswith(dataset_dir):
+            raise ValueError("Invalid image path detected!")
+
+        try:
+            # Load image using PIL, ensuring RGB mode
+            image = Image.open(validated_image_path).convert("RGB")
+            # Convert to NumPy array for OpenCV
+            resized_image = np.array(image.resize((250, 250)))
+        except Exception as e:
+            print(f"Error loading image: {e}")
+            continue
 
-        # Add the resized image to the list
         resized_images.append(resized_image)
 
-    # Check if any images were found for the word
     if not resized_images:
         print("No images found for the input word.")
-        return None
+        return
 
-    # Concatenate the resized images horizontally
     concatenated_image = cv2.hconcat(resized_images)
 
-    # Return the concatenated image
-    return concatenated_image
+    # Display the concatenated image using Gradio (avoids saving/deleting)
+    interface.image = concatenated_image
 
 # Gradio interface with clear explanations
 interface = gr.Interface(
-    fn=generate_and_delete_word_image,
+    fn=generate_and_display_word_image,
     inputs="text",  # User input for the word
-    outputs="image",  # Output as an image
-    title="POCKET RANDOM NOTE GENERATOR", # Title
-    description="Randsomator allows you to generate random ranson with one click.",
-    
+    outputs="image",  # Output as an image displayed in Gradio
+    title="POCKET RANDOM NOTE GENERATOR",  # Title
+    description="Generates random notes using letter images.",
+
     css="""
-      botton {
-      background: green;
-      color: #32B531
+      button {
+        background: green;
+        color: #32B531
       }
       body {
         background-color: black;
@@ -83,8 +88,7 @@ interface = gr.Interface(
         margin-bottom: 10px;
       }
     """,
-    
 )
 
-
+# Launch the Gradio interface
 interface.launch(share=True)