Update app.py

app.py

@@ -1,4 +1,4 @@
-from flask import Flask, render_template_string, request, jsonify
+from flask import Flask, render_template_string, request, jsonify, send_from_directory, abort
 import os
 import uuid
 import subprocess
@@ -8,9 +8,11 @@ from faster_whisper import WhisperModel
 
 app = Flask(__name__)
 
-UPLOAD_FOLDER = "uploads"
-OUTPUT_FOLDER = "static/videos"
-SUBTITLE_FOLDER = "subtitles"
+BASE_DIR = os.path.dirname(os.path.abspath(__file__))
+
+UPLOAD_FOLDER = os.path.join(BASE_DIR, "uploads")
+OUTPUT_FOLDER = os.path.join(BASE_DIR, "static", "videos")
+SUBTITLE_FOLDER = os.path.join(BASE_DIR, "subtitles")
 
 os.makedirs(UPLOAD_FOLDER, exist_ok=True)
 os.makedirs(OUTPUT_FOLDER, exist_ok=True)
@@ -169,7 +171,7 @@ video{
 
     <div id="loading">Generating Video...</div>
 
-    <video id="video" controls></video>
+    <video id="video" controls playsinline></video>
 
     <div class="download-btn" id="downloadDiv">
         <a id="downloadBtn" download>Download Video</a>
@@ -249,6 +251,7 @@ def ass_escape(text: str) -> str:
     return text
 
 def escape_ffmpeg_path(path: str) -> str:
+    # For ffmpeg filter strings
     return (
         path
         .replace("\\", "\\\\")
@@ -309,7 +312,7 @@ Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
         wrapped = ass_escape(wrapped)
         wrapped = wrapped.replace("\n", r"\N")
 
-        # Solid black background, white text, no glow/blur
+        # Solid black background, white text
         dialogue = (
             f"Dialogue: 0,{start},{end},Default,,0,0,0,,"
             r"{\bord0\shad0\blur0\1c&HFFFFFF&\3c&H000000&\4c&H000000&\4a&H00}"
@@ -325,6 +328,21 @@ Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
 def home():
     return render_template_string(HTML)
 
+@app.route("/video/<path:filename>")
+def serve_video(filename):
+    file_path = os.path.join(OUTPUT_FOLDER, filename)
+    if not os.path.exists(file_path):
+        abort(404)
+
+    response = send_from_directory(
+        OUTPUT_FOLDER,
+        filename,
+        as_attachment=False,
+        conditional=True
+    )
+    response.headers["Cache-Control"] = "no-store"
+    return response
+
 @app.route("/generate", methods=["POST"])
 def generate():
     if "image" not in request.files or "audio" not in request.files:
@@ -376,39 +394,50 @@ def generate():
         make_ass_subtitles(transcript, ass_path)
         safe_ass_path = escape_ffmpeg_path(os.path.abspath(ass_path))
 
-        # Simple scale/crop + subtitles
+        # Scale/crop image to 9:16 + burn subtitles
         vf = (
             "scale=1080:1920:force_original_aspect_ratio=increase,"
             "crop=1080:1920,"
-            f"subtitles='{safe_ass_path}'"
+            f"ass='{safe_ass_path}'"
         )
 
         cmd = [
             "ffmpeg",
             "-y",
             "-loop", "1",
+            "-framerate", "1",
             "-i", image_path,
             "-i", audio_path,
             "-vf", vf,
+            "-map", "0:v:0",
+            "-map", "1:a:0",
             "-c:v", "libx264",
             "-preset", "ultrafast",
+            "-crf", "20",
             "-pix_fmt", "yuv420p",
             "-r", "24",
             "-c:a", "aac",
             "-b:a", "128k",
+            "-movflags", "+faststart",
             "-shortest",
             output_path
         ]
 
-        subprocess.run(
+        result = subprocess.run(
             cmd,
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,
             check=True
         )
 
+        if not os.path.exists(output_path) or os.path.getsize(output_path) == 0:
+            return jsonify({
+                "error": "Video file not created",
+                "details": "FFmpeg ran but output file is missing or empty."
+            })
+
         return jsonify({
-            "video_url": f"/static/videos/{output_filename}",
+            "video_url": f"/video/{output_filename}",
             "transcript": transcript,
             "full_text": " ".join(full_text_parts).strip(),
             "language": getattr(info, "language", None)
@@ -427,4 +456,4 @@ def generate():
         })
 
 if __name__ == "__main__":
-    app.run(host="0.0.0.0", port=7860)
+    app.run(host="0.0.0.0", port=7860, debug=True)