Update routers/pdf_compressor.py

routers/pdf_compressor.py

@@ -12,7 +12,6 @@ logger = logging.getLogger(__name__)
 
 router = APIRouter()
 
-# Use standard /tmp directory which is always writable in Docker
 TEMP_DIR = "/tmp/conversions"
 os.makedirs(TEMP_DIR, exist_ok=True)
 
@@ -30,7 +29,6 @@ async def compress_pdf(
     file: UploadFile = File(...),
     quality: str = Query("medium", enum=["low", "medium", "high"])
 ):
-    # 1. Check for Ghostscript
     if not shutil.which("gs"):
         logger.error("Ghostscript not found! Please update Dockerfile.")
         raise HTTPException(status_code=500, detail="Server Configuration Error: Ghostscript is not installed.")
@@ -38,7 +36,6 @@ async def compress_pdf(
     if not file.filename.endswith('.pdf'):
         raise HTTPException(status_code=400, detail="Only PDF files are allowed")
 
-    # Create paths
     with tempfile.NamedTemporaryFile(delete=False, suffix='.pdf', dir=TEMP_DIR) as tmp_in:
         input_path = tmp_in.name
     
@@ -46,45 +43,40 @@ async def compress_pdf(
         output_path = tmp_out.name
 
     try:
-        # Write input file
         content = await file.read()
         with open(input_path, 'wb') as f:
             f.write(content)
 
-        # Settings
+        # === FIXED SETTINGS ===
+        # We removed the manual 'Resolution' flags because they conflict
+        # with PDFSETTINGS in Ghostscript v10+, causing the crash.
         settings = {
             "low": {
-                "pdf_settings": "/screen",
+                "pdf_settings": "/screen", # Forces 72 DPI
                 "extra_flags": [
-                    "-dColorImageDownsampleType=/Bicubic",
-                    "-dColorImageResolution=72",
-                    "-dGrayImageDownsampleType=/Bicubic",
-                    "-dGrayImageResolution=72",
-                    "-dAutoFilterColorImages=false",
-                    "-dColorImageFilter=/DCTDecode",
-                    "-dEncodeColorImages=true"
+                    "-dDownsampleColorImages=true",
+                    "-dDownsampleGrayImages=true", 
+                    "-dDownsampleMonoImages=true",
+                    # We remove the explicit resolution numbers to avoid 'rangecheck' errors
                 ]
             },
             "medium": {
-                "pdf_settings": "/ebook",
+                "pdf_settings": "/ebook", # Forces 150 DPI
                 "extra_flags": [
-                    "-dColorImageDownsampleType=/Bicubic",
-                    "-dColorImageResolution=150",
-                    "-dGrayImageDownsampleType=/Bicubic",
-                    "-dGrayImageResolution=150"
+                    "-dDownsampleColorImages=true",
+                    "-dDownsampleGrayImages=true",
+                    "-dDownsampleMonoImages=true",
                 ]
             },
             "high": {
-                "pdf_settings": "/printer",
+                "pdf_settings": "/printer", # Forces 300 DPI
                 "extra_flags": []
             }
         }
 
         selected = settings.get(quality)
 
-        # Build Command
-        # REMOVED "-dQUIET" so we can see errors
-        # ADDED "-dSAFER" for security/compatibility
+        # Construct Command
         cmd = [
             "gs",
             "-dSAFER", 
@@ -96,57 +88,48 @@ async def compress_pdf(
             f"-sOutputFile={output_path}"
         ]
         
+        # Add extra flags
         cmd.extend(selected["extra_flags"])
         cmd.append(input_path)
         
         logger.info(f"Running command: {' '.join(cmd)}")
 
-        # Run Subprocess
-        # Combined stdout and stderr to capture the actual error
+        # Run Ghostscript
         process = subprocess.run(
             cmd, 
             stdout=subprocess.PIPE, 
-            stderr=subprocess.STDOUT, # Merge stderr into stdout
+            stderr=subprocess.STDOUT, # Merge output to catch errors
             text=True
         )
         
-        # Log the output regardless of success/failure for debugging
-        if process.stdout:
-            logger.info(f"GS Output: {process.stdout[:500]}...") # Log first 500 chars
-
         if process.returncode != 0:
-            logger.error(f"Ghostscript Failed with code {process.returncode}")
-            logger.error(f"Full Error Log: {process.stdout}")
-            raise Exception(f"Ghostscript failed. Check server logs for details.")
+            logger.error(f"Ghostscript Error Output:\n{process.stdout}")
+            raise Exception("Ghostscript processing failed. Check logs.")
 
-        # Check File Sizes
+        # Check Output
         if not os.path.exists(output_path) or os.path.getsize(output_path) == 0:
-             raise Exception("Ghostscript produced an empty file.")
+             raise Exception("Compression resulted in an empty file.")
 
         original_size = os.path.getsize(input_path)
         compressed_size = os.path.getsize(output_path)
         
-        # Failsafe: Return original if compression failed to reduce size
+        # === FAILSAFE ===
+        # If the file got bigger, return the original file instead of the bad one.
         final_path = output_path
         final_size = compressed_size
         output_filename = f"{os.path.splitext(file.filename)[0]}_compressed.pdf"
         
         if compressed_size >= original_size:
-            logger.info("Compression did not reduce size. Returning original.")
+            logger.info(f"Compression ineffective ({compressed_size} > {original_size}). Returning original.")
             final_path = input_path
             final_size = original_size
             output_filename = f"{os.path.splitext(file.filename)[0]}_original.pdf"
-            background_tasks.add_task(cleanup_files, output_path)
+            background_tasks.add_task(cleanup_files, output_path) # Delete the useless compressed file
         else:
-            background_tasks.add_task(cleanup_files, input_path)
+            background_tasks.add_task(cleanup_files, input_path) # Delete input file
 
-        # Ensure we clean up whatever we send eventually
-        # Note: We can't delete the file we are sending immediately, 
-        # so we rely on background_tasks or OS cleanup
-        if final_path == output_path:
-             background_tasks.add_task(cleanup_files, input_path, output_path)
-        else:
-             background_tasks.add_task(cleanup_files, input_path, output_path)
+        # Ensure cleanup runs eventually
+        background_tasks.add_task(cleanup_files, input_path, output_path)
 
         reduction = ((original_size - final_size) / original_size) * 100
 
@@ -162,8 +145,7 @@ async def compress_pdf(
         )
 
     except Exception as e:
-        logger.exception("Compression Exception")
+        logger.exception("Server Error")
         cleanup_files(input_path, output_path)
-        # Return the actual error message to the frontend for debugging
         raise HTTPException(status_code=500, detail=str(e))