Update server.js

server.js

@@ -4,54 +4,81 @@ const cheerio = require('cheerio');
 const app = express();
 const PORT = 7860;
 
-// Middleware to log requests
+// Enhanced logging middleware
 app.use((req, res, next) => {
-    console.log(`[${new Date().toISOString()}] ${req.method} ${req.path}`);
+    console.log(`[${new Date().toISOString()}] ${req.method} ${req.originalUrl}`);
     next();
 });
 
+// Data cleaning utility
+const cleanData = (text) => {
+    return text
+        .replace(/\n/g, ' ')      // Remove newlines
+        .replace(/\s+/g, ' ')     // Collapse whitespace
+        .replace(/\\/g, '')       // Remove backslashes
+        .trim();
+};
+
+// Improved error handling middleware
+app.use((err, req, res, next) => {
+    console.error(`[ERROR] ${req.method} ${req.originalUrl}: ${err.message}`);
+    res.status(500).json({
+        error: 'Internal server error',
+        regno: req.params.regno
+    });
+});
+
 app.get('/fetch-regno-:regno', async (req, res) => {
     const { regno } = req.params;
-    console.log(`Fetching result for RegNo: ${regno}`);
+    const startTime = Date.now();
     
     try {
-        const url = `https://results.beup.ac.in/ResultsBTech1stSem2023_B2023Pub.aspx?Sem=I&RegNo=${regno}`;
-        
-        const response = await axios.get(url, {
-            headers: {
-                'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36',
-                'Referer': 'https://results.beup.ac.in/'
+        // Validate registration number format
+        if (!/^\d{11}$/.test(regno)) {
+            return res.status(400).json({
+                error: 'Invalid registration number format',
+                regno
+            });
+        }
+
+        const response = await axios.get(
+            `https://results.beup.ac.in/ResultsBTech1stSem2023_B2023Pub.aspx?Sem=I&RegNo=${regno}`,
+            {
+                headers: {
+                    'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36',
+                    'Referer': 'https://results.beup.ac.in/'
+                },
+                timeout: 10000
             }
-        });
+        );
 
         const $ = cheerio.load(response.data);
         
-        // Clean up the data
-        const cleanText = (selector) => {
-            return $(selector).text()
-              .replace(/\n/g, ' ')
-              .replace(/\s+/g, ' ')
-              .trim();
-        };
-
+        // Extract and clean data
         const result = {
-            name: cleanText('#lblName'),
-            regno: regno,
-            sgpa: cleanText('#lblSGPA').replace(/Cur\. CGPA.*/, '') // Remove unwanted text
+            name: cleanData($('#lblName').text()),
+            regno: regno, // Using parameter instead of page value
+            sgpa: cleanData($('#lblSGPA').text())
+                      .match(/\d+\.\d+/)?.[0] || 'N/A' // Extract numeric SGPA
         };
 
+        // Log performance
+        console.log(`[SUCCESS] ${regno} (${Date.now() - startTime}ms)`);
+        
         res.json(result);
 
     } catch (error) {
-        console.error(`Error fetching ${regno}:`, error.message);
-        res.status(500).json({ 
+        console.error(`[FAILED] ${regno}: ${error.message}`);
+        const status = error.response?.status || 500;
+        res.status(status).json({
             error: 'Failed to fetch result',
-            regno: regno
+            regno,
+            details: status === 404 ? 'Result not found' : 'Server error'
         });
     }
 });
 
 app.listen(PORT, () => {
-    console.log(`==== Application Startup at ${new Date().toISOString()} ====`);
-    console.log(`Server running on port ${PORT}`);
+    console.log(`==== Server Started at ${new Date().toISOString()} ====`);
+    console.log(`Listening on port ${PORT}`);
 });