feat: convert ROI values to percentages and update related annotations and ranges

app.py

@@ -746,6 +746,8 @@ def create_combined_roi_time_series_graph(df):
     
     # IMPORTANT: Force data types to ensure consistency
     df['roi'] = df['roi'].astype(float)  # Ensure ROI is float
+    # Convert ROI values to percentages (multiply by 100)
+    df['roi'] = df['roi'] * 100
     df['metric_type'] = df['metric_type'].astype(str)  # Ensure metric_type is string
     
     # Get min and max time for shapes
@@ -778,7 +780,7 @@ def create_combined_roi_time_series_graph(df):
         type="rect",
         fillcolor="rgba(230, 243, 255, 0.3)",
         line=dict(width=0),
-        y0=0, y1=1,  # Use a fixed positive value
+        y0=0, y1=100,  # Use a fixed positive value (percentage)
         x0=min_time, x1=max_time,
         layer="below"
     )
@@ -788,7 +790,7 @@ def create_combined_roi_time_series_graph(df):
         type="rect",
         fillcolor="rgba(255, 230, 230, 0.3)",
         line=dict(width=0),
-        y0=-1, y1=0,  # Use a fixed negative value
+        y0=-100, y1=0,  # Use a fixed negative value (percentage)
         x0=min_time, x1=max_time,
         layer="below"
     )
@@ -801,14 +803,14 @@ def create_combined_roi_time_series_graph(df):
         x0=min_time, x1=max_time
     )
     
-    # Filter out outliers (ROI values above 2 or below -2)
-    outlier_data = df[(df['roi'] > 2) | (df['roi'] < -2)].copy()
-    df_filtered = df[(df['roi'] <= 2) & (df['roi'] >= -2)].copy()
+    # Filter out outliers (ROI values above 200% or below -200%)
+    outlier_data = df[(df['roi'] > 200) | (df['roi'] < -200)].copy()
+    df_filtered = df[(df['roi'] <= 200) & (df['roi'] >= -200)].copy()
     
     # Log the outliers for better debugging
     if len(outlier_data) > 0:
         excluded_count = len(outlier_data)
-        logger.info(f"Excluded {excluded_count} data points with outlier ROI values (>2 or <-2)")
+        logger.info(f"Excluded {excluded_count} data points with outlier ROI values (>200% or <-200%)")
         
         # Group outliers by agent for detailed logging
         outlier_agents = outlier_data.groupby('agent_name')
@@ -922,7 +924,7 @@ def create_combined_roi_time_series_graph(df):
         for idx, row in avg_roi_data_with_ma.iterrows():
             timestamp = row['timestamp']
             hover_data_roi.append(
-                f"Time: {timestamp}<br>Avg ROI (3d window): {row['moving_avg']:.2f}"
+                f"Time: {timestamp}<br>Avg ROI (3d window): {row['moving_avg']:.2f}%"
             )
         
         fig.add_trace(
@@ -967,25 +969,13 @@ def create_combined_roi_time_series_graph(df):
         hovermode="closest"
     )
     
-    # Add annotations for y-axis regions
-    fig.add_annotation(
-        x=-0.08,  # Position further from the y-axis to avoid overlapping with tick labels
-        y=-0.5,    # Middle of the negative region
-        xref="paper",
-        yref="y",
-        text="Negative ROI [ratio]",
-        showarrow=False,
-        font=dict(size=16, family="Arial, sans-serif", color="black", weight="bold"),  # Adjusted font size
-        textangle=-90,  # Rotate text to be vertical
-        align="center"
-    )
-    
+    # Add single annotation for y-axis
     fig.add_annotation(
         x=-0.08,  # Position further from the y-axis to avoid overlapping with tick labels
-        y=0.5,     # Middle of the positive region
+        y=0,      # Center of the y-axis
         xref="paper",
         yref="y",
-        text="Positive ROI [ratio]",
+        text="ROI [%]",
         showarrow=False,
         font=dict(size=16, family="Arial, sans-serif", color="black", weight="bold"),  # Adjusted font size
         textangle=-90,  # Rotate text to be vertical
@@ -1010,14 +1000,14 @@ def create_combined_roi_time_series_graph(df):
         )
     )
     
-    # Update y-axis with fixed range of -1 to +1 for ROI
+    # Update y-axis with fixed range of -100% to +100% for ROI
     fig.update_yaxes(
         showgrid=True, 
         gridwidth=1, 
         gridcolor='rgba(0,0,0,0.1)',
         # Use fixed range instead of autoscaling
         autorange=False,  # Disable autoscaling
-        range=[-1, 1],  # Set fixed range from -1 to +1
+        range=[-100, 100],  # Set fixed range from -100% to +100%
         tickformat=".2f",  # Format tick labels with 2 decimal places
         tickfont=dict(size=14, family="Arial, sans-serif", color="black", weight="bold"),  # Adjusted font size
         title=None  # Remove the built-in axis title since we're using annotations
@@ -1101,15 +1091,16 @@ def create_combined_roi_time_series_graph(df):
             margin=dict(r=30, l=120, t=40, b=50)
         )
         
-        # Update y-axis with fixed range of -1 to +1 for ROI
+        # Update y-axis with fixed range of -100% to +100% for ROI
         simple_fig.update_yaxes(
             showgrid=True, 
             gridwidth=1, 
             gridcolor='rgba(0,0,0,0.1)',
             autorange=False,
-            range=[-1, 1],
+            range=[-100, 100],
             tickformat=".2f",
-            tickfont=dict(size=14, family="Arial, sans-serif", color="black", weight="bold")
+            tickfont=dict(size=14, family="Arial, sans-serif", color="black", weight="bold"),
+            title=None  # Remove the built-in axis title since we're using annotations
         )
         
         # Update x-axis with better formatting and fixed range