Update my_pages/ica.py

my_pages/ica.py

@@ -11,7 +11,7 @@ def render():
     add_instruction_text(
         """
         Explore the intention-convention-arbitrariness (ICA) framework.<br>
-        Use the sliders to adjust the three dimensions.
+        Use the sliders to adjust the three dimensions. The sum always remains 1.
         """
     )
 
@@ -23,15 +23,14 @@ def render():
             "Arbitrary": 0.34
         }
 
-    # Keep track of previous weights
-    if "prev_weights" not in st.session_state:
-        st.session_state.prev_weights = st.session_state.weights.copy()
-
     w = st.session_state.weights
-    prev_w = st.session_state.prev_weights
 
-    # --- Three sliders ---
+    # --- Slider inputs ---
     col1, col2, col3 = st.columns(3)
+    
+    # Save previous weights for difference computation
+    prev_w = w.copy()
+
     with col1:
         i_new = st.slider("Intentional", 0.0, 1.0, w["Intentional"], 0.01)
     with col2:
@@ -39,38 +38,40 @@ def render():
     with col3:
         a_new = st.slider("Arbitrary", 0.0, 1.0, w["Arbitrary"], 0.01)
 
-    # --- Adjust other sliders proportionally ---
-    # Detect which slider changed
+    # --- Detect slider changes and redistribute ---
+    changed = None
     if i_new != prev_w["Intentional"]:
+        changed = "Intentional"
         diff = i_new - prev_w["Intentional"]
-        total_other = w["Conventional"] + w["Arbitrary"]
-        if total_other > 0:
-            w["Conventional"] -= diff * (w["Conventional"] / total_other)
-            w["Arbitrary"] -= diff * (w["Arbitrary"] / total_other)
-        w["Intentional"] = i_new
-
+        others = ["Conventional", "Arbitrary"]
     elif c_new != prev_w["Conventional"]:
+        changed = "Conventional"
         diff = c_new - prev_w["Conventional"]
-        total_other = w["Intentional"] + w["Arbitrary"]
-        if total_other > 0:
-            w["Intentional"] -= diff * (w["Intentional"] / total_other)
-            w["Arbitrary"] -= diff * (w["Arbitrary"] / total_other)
-        w["Conventional"] = c_new
-
+        others = ["Intentional", "Arbitrary"]
     elif a_new != prev_w["Arbitrary"]:
+        changed = "Arbitrary"
         diff = a_new - prev_w["Arbitrary"]
-        total_other = w["Intentional"] + w["Conventional"]
-        if total_other > 0:
-            w["Intentional"] -= diff * (w["Intentional"] / total_other)
-            w["Conventional"] -= diff * (w["Conventional"] / total_other)
-        w["Arbitrary"] = a_new
-
-    # Clamp small floating point errors
-    for k in w:
-        w[k] = max(0.0, min(1.0, round(w[k], 4)))
-
-    # Update prev_weights for next run
-    st.session_state.prev_weights = w.copy()
+        others = ["Intentional", "Conventional"]
+
+    if changed:
+        # Handle slider dragged to 1
+        if locals()[changed.lower() + "_new"] >= 1.0:
+            for k in others:
+                w[k] = 0.0
+            w[changed] = 1.0
+        else:
+            total_other = w[others[0]] + w[others[1]]
+            if total_other > 0:
+                w[others[0]] -= diff * (w[others[0]] / total_other)
+                w[others[1]] -= diff * (w[others[1]] / total_other)
+            w[changed] = locals()[changed.lower() + "_new"]
+
+        # Clamp small floating point errors
+        for k in w:
+            w[k] = max(0.0, min(1.0, round(w[k], 4)))
+
+    # --- Update weights in session state immediately ---
+    st.session_state.weights = w
 
     # --- Triangle vertices ---
     vertices = np.array([