fix: WAL-inclusive backup + reachable scorecard GO + complete run log

trading/trading_state_sync.py

@@ -102,6 +102,45 @@ def _download_bytes(remote: str) -> bytes | None:
         return None
 
 
+def _consistent_db_snapshot(db_path: Path) -> bytes | None:
+    """Produce a consistent full snapshot of a SQLite DB, INCLUDING un-checkpointed
+    WAL contents.
+
+    TradingStore runs in WAL mode: recent transactions live in `trading.db-wal`
+    until a checkpoint, so a raw file copy of the main .db misses them — in
+    production this froze the remote backup days behind the live data. The
+    sqlite3 online-backup API reads *through* the WAL, giving a complete,
+    transactionally-consistent image even while the worker holds open
+    connections.
+    """
+    import sqlite3
+    import tempfile
+
+    tmp = tempfile.NamedTemporaryFile(prefix="dbsnap_", suffix=".db", delete=False)
+    tmp_path = Path(tmp.name)
+    tmp.close()
+    try:
+        src = sqlite3.connect(str(db_path))
+        try:
+            dst = sqlite3.connect(str(tmp_path))
+            try:
+                src.backup(dst)
+                dst.commit()
+            finally:
+                dst.close()
+        finally:
+            src.close()
+        return tmp_path.read_bytes()
+    except Exception as e:
+        logger.warning("trading_state: db snapshot failed for %s: %s", db_path, e)
+        return None
+    finally:
+        try:
+            tmp_path.unlink(missing_ok=True)
+        except Exception:
+            pass
+
+
 def upload_trading_state(market_id: str) -> bool:
     """Push state.json + trading.db to Supabase. Returns True if anything uploaded."""
     if not _enabled():
@@ -120,8 +159,9 @@ def upload_trading_state(market_id: str) -> bool:
     db_path = get_trading_db_path(market_id)
     if Path(db_path).exists():
         try:
-            if _upload_bytes(_db_remote(market_id), Path(db_path).read_bytes(),
-                             "application/octet-stream"):
+            payload = _consistent_db_snapshot(Path(db_path))
+            if payload and _upload_bytes(_db_remote(market_id), payload,
+                                         "application/octet-stream"):
                 ok = True
         except Exception as e:
             logger.warning("trading_state: db read/upload error (%s): %s", market_id, e)
@@ -157,6 +197,13 @@ def download_trading_state(market_id: str, *, overwrite: bool = False) -> bool:
         if body:
             db_path.parent.mkdir(parents=True, exist_ok=True)
             db_path.write_bytes(body)
+            # Drop any leftover WAL/SHM siblings: mixing a freshly-restored main
+            # file with a stale WAL from a previous incarnation corrupts state.
+            for suffix in ("-wal", "-shm"):
+                try:
+                    Path(str(db_path) + suffix).unlink(missing_ok=True)
+                except Exception:
+                    pass
             restored = True
 
     if restored: