fix: WAL-inclusive backup + reachable scorecard GO + complete run log

trading/worker.py

@@ -1045,6 +1045,11 @@ class TradingWorker:
             if int(day_retries) >= _MAX_DAILY_RETRIES:
                 logger.info("Max retries reached today (%s/%s) — done.", day_retries, _MAX_DAILY_RETRIES)
                 _write_status({"is_running": False, "status": "SKIPPED", "reason": f"Max retries ({day_retries}/{_MAX_DAILY_RETRIES})"})
+                # Record the run so scorecard consistency doesn't see a false gap
+                try:
+                    self._store.record_run(date=today, market_id=self.market_id, status="SKIPPED")
+                except Exception:
+                    pass
                 return {"date": today, "status": "SKIPPED"}
             else:
                 logger.info("No trades yet today — retry %s/%s", int(day_retries) + 1, _MAX_DAILY_RETRIES)
@@ -1067,12 +1072,20 @@ class TradingWorker:
                     logger.critical("Reconciliation failed — aborting cycle")
                     _tg_notify("recon_failed", market_id=self.market_id)
                     _write_status({"is_running": False, "status": "RECON_FAILED", "recon": recon.to_dict()})
+                    try:
+                        self._store.record_run(date=today, market_id=self.market_id, status="RECON_FAILED")
+                    except Exception:
+                        pass
                     return {"date": today, "status": "RECON_FAILED", "recon": recon.to_dict()}
             except Exception as e:
                 logger.error("Reconciliation error: %s", e)
                 # Don't kill — just warn and continue if paper
                 if self.mode == "live":
                     _write_status({"is_running": False, "status": "RECON_ERROR", "error": str(e)})
+                    try:
+                        self._store.record_run(date=today, market_id=self.market_id, status="RECON_ERROR")
+                    except Exception:
+                        pass
                     return {"date": today, "status": "RECON_ERROR", "error": str(e)}
 
         # ---- Model Risk Check ----
@@ -1175,6 +1188,10 @@ class TradingWorker:
                     ),
                 )
                 _write_status({"is_running": False, "status": "SCAN_IN_PROGRESS"})
+                try:
+                    self._store.record_run(date=today, market_id=self.market_id, status="SCAN_IN_PROGRESS")
+                except Exception:
+                    pass
                 return {"date": today, "status": "SCAN_IN_PROGRESS"}
 
             symbols = _get_eligible_symbols(market_id=self.market_id)
@@ -1187,6 +1204,10 @@ class TradingWorker:
                         "status": "MISSING_SCAN_RESULTS",
                         "reason": f"Missing scan file: {scan_results_path}",
                     })
+                    try:
+                        self._store.record_run(date=today, market_id=self.market_id, status="MISSING_SCAN_RESULTS")
+                    except Exception:
+                        pass
                     return {"date": today, "status": "MISSING_SCAN_RESULTS"}
 
                 # Check if scan is still in progress (partial results)
@@ -1202,6 +1223,10 @@ class TradingWorker:
                     # Scan still running — don't burn the day, retry later
                     logger.warning("No eligible stocks yet but scan not completed — will retry later.")
                     _write_status({"is_running": False, "status": "SCAN_IN_PROGRESS"})
+                    try:
+                        self._store.record_run(date=today, market_id=self.market_id, status="SCAN_IN_PROGRESS")
+                    except Exception:
+                        pass
                     return {"date": today, "status": "SCAN_IN_PROGRESS"}
 
                 self._store.set_state("last_run_date", today)
@@ -1224,6 +1249,10 @@ class TradingWorker:
                 logger.error("Signal generation failed: %s", e)
                 _tg_notify("signal_error", market_id=self.market_id, error=str(e))
                 _write_status({"is_running": False, "status": "SIGNAL_ERROR", "error": str(e)})
+                try:
+                    self._store.record_run(date=today, market_id=self.market_id, status="SIGNAL_ERROR")
+                except Exception:
+                    pass
                 return {"date": today, "status": "ERROR", "reason": str(e)}
 
             if df_signals.empty:
@@ -1233,6 +1262,10 @@ class TradingWorker:
                 logger.warning("No signals generated for %d symbols", len(symbols))
                 _tg_notify("no_signals", market_id=self.market_id, symbol_count=len(symbols), silent=True)
                 _write_status({"is_running": False, "status": "NO_SIGNALS"})
+                try:
+                    self._store.record_run(date=today, market_id=self.market_id, status="NO_SIGNALS")
+                except Exception:
+                    pass
                 return {"date": today, "status": "NO_SIGNALS"}
 
             # Log predictions to ModelRiskManager for future evaluation
@@ -1770,6 +1803,18 @@ class TradingWorker:
                             result = self.run_cycle()
                             status = result.get("status")
                             logger.info("Cycle: %s", status)
+                            # Back up trading state after EVERY cycle outcome —
+                            # run_cycle's own upload only runs on the full-OK
+                            # path, so early returns (SKIPPED, SCAN_IN_PROGRESS,
+                            # NO_SIGNALS, …) previously left the remote backup
+                            # stale. Throttled to one upload per 5 minutes.
+                            try:
+                                if time.time() - getattr(self, "_last_state_backup_ts", 0) > 300:
+                                    from trading.trading_state_sync import upload_trading_state
+                                    upload_trading_state(self.market_id)
+                                    self._last_state_backup_ts = time.time()
+                            except Exception as _bk_e:
+                                logger.warning("Post-cycle state backup failed: %s", _bk_e)
                             # Short retry for transient issues
                             if status in ("MISSING_SCAN_RESULTS", "SCAN_IN_PROGRESS"):
                                 logger.info("Scan not ready — retrying in 60s")