fixed loras

lora_utils.py

@@ -305,10 +305,17 @@ def _load_lora_with_peft(host, state_dict, adapter_name):
     unexpected_keys = [
         key
         for key in getattr(result, "unexpected_keys", [])
-        if ".lora_" in key or key.endswith(".alpha")
+        if ".lora_" in key
     ]
     if unexpected_keys:
         raise ValueError(f"Unexpected LoRA keys while loading adapter: {unexpected_keys[:5]}")
+    missing_keys = [
+        key
+        for key in getattr(result, "missing_keys", [])
+        if ".lora_" in key and f".{adapter_name}." in key
+    ]
+    if missing_keys:
+        raise ValueError(f"Missing LoRA keys while loading adapter: {missing_keys[:5]}")
     return result
 
 
@@ -321,6 +328,15 @@ def _iter_host_modules(host):
         return []
 
 
+def _iter_host_and_modules(host):
+    seen = set()
+    for target in (host, *_iter_host_modules(host)):
+        if id(target) in seen:
+            continue
+        seen.add(id(target))
+        yield target
+
+
 def _peft_adapter_names_on_host(host):
     adapter_names = set()
     peft_config = getattr(host, "peft_config", None)
@@ -351,7 +367,7 @@ def _adapter_names_on_host(host):
 
 def _delete_peft_adapter_on_host(host, adapter_name):
     deleted = False
-    for target in (host, *_iter_host_modules(host)):
+    for target in _iter_host_and_modules(host):
         if not hasattr(target, "delete_adapter"):
             continue
         try:
@@ -369,7 +385,7 @@ def _delete_peft_adapter_on_host(host, adapter_name):
 def _set_peft_adapters_on_host(host, adapter_names, adapter_weights):
     changed = False
     if not adapter_names:
-        for target in (host, *_iter_host_modules(host)):
+        for target in _iter_host_and_modules(host):
             if hasattr(target, "enable_adapters"):
                 try:
                     target.enable_adapters(False)
@@ -378,17 +394,18 @@ def _set_peft_adapters_on_host(host, adapter_names, adapter_weights):
                     pass
         return changed
 
-    for target in (host, *_iter_host_modules(host)):
+    for target in _iter_host_and_modules(host):
         if hasattr(target, "set_adapter"):
             try:
                 target.set_adapter(adapter_names)
                 changed = True
             except TypeError:
-                try:
-                    target.set_adapter(adapter_names[0] if len(adapter_names) == 1 else adapter_names)
-                    changed = True
-                except Exception:
-                    pass
+                if len(adapter_names) == 1:
+                    try:
+                        target.set_adapter(adapter_names[0])
+                        changed = True
+                    except Exception:
+                        pass
             except Exception:
                 pass
         if hasattr(target, "enable_adapters"):