File size: 9,365 Bytes
6172a47 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 | import asyncio
import os
import time
import pytest
import pytest_asyncio
# Set environment variables relative to test execution
os.environ["MESSAGING_RATE_LIMIT"] = "1"
os.environ["MESSAGING_RATE_WINDOW"] = "0.5"
import contextlib
from messaging.limiter import MessagingRateLimiter
class TestMessagingRateLimiter:
"""Tests for MessagingRateLimiter."""
@pytest_asyncio.fixture(autouse=True)
async def reset_limiter(self):
"""Reset singleton and environment before each test."""
# Ensure the singleton worker is stopped between tests to avoid dangling tasks.
await MessagingRateLimiter.shutdown_instance(timeout=0.1)
os.environ["MESSAGING_RATE_LIMIT"] = "1"
os.environ["MESSAGING_RATE_WINDOW"] = "0.5"
yield
await MessagingRateLimiter.shutdown_instance(timeout=0.1)
@pytest.mark.asyncio
async def test_singleton_pattern(self):
"""Test that get_instance returns the same object."""
limiter1 = await MessagingRateLimiter.get_instance()
limiter2 = await MessagingRateLimiter.get_instance()
assert limiter1 is limiter2
@pytest.mark.asyncio
async def test_compaction(self):
"""
Verify multiple rapid requests with same dedup_key are compacted.
Logic ported from verify_limiter.py
"""
# Set slow rate for testing compaction
os.environ["MESSAGING_RATE_LIMIT"] = "1"
os.environ["MESSAGING_RATE_WINDOW"] = "1.0"
# Must reset instance to pick up new env vars
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
call_counts = {}
async def mock_edit(msg_id, content):
call_counts[msg_id] = call_counts.get(msg_id, 0) + 1
return f"done_{content}"
# Spam 5 edits
for i in range(5):
limiter.fire_and_forget(
lambda i=i: mock_edit("msg1", f"update_{i}"), dedup_key="edit:msg1"
)
# Wait for processing
# 1st might go through immediately, subsequent ones queue and compact
await asyncio.sleep(2.5)
# Expected: ~2 calls (first and last)
assert call_counts["msg1"] <= 2, (
f"Expected compaction to reduce calls, but got {call_counts.get('msg1', 0)}"
)
assert call_counts["msg1"] >= 1, "Expected at least one call"
@pytest.mark.asyncio
async def test_compaction_and_futures_resolution(self):
"""
Verify that even when compacted, all futures resolve to the result of the LAST execution.
Logic ported from verify_limiter_v2.py
"""
os.environ["MESSAGING_RATE_LIMIT"] = "1"
os.environ["MESSAGING_RATE_WINDOW"] = "0.5"
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
call_counts = {}
msg_id = "test_msg_hang"
async def mock_edit(mid, content):
call_counts[mid] = call_counts.get(mid, 0) + 1
await asyncio.sleep(0.05)
return f"result_{content}"
async def task(i):
return await limiter.enqueue(
lambda i=i: mock_edit(msg_id, f"v{i}"), dedup_key=f"edit:{msg_id}"
)
start_time = time.time()
# Enqueue 3 tasks concurrently
results = await asyncio.gather(task(1), task(2), task(3))
duration = time.time() - start_time
# All results should be the LAST one executed
for res in results:
assert res == "result_v3", f"Expected result_v3, got {res}"
# Should be reasonably fast
assert duration < 2.0, "Execution took too long"
# Calls should be compacted
assert call_counts[msg_id] <= 2, f"Too many actual calls: {call_counts[msg_id]}"
@pytest.mark.asyncio
async def test_flood_wait_handling(self):
"""Test that FloodWait exceptions pause the worker."""
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
# Mock exception with .seconds attribute
class FloodWait(Exception):
def __init__(self, seconds):
self.seconds = seconds
super().__init__(f"Flood wait {seconds}s")
call_count = 0
async def mock_fail():
nonlocal call_count
call_count += 1
raise FloodWait(1) # 1 second wait
async def mock_success():
nonlocal call_count
call_count += 1
return "success"
# First call fails and triggers pause
with contextlib.suppress(Exception):
await limiter.enqueue(mock_fail, dedup_key="key1")
assert limiter._paused_until > 0
# Enqueue success, it should wait
start = time.time()
await limiter.enqueue(mock_success, dedup_key="key2")
duration = time.time() - start
# Should have waited at least ~1s
assert duration >= 0.9, (
f"Should have waited for FloodWait, but took {duration:.2f}s"
)
assert call_count == 2
@pytest.mark.asyncio
async def test_flood_wait_retry_after_parsing(self):
"""Error message with 'retry after N' parses the wait seconds."""
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
async def mock_flood():
raise Exception("Flood wait: retry after 2 seconds")
with contextlib.suppress(Exception):
await limiter.enqueue(mock_flood, dedup_key="retry_parse")
# Should have parsed "after 2" -> 2 seconds
assert limiter._paused_until > 0
@pytest.mark.asyncio
async def test_non_flood_exception_no_pause(self):
"""Non-flood exception doesn't trigger pause."""
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
async def mock_error():
raise ValueError("some regular error")
with contextlib.suppress(ValueError):
await limiter.enqueue(mock_error, dedup_key="non_flood")
# Should NOT have paused since it's not a flood error
assert limiter._paused_until == 0
@pytest.mark.asyncio
async def test_flood_with_seconds_attribute(self):
"""Exception with .seconds attribute uses that value for pause."""
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
class FloodWaitCustom(Exception):
def __init__(self):
self.seconds = 2
super().__init__("Flood wait custom")
async def mock_flood():
raise FloodWaitCustom()
with contextlib.suppress(Exception):
await limiter.enqueue(mock_flood, dedup_key="flood_sec")
assert limiter._paused_until > 0
@pytest.mark.asyncio
async def test_proactive_strict_sliding_window(self):
"""
Proactive limiter should enforce a strict sliding window:
for any i, t[i+rate_limit] - t[i] >= rate_window (within tolerance).
"""
os.environ["MESSAGING_RATE_LIMIT"] = "2"
os.environ["MESSAGING_RATE_WINDOW"] = "0.5"
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
async def acquire(i: int) -> float:
async def _do() -> float:
return time.monotonic()
return await limiter.enqueue(_do, dedup_key=f"strict:{i}")
acquired = await asyncio.gather(*(acquire(i) for i in range(5)))
acquired.sort()
rate_limit = 2
rate_window = 0.5
tolerance = 0.05
for i in range(len(acquired) - rate_limit):
assert acquired[i + rate_limit] - acquired[i] >= rate_window - tolerance, (
f"Sliding window violated at i={i}: "
f"dt={acquired[i + rate_limit] - acquired[i]:.3f}s"
)
@pytest.mark.asyncio
async def test_compaction_last_task_fails_all_futures_get_exception(self):
"""When compacted task's last func fails, all futures get the exception."""
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
async def ok_task():
return "ok"
async def fail_task():
raise RuntimeError("last task failed")
future1 = asyncio.create_task(limiter.enqueue(ok_task, dedup_key="fail_key"))
future2 = asyncio.create_task(limiter.enqueue(fail_task, dedup_key="fail_key"))
with pytest.raises(RuntimeError, match="last task failed"):
await future1
with pytest.raises(RuntimeError, match="last task failed"):
await future2
@pytest.mark.asyncio
async def test_fire_and_forget_failure_logged(self, caplog):
"""fire_and_forget with failing task logs error and does not re-raise."""
MessagingRateLimiter._instance = None
limiter = await MessagingRateLimiter.get_instance()
async def fail_task():
raise ValueError("fire_and_forget failed")
limiter.fire_and_forget(fail_task, dedup_key="fire_fail")
await asyncio.sleep(1.5)
assert any("fire_and_forget failed" in str(r) for r in caplog.records)
|