Preview: remove duplicate base64; add 'Download Poster (PDF)' file output; wire yields to 5 outputs

app.py

@@ -494,7 +494,6 @@ def _pdf_to_iframe_html(pdf_path: Path, width="100%", height="900px") -> str:
         return (
             f"<div style='border:1px solid #ddd;border-radius:8px;overflow:hidden'>"
             f"<embed type='application/pdf' width='{width}' height='{height}' src='data:application/pdf;base64,{b64}'></embed>"
-            f"<div style='padding:8px'><a download='poster.pdf' href='data:application/pdf;base64,{b64}'>⬇️ Download PDF</a></div>"
             f"</div>"
         )
     except Exception:
@@ -977,7 +976,7 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
     POSTER_LATEX_DIR = WORK_DIR / "posterbuilder" / "latex_proj"
 
     _write_logs(LOG_PATH, logs)
-    yield "\n".join(logs), "", None, ""
+    yield "\n".join(logs), "", None, None, ""
 
     # ====== Validation: must upload LOGO ======
     if logo_files is None:
@@ -1004,7 +1003,7 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
         saved_logo_paths.append(p)
     logs.append(f"🏷️ Saved {len(saved_logo_paths)} logo file(s) → {LOGO_DIR.relative_to(WORK_DIR)}")
     _write_logs(LOG_PATH, logs)
-    yield "\n".join(logs), "", None, ""
+    yield "\n".join(logs), "", None, None, ""
 
     # ====== Handle uploaded PDF (optional) ======
     pdf_path = None
@@ -1019,14 +1018,14 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
         canonical_pdf = INPUT_DIR / "paper.pdf"
         shutil.copy(pdf_file.name, canonical_pdf)
         _write_logs(LOG_PATH, logs)
-        yield "\n".join(logs), "", None, ""
+        yield "\n".join(logs), "", None, None, ""
 
     # ====== Validate input source ======
     if not arxiv_url and not pdf_file:
         msg = "❌ Please provide either an arXiv link or upload a PDF file (choose one)."
         logs.append(msg)
         _write_logs(LOG_PATH, logs)
-        yield "\n".join(logs), "", None, ""
+        yield "\n".join(logs), "", None, None, ""
         return
 
     # ====== Build command (run INSIDE workspace) ======
@@ -1047,7 +1046,7 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
     logs.append("\n======= REAL-TIME LOG =======")
     logs.append(f"cwd = runs/{WORK_DIR.name}")
     _write_logs(LOG_PATH, logs)
-    yield "\n".join(logs), "", None, ""
+    yield "\n".join(logs), "", None, None, ""
 
     # ====== Run with REAL-TIME streaming, inside workspace ======
     try:
@@ -1064,7 +1063,7 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
         msg = f"❌ Pipeline failed to start: {e}"
         logs.append(msg)
         _write_logs(LOG_PATH, logs)
-        yield "\n".join(logs), "", None, ""
+        yield "\n".join(logs), "", None, None, ""
         return
 
     last_yield = time.time()
@@ -1078,7 +1077,7 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
                 except Exception:
                     pass
                 _write_logs(LOG_PATH, logs)
-                yield "\n".join(logs), "", None, ""
+                yield "\n".join(logs), "", None, None, ""
                 return
 
             line = process.stdout.readline()
@@ -1089,7 +1088,7 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
                 now = time.time()
                 if now - last_yield >= 0.3:
                     last_yield = now
-                    yield "\n".join(logs), "", None, ""
+                    yield "\n".join(logs), "", None, None, ""
             elif process.poll() is not None:
                 break
             else:
@@ -1098,18 +1097,18 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
         return_code = process.wait()
         logs.append(f"\nProcess finished with code {return_code}")
         _write_logs(LOG_PATH, logs)
-        yield "\n".join(logs), "", None, ""
+        yield "\n".join(logs), "", None, None, ""
 
         if return_code != 0:
             logs.append("❌ Process exited with non-zero status. See logs above.")
             _write_logs(LOG_PATH, logs)
-            yield "\n".join(logs), "", None, ""
+            yield "\n".join(logs), "", None, None, ""
             return
 
     except Exception as e:
         logs.append(f"❌ Error during streaming: {e}")
         _write_logs(LOG_PATH, logs)
-        yield "\n".join(logs), "", None, ""
+        yield "\n".join(logs), "", None, None, ""
         return
     finally:
         try:
@@ -1132,7 +1131,7 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
         msg = "❌ No output generated. Please check logs above."
         logs.append(msg)
         _write_logs(LOG_PATH, logs)
-        yield "\n".join(logs), "", None, ""
+        yield "\n".join(logs), "", None, None, ""
         return
 
     # ====== NEW: Post-processing (optional features) ======
@@ -1150,25 +1149,20 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
     _ensure_left_logo_or_disable(OUTPUT_DIR, logs)
 
     _write_logs(LOG_PATH, logs)
-    yield "\n".join(logs), "", None, ""
+    yield "\n".join(logs), "", None, None, ""
 
 
     _write_logs(LOG_PATH, logs)
-    yield "\n".join(logs), "", None, ""
+    yield "\n".join(logs), "", None, None, ""
 
     # ====== Compile PDF (for inline preview) ======
     pdf_html = ""
+    compiled_pdf_file = None
     try:
         pdf_path = _compile_poster_pdf(OUTPUT_DIR, logs)
         if pdf_path and pdf_path.exists():
-            try:
-                b64 = base64.b64encode(pdf_path.read_bytes()).decode("utf-8")
-                open_tab = f"<a target='_blank' rel='noopener' href='data:application/pdf;base64,{b64}'>Open PDF in new tab</a>"
-                pdf_html = (
-                    f"<div style='margin-bottom:8px'>{open_tab}</div>" + _pdf_to_iframe_html(pdf_path)
-                )
-            except Exception:
-                pdf_html = _pdf_to_iframe_html(pdf_path)
+            pdf_html = _pdf_to_iframe_html(pdf_path)
+            compiled_pdf_file = str(pdf_path)
             logs.append("🖨️ PDF ready for preview in UI.")
     except Exception as e:
         logs.append(f"⚠️ PDF compile/preview skipped: {e}")
@@ -1209,6 +1203,8 @@ def run_pipeline(arxiv_url, pdf_file, openai_key, logo_files, meeting_logo_file,
     _write_logs(LOG_PATH, logs)
     yield "\n".join(logs), (
         pdf_html
+    ), (
+        compiled_pdf_file
     ), (
         str(ZIP_PATH) if ZIP_PATH.exists() else None
     ), render_overleaf_button(overleaf_zip_b64)
@@ -1277,7 +1273,7 @@ The framework builds upon [CAMEL-ai](https://github.com/camel-ai/camel).
     run_btn.click(
         fn=run_pipeline,
         inputs=[arxiv_in, pdf_in, key_in, inst_logo_in, conf_logo_in, theme_in],
-        outputs=[logs_out, pdf_out, zip_out, overleaf_out],
+        outputs=[logs_out, pdf_out, pdf_file_out, zip_out, overleaf_out],
     )
     debug_zip_btn.click(fn=debug_compile_output_zip, inputs=[], outputs=[debug_zip_out])
     debug_last_btn.click(fn=debug_compile_last_pipeline_zip, inputs=[], outputs=[debug_last_out])