Merge pull request #2 from will-rice/perf/deferred-review-followups

Deferred review follow-ups: bake embedding model, cap list_recent days

Dockerfile

@@ -13,6 +13,9 @@ WORKDIR /app
 
 COPY --chown=user pyproject.toml uv.lock ./
 RUN uv sync --frozen --no-dev --no-install-project
+# Bake the embedding model into the image so startup doesn't hit the HF Hub.
+RUN uv run --no-sync python -c "from sentence_transformers import SentenceTransformer; \
+    SentenceTransformer('sentence-transformers/all-MiniLM-L6-v2', device='cpu')"
 COPY --chown=user . .
 RUN uv sync --frozen --no-dev
 

src/papers_mcp/server.py

@@ -26,6 +26,7 @@ CORPORA = {
 DATA_DIR = Path("data")
 REFRESH_INTERVAL_SECONDS = 6 * 60 * 60
 MAX_SEARCH_LIMIT = 50
+MAX_RECENT_DAYS = 365
 
 corpora: dict[str, Corpus] = {}
 indexes: dict[str, SearchIndex] = {}
@@ -128,8 +129,8 @@ def make_server(name: str) -> FastMCP:
     @mcp.tool()
     def list_recent(days: int = 30) -> str:
         """List papers submitted in the last N days, newest first."""
-        if days < 1:
-            raise ValueError("days must be at least 1")
+        if not 1 <= days <= MAX_RECENT_DAYS:
+            raise ValueError(f"days must be between 1 and {MAX_RECENT_DAYS}")
         cutoff = (date.today() - timedelta(days=days)).isoformat()
         recent = sorted(
             (p for p in corpora[name].papers.values() if p.submitted >= cutoff),

tests/test_server.py

@@ -97,3 +97,12 @@ def test_list_recent_tool(client: TestClient) -> None:
     assert len(dates) > 5
     assert dates == sorted(dates, reverse=True)  # newest first
     assert min(dates) >= (date.today() - timedelta(days=365)).isoformat()
+
+
+def test_list_recent_days_over_cap_is_an_error(client: TestClient) -> None:
+    resp = client.post(
+        "/lipsync/mcp",
+        json=rpc("tools/call", {"name": "list_recent", "arguments": {"days": 366}}),
+        headers=MCP_HEADERS,
+    )
+    assert resp.json()["result"]["isError"] is True

uv.lock

@@ -976,6 +976,7 @@ dependencies = [
     { name = "mcp" },
     { name = "rank-bm25" },
     { name = "sentence-transformers" },
+    { name = "starlette" },
     { name = "uvicorn" },
 ]
 
@@ -991,6 +992,7 @@ requires-dist = [
     { name = "mcp", specifier = ">=1.27,<2" },
     { name = "rank-bm25", specifier = ">=0.2.2" },
     { name = "sentence-transformers", specifier = ">=3.0" },
+    { name = "starlette" },
     { name = "uvicorn", specifier = ">=0.30" },
 ]