Update app.py

app.py

@@ -19,6 +19,9 @@ import uuid
 import hashlib
 from enum import Enum
 import random
+import time
+from requests.adapters import HTTPAdapter
+from urllib3.util.retry import Retry
 
 # External OCI API URL - YOUR BUCKET SAVING API
 OCI_API_BASE_URL = "https://yukee1992-oci-story-book.hf.space"
@@ -490,7 +493,7 @@ def refresh_local_images():
 
 # OCI BUCKET FUNCTIONS
 def save_to_oci_bucket(image, text_content, story_title, page_number, file_type="image"):
-    """Save both images and text to OCI bucket via your OCI API"""
+    """Save both images and text to OCI bucket via your OCI API with retry logic"""
     try:
         if file_type == "image":
             # Convert image to bytes
@@ -513,7 +516,20 @@ def save_to_oci_bucket(image, text_content, story_title, page_number, file_type=
             'subfolder': f'stories/{story_title}'
         }
         
-        response = requests.post(api_url, files=files, data=data, timeout=30)
+        # Create session with retry strategy
+        session = requests.Session()
+        retry_strategy = Retry(
+            total=3,  # Retry 3 times
+            status_forcelist=[429, 500, 502, 503, 504],  # Retry on these status codes
+            method_whitelist=["POST"],  # Only retry on POST requests
+            backoff_factor=1  # Wait 1, 2, 4 seconds between retries
+        )
+        adapter = HTTPAdapter(max_retries=retry_strategy)
+        session.mount("http://", adapter)
+        session.mount("https://", adapter)
+        
+        # INCREASED TIMEOUT WITH RETRY LOGIC
+        response = session.post(api_url, files=files, data=data, timeout=60)
         
         print(f"📨 OCI API Response: {response.status_code}")
         
@@ -708,37 +724,64 @@ def generate_storybook_background(job_id: str):
                     story_request.consistency_seed
                 )
                 
-                # Save IMAGE to OCI bucket
-                image_url = save_to_oci_bucket(
-                    image, 
-                    "",  # No text for image
-                    story_request.story_title, 
-                    i + 1, 
-                    "image"
-                )
-                
-                # Save TEXT to OCI bucket
-                text_url = save_to_oci_bucket(
-                    None,  # No image for text
-                    scene.text, 
-                    story_request.story_title, 
-                    i + 1, 
-                    "text"
-                )
-                
-                # Store page data
-                page_data = {
-                    "page_number": i + 1,
-                    "image_url": image_url,
-                    "text_url": text_url,
-                    "text_content": scene.text,
-                    "visual_description": scene.visual,
-                    "characters_present": characters_present,
-                    "prompt_used": f"Dynamic consistent generation with {len(characters_present)} characters"
-                }
-                generated_pages.append(page_data)
+                # ADD LOCAL FALLBACK SAVE
+                local_filepath, local_filename = save_image_to_local(image, scene.visual, story_request.style)
+                print(f"💾 Image saved locally as backup: {local_filename}")
                 
-                print(f"✅ Page {i+1} completed - Characters: {characters_present}")
+                try:
+                    # Save IMAGE to OCI bucket
+                    image_url = save_to_oci_bucket(
+                        image, 
+                        "",  # No text for image
+                        story_request.story_title, 
+                        i + 1, 
+                        "image"
+                    )
+                    
+                    # Save TEXT to OCI bucket
+                    text_url = save_to_oci_bucket(
+                        None,  # No image for text
+                        scene.text, 
+                        story_request.story_title, 
+                        i + 1, 
+                        "text"
+                    )
+                    
+                    # Store page data
+                    page_data = {
+                        "page_number": i + 1,
+                        "image_url": image_url,
+                        "text_url": text_url,
+                        "text_content": scene.text,
+                        "visual_description": scene.visual,
+                        "characters_present": characters_present,
+                        "prompt_used": f"Dynamic consistent generation with {len(characters_present)} characters",
+                        "local_backup_path": local_filepath  # Store local path as backup
+                    }
+                    generated_pages.append(page_data)
+                    
+                    print(f"✅ Page {i+1} completed - Characters: {characters_present}")
+                    
+                except Exception as upload_error:
+                    # If OCI upload fails, use local file as fallback
+                    error_msg = f"OCI upload failed for page {i+1}, using local backup: {str(upload_error)}"
+                    print(f"⚠️ {error_msg}")
+                    
+                    page_data = {
+                        "page_number": i + 1,
+                        "image_url": f"local://{local_filepath}",  # Mark as local file
+                        "text_url": f"local://text_content_{i+1}",
+                        "text_content": scene.text,
+                        "visual_description": scene.visual,
+                        "characters_present": characters_present,
+                        "prompt_used": f"Dynamic consistent generation with {len(characters_present)} characters",
+                        "local_backup_path": local_filepath,
+                        "upload_error": str(upload_error)
+                    }
+                    generated_pages.append(page_data)
+                    
+                    # Continue with next page instead of failing completely
+                    continue
                 
             except Exception as e:
                 error_msg = f"Failed to generate page {i+1}: {str(e)}"
@@ -749,6 +792,10 @@ def generate_storybook_background(job_id: str):
         # Complete the job
         generation_time = time.time() - start_time
         
+        # Count successful OCI uploads vs local fallbacks
+        oci_success_count = sum(1 for page in generated_pages if not page.get("upload_error"))
+        local_fallback_count = sum(1 for page in generated_pages if page.get("upload_error"))
+        
         result = {
             "story_title": story_request.story_title,
             "total_pages": total_scenes,
@@ -763,19 +810,28 @@ def generate_storybook_background(job_id: str):
             "file_structure": {
                 "images": [f"page_{i+1:03d}.png" for i in range(total_scenes)],
                 "texts": [f"page_{i+1:03d}.txt" for i in range(total_scenes)]
+            },
+            "upload_summary": {
+                "oci_successful": oci_success_count,
+                "local_fallback": local_fallback_count,
+                "total_attempted": total_scenes
             }
         }
         
+        status_message = f"🎉 Storybook completed! {len(generated_pages)} pages with {len(story_request.characters)} dynamic characters created in {generation_time:.2f}s."
+        if local_fallback_count > 0:
+            status_message += f" {local_fallback_count} pages saved locally due to OCI upload issues."
+        
         update_job_status(
             job_id, 
             JobStatus.COMPLETED, 
             100, 
-            f"🎉 Storybook completed! {len(generated_pages)} pages with {len(story_request.characters)} dynamic characters created in {generation_time:.2f}s.",
+            status_message,
             result
         )
         
         print(f"🎉 DYNAMIC Storybook generation finished for job {job_id}")
-        print(f"📁 Saved to: stories/{story_request.story_title} in OCI bucket")
+        print(f"📁 OCI Uploads: {oci_success_count} successful, {local_fallback_count} local fallbacks")
         print(f"👥 Dynamic character consistency maintained for {len(story_request.characters)} characters across {total_scenes} scenes")
         
     except Exception as e: