Update app.py

app.py

@@ -632,22 +632,29 @@ def create_text_overlay(input_video, output_video, text_style):
     work_dir = os.path.dirname(output_video)
     ass_file = os.path.join(work_dir, "subtitle.ass")
     
+    # Color mapping
+    COLOR_MAP = {
+        "white": "FFFFFF", "black": "000000", "red": "FF0000",
+        "green": "00FF00", "blue": "0000FF", "yellow": "FFFF00",
+        "gold": "FFD700", "purple": "800080", "magenta": "FF00FF",
+        "cyan": "00FFFF", "orange": "FFA500", "pink": "FFC0CB"
+    }
+    
     # Get font color and convert from RRGGBB to BBGGRR for ASS
     font_color_rgb = COLOR_MAP.get(text_style.color.lower(), "FFFFFF")
     # Convert RGB to BGR (swap first two and last two characters)
     font_color_bgr = font_color_rgb[4:6] + font_color_rgb[2:4] + font_color_rgb[0:2]
     print(f"🎨 Font color: {text_style.color} -> RGB={font_color_rgb} -> BGR={font_color_bgr}")
     
-    # Parse background color with proper alpha calculation
+    # Parse background color
     bg_parts = text_style.bg_color.split('@')
     bg_color_name = bg_parts[0].lower()
     bg_opacity = float(bg_parts[1]) if len(bg_parts) > 1 else 0.5
-    # Clamp opacity between 0 and 1
     bg_opacity = max(0, min(1, bg_opacity))
     bg_color_rgb = COLOR_MAP.get(bg_color_name, "000000")
     # Convert RGB to BGR for background
     bg_color_bgr = bg_color_rgb[4:6] + bg_color_rgb[2:4] + bg_color_rgb[0:2]
-    # Alpha should be (1 - opacity) * 255, where alpha=0 is fully opaque
+    # Alpha: 0 = opaque, 255 = transparent
     bg_alpha = int((1 - bg_opacity) * 255)
     print(f"🎨 BG color: {bg_color_name} -> RGB={bg_color_rgb} -> BGR={bg_color_bgr}, Opacity={bg_opacity}, Alpha={bg_alpha}")
     
@@ -680,7 +687,7 @@ def create_text_overlay(input_video, output_video, text_style):
     os.environ['FONTCONFIG_FILE'] = fc_file
     
     # Create ASS file content with solid rectangle background
-    # BorderStyle=3 gives a solid box, Outline controls padding
+    # BorderStyle=3 gives solid box, Outline controls padding
     ass_content = f"""[Script Info]
 ; Script generated by Video Styling Space
 ScriptType: v4.00+
@@ -709,52 +716,54 @@ Dialogue: 0,0:00:00.00,0:00:10.00,Default,,0,0,0,,{text_style.text}"""
     print(f"📝 Created ASS subtitle file with font family: {font_family_name}")
     print(f"📝 Style line: BorderStyle=3, Outline={text_style.padding}, BackColor=&H{bg_alpha:02X}{bg_color_bgr}")
     
-    # Run FFmpeg
-    cmd = [
+    # Try drawtext method first (more reliable for backgrounds)
+    print("🎬 Using drawtext method for reliable backgrounds...")
+    drawtext_pos = {
+        "bottom-left": "x=20:y=h-th-20",
+        "bottom-center": "x=(w-tw)/2:y=h-th-20",
+        "bottom-right": "x=w-tw-20:y=h-th-20",
+        "center": "x=(w-tw)/2:y=(h-th)/2",
+        "top-left": "x=20:y=20",
+        "top-center": "x=(w-tw)/2:y=20",
+        "top-right": "x=w-tw-20:y=20"
+    }
+    position = drawtext_pos.get(text_style.position, "x=(w-tw)/2:y=(h-th)/2")
+    
+    # Use the actual color name for drawtext
+    drawtext_cmd = [
         'ffmpeg', '-y',
         '-i', input_video,
-        '-vf', f"ass={ass_file}",
+        '-vf', f"drawtext=text='{text_style.text}':fontfile={font_path}:fontsize={text_style.font_size}:fontcolor={text_style.color}:{position}:box=1:boxcolor={bg_color_name}@{bg_opacity}:boxborderw={text_style.padding}",
         '-c:a', 'copy',
         output_video
     ]
     
-    print(f"🎬 Running FFmpeg with ASS filter...")
-    result = subprocess.run(cmd, capture_output=True, text=True)
+    print(f"🎬 Running drawtext command...")
+    result = subprocess.run(drawtext_cmd, capture_output=True, text=True)
     
-    if result.returncode != 0:
-        print(f"❌ FFmpeg error: {result.stderr}")
-        
-        # Try alternative drawtext method as fallback
-        print("🔄 Trying alternative drawtext method...")
-        drawtext_pos = {
-            "bottom-left": "x=20:y=h-th-20",
-            "bottom-center": "x=(w-tw)/2:y=h-th-20",
-            "bottom-right": "x=w-tw-20:y=h-th-20",
-            "center": "x=(w-tw)/2:y=(h-th)/2",
-            "top-left": "x=20:y=20",
-            "top-center": "x=(w-tw)/2:y=20",
-            "top-right": "x=w-tw-20:y=20"
-        }
-        position = drawtext_pos.get(text_style.position, "x=(w-tw)/2:y=(h-th)/2")
+    if result.returncode == 0:
+        print(f"✅ Drawtext method succeeded with solid background")
+        return True
+    else:
+        print(f"❌ Drawtext failed: {result.stderr}")
+        print("🔄 Falling back to ASS method...")
         
-        drawtext_cmd = [
+        # Try ASS method as fallback
+        cmd = [
             'ffmpeg', '-y',
             '-i', input_video,
-            '-vf', f"drawtext=text='{text_style.text}':fontfile={font_path}:fontsize={text_style.font_size}:fontcolor={text_style.color}:{position}:box=1:boxcolor={bg_color_name}@{bg_opacity}:boxborderw={text_style.padding}",
+            '-vf', f"ass={ass_file}",
             '-c:a', 'copy',
             output_video
         ]
         
-        result2 = subprocess.run(drawtext_cmd, capture_output=True, text=True)
+        result2 = subprocess.run(cmd, capture_output=True, text=True)
         if result2.returncode == 0:
-            print(f"✅ Alternative drawtext method succeeded")
+            print(f"✅ ASS method succeeded")
             return True
         else:
-            print(f"❌ Alternative drawtext also failed: {result2.stderr}")
+            print(f"❌ ASS method also failed: {result2.stderr}")
             return False
-    
-    print(f"✅ Video styled successfully with ASS subtitles")
-    return True
 
 # =============================================
 # DEBUG ENDPOINTS