Use temp download dir and robust rmtree handler to avoid permission errors on cleanup

download_model.py

@@ -2,6 +2,8 @@
 
 import os
 import shutil
+import tempfile
+import stat
 from pathlib import Path
 
 from huggingface_hub import HfApi, snapshot_download
@@ -64,16 +66,38 @@ def main() -> None:
             if cached.exists():
                 print(f"using cached model: {cached}")
                 return
-    download_dir = models_dir / ".download"
+    # Use a temporary directory (under /tmp) for downloads to avoid permission issues
+    download_dir = Path(tempfile.mkdtemp(prefix="hf-download-"))
 
     # allow user to request a specific file in the repo (useful when repo has no .gguf)
     model_file_override = os.environ.get("MODEL_FILE", "").strip()
 
     # previous cache check moved above
 
-    if download_dir.exists():
-        shutil.rmtree(download_dir)
-    download_dir.mkdir(parents=True, exist_ok=True)
+    # Ensure any stale temp dir is removed with a permissive onerror handler
+    def _rmtree_onerror(func, path, exc_info):
+        # try to make the file writable then retry
+        try:
+            os.chmod(path, stat.S_IWUSR | stat.S_IRUSR)
+        except Exception:
+            pass
+        try:
+            func(path)
+        except Exception:
+            try:
+                if os.path.isdir(path):
+                    for root, dirs, files in os.walk(path):
+                        for name in files:
+                            fp = os.path.join(root, name)
+                            try:
+                                os.chmod(fp, stat.S_IWUSR | stat.S_IRUSR)
+                            except Exception:
+                                pass
+                    func(path)
+                else:
+                    os.remove(path)
+            except Exception as e:
+                print(f"warning: failed to remove {path}: {e}", flush=True)
 
     api = HfApi(token=hf_token)
     print(f"listing model files: {model_name}", flush=True)
@@ -139,7 +163,10 @@ def main() -> None:
         repo_marker.unlink()
     repo_marker.write_text(f"{model_name}|{selected_basename}", encoding="utf-8")
 
-    shutil.rmtree(download_dir, ignore_errors=True)
+    try:
+        shutil.rmtree(download_dir, onerror=_rmtree_onerror)
+    except Exception as e:
+        print(f"warning: unable to fully remove temp download dir {download_dir}: {e}", flush=True)
     print(f"ready: {target_model}")